From patchwork Thu Nov 30 18:44:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 81054 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D3445384DEDE for ; Thu, 30 Nov 2023 19:26:08 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DCCE2386193E for ; Thu, 30 Nov 2023 19:25:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DCCE2386193E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DCCE2386193E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701372355; cv=none; b=Nf/zIcc4CCsyjadf5m0FROGUlB+9RmmWvR1gf1clBopnvnyeqLN0RXtgnmMcvqtiLlwH2ALzDf/BQX6Bm788vsX45Gf2vYEbyLxZy1sE1ED15lzJTNXg1+i+i+2nPq8xfpVXMxr1OdD3czDSQlxyTT6twtYwmjHD93uZ4aSTQ74= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701372355; c=relaxed/simple; bh=uQqkkrThMtHCvpRkhMg4uoLwtt1TaD7TaB9Wd6t6dSQ=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=RXIYC+WCk8x0mX8R1B3la+XHTQRvnyk79Am97XX+DK/RbWQ5F+hx6pdSnDQs3e+hKd/NvdV2fp5rlRMnbgyRidqYiUfqP5nmALS/ysxtiP9Jc0OPemu8o0wgF3tys+mD8lKSWq+x7/tUvt1xKYlPqFpo/f9j+fktIkRkcY4oIaE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701372353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pELvjGzEbtx8j7dOBvD4Votsye8CaS65xEmlyW3F5A0=; b=TwyfSxZtFyvikp3D4RtBhylJMKq7jGYDV1pTLpCvdZLRBRaayTL9ynxd+HkDhtu01tiF/0 541sqp//XBGyNXKqskdTul+SIIYLCRwsanm+5dUwkZ00C2FsX16mMl0lRtslk7dMGdQ+Is YD9fSJFZdoD/YMENPzaa2vnv0TcRErc= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-SBYhXHk0PT6acQ194hnANA-1; Thu, 30 Nov 2023 14:25:51 -0500 X-MC-Unique: SBYhXHk0PT6acQ194hnANA-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-54554ea191bso961272a12.2 for ; Thu, 30 Nov 2023 11:25:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701372350; x=1701977150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pELvjGzEbtx8j7dOBvD4Votsye8CaS65xEmlyW3F5A0=; b=eg/E1g9O4EJfYTGcT2e5cFsakqZSA8V3yBbR9UGOhii0xZrczbtDC+TBAv/swUFbjR biRauYMbLx1RcgmuzcGEyFNlzjD/9H8Wk/Bg/JAcPQ86NMs68MhVHA9FXhkgyWVF1UC4 81SnLydS3tltEhrzXKkfYRdiElPBSn8C+g6G5J5E7eUPud39NoXnUL5Vb00GRY41Qhis YIOx7i2rd8GDfbAH1HNz+ke888KUsDIM2FS/S4WEFwCundLPMcKFGtkrH4ECoSkmttfE LiBVQZkuVmLRt58CWmimi2BRLRbybOy3p52jEDQXcYEiqFWfNuzcF4X1y5KkvFnjgnnp VMPg== X-Gm-Message-State: AOJu0YzGkq4AafjcH6wLKibS11WTN3o9+JA5VFiq4xdtr3I6txEZ/cko 9jl/SjbUNZVzc2gNpydKDTLlo2LXWHCmquqi18YmFZcbp33xxP0MlD2f0vVoy68VVFsB+wKz9W8 FsunmIrssdVeFXHfwrpNT6oobk81wqpjBM8pn38Ir9P65QczVGdUWtBwpvG5cGboiLLFdv6gxoK ByjqXEzA== X-Received: by 2002:a50:8e4f:0:b0:547:b96:1172 with SMTP id 15-20020a508e4f000000b005470b961172mr15125edx.28.1701372350452; Thu, 30 Nov 2023 11:25:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IEFcc5yQlkrgF4kQQeZckPFpnwSK3Pi3iMXGpaLN8Fbt3LvygPVtwyWNZU8Yra0hnqSvGYZBA== X-Received: by 2002:a2e:9e47:0:b0:2c9:d863:2c27 with SMTP id g7-20020a2e9e47000000b002c9d8632c27mr5954ljk.80.1701369884774; Thu, 30 Nov 2023 10:44:44 -0800 (PST) Received: from localhost (92.40.185.184.threembb.co.uk. [92.40.185.184]) by smtp.gmail.com with ESMTPSA id gs20-20020a170906f19400b00a18374ade6bsm963988ejb.67.2023.11.30.10.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 10:44:44 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 1/3] gdb: fix GDB_DEBUG and GDBSERVER_DEBUG Makefile variables Date: Thu, 30 Nov 2023 18:44:16 +0000 Message-Id: <3f3ed68b36767340010dc080dbf3c35fbe6f2af6.1701369189.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The gdb/testsuite/README file documents GDB_DEBUG and GDBSERVER_DEBUG flags, which can be passed to make in order to enable debugging within GDB or gdbserver respectively. However, when I do: make check-gdb GDB_DEBUG=infrun I don't see the corresponding debug feature within GDB being enabled. Nor does: make check-gdb GDBSERVER_DEBUG=debug \ RUNTESTFLAGS="--target_board=native-extended-gdbserver" Appear to enable gdbserver debugging. I tracked this down to the GDB_DEBUG and GDBSERVER_DEBUG flags being missing from the TARGET_FLAGS_TO_PASS variable in gdb/Makefile. This variable already contains lots of testing related flags, like RUNTESTFLAGS and TESTS, so I think it makes sense to add GDB_DEBUG and GDBSERVER_DEBUG here too. With this done, this debug feature is now working as expected. --- gdb/Makefile.in | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 3510577f090..0886c0e8495 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -993,7 +993,10 @@ TARGET_FLAGS_TO_PASS = \ "RUNTEST=$(RUNTEST)" \ "RUNTESTFLAGS=$(RUNTESTFLAGS)" \ "FORCE_PARALLEL=$(FORCE_PARALLEL)" \ - "TESTS=$(TESTS)" + "TESTS=$(TESTS)" \ + "GDB_DEBUG=$(GDB_DEBUG)" \ + "GDBSERVER_DEBUG=$(GDBSERVER_DEBUG)" \ + # All source files that go into linking GDB.