From patchwork Tue Apr 4 10:14:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 19817 Received: (qmail 49737 invoked by alias); 4 Apr 2017 10:14:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 49723 invoked by uid 89); 4 Apr 2017 10:14:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0082.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.82) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Apr 2017 10:14:51 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0102.eurprd08.prod.outlook.com (10.160.211.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Tue, 4 Apr 2017 10:14:50 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::5931:f431:f97d:943d]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::5931:f431:f97d:943d%16]) with mapi id 15.01.1005.018; Tue, 4 Apr 2017 10:14:49 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd Subject: [PATCH 8/11] Add FRV_MAX_REGISTER_SIZE Date: Tue, 4 Apr 2017 10:14:49 +0000 Message-ID: <3B3BD949-1C9D-44FF-AB6A-03091ECA49D0@arm.com> authentication-results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-microsoft-exchange-diagnostics: 1; AM3PR08MB0102; 7:r/SrWIMgch33SJ3Jfdd+5MpUe49qZYTG2NC1go0oETKCcV8PU3OmllaV6kzxIKcaVMY8SszN/LU3/YqUvk9/TUTm8OPGsLHhayP+iBIT6LTEIJ9Lmnf3x+vLlF33cwQU+29/Y387b+RoriXl2Wx5tJbUPlCuEnTh5V8MubZId72mkPoXe01Ir4McrlnPbX31PYZ2SSPtdZ79GqBSyNDc026f5pEJv29h9KkBYSWOjH24NDLM133KkkiAmgCCrkRRsRJwFjzJQ2ZUncoQCnwT25eUlrpM/iGn01W33bTM4s1q8DsP4KmqbtsAQ7soXSMi2B8Vh4KSgmfeGUW9ITkGPQ==; 20:nFhXNWfB0OmLUXwiXdcba1ZLP/rdDu6GgIbWkbSIZWrcb2DQQ9FIhW/vqmF/oRrNJR54nVnvK1k4qfb0VIEDOcSv3Mym/1Fx/6IRd/3Lx8LrVh4btik5JLvfibCzL4Tm7D/BXjrqAJYKnnYQicAMJz3SxP7FxZqKC06SdpC6xeE= x-ms-office365-filtering-correlation-id: f32255c4-2b08-489d-0884-08d47b436da2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075); SRVR:AM3PR08MB0102; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123564025)(20161123562025)(6072148); SRVR:AM3PR08MB0102; BCL:0; PCL:0; RULEID:; SRVR:AM3PR08MB0102; x-forefront-prvs: 0267E514F9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39860400002)(39450400003)(39850400002)(39400400002)(39840400002)(377424004)(8936002)(2351001)(4326008)(81166006)(8676002)(25786009)(6916009)(5250100002)(575784001)(2906002)(86362001)(50986999)(33656002)(2900100001)(54356999)(189998001)(3660700001)(3846002)(110136004)(38730400002)(6486002)(83716003)(6506006)(66066001)(36756003)(7736002)(99286003)(5660300001)(5640700003)(82746002)(6436002)(53936002)(6116002)(305945005)(3280700002)(6512007)(102836003)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR08MB0102; H:AM3PR08MB0101.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <19A32327639143489A0E9D4A685EB777@eurprd08.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2017 10:14:49.7412 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0102 Max size set to 64bits, which I determined using frv_register_type() Tested on a --enable-targets=all build using make check with board files unix and native-gdbserver. I do not have a FRV machine to test on. Ok to commit? Alan. 2017-04-04 Alan Hayward * frv-linux-tdep.c (frv_linux_supply_gregset): Use FRV_MAX_REGISTER_SIZE. * frv-tdep.h (FRV_MAX_REGISTER_SIZE): Add. diff --git a/gdb/frv-linux-tdep.c b/gdb/frv-linux-tdep.c index eb87f93058b0287e8f05c585d1b6aa1ff2bffb78..6f5585e774c86afe7e271f90df1bf3db93340421 100644 --- a/gdb/frv-linux-tdep.c +++ b/gdb/frv-linux-tdep.c @@ -413,9 +413,9 @@ frv_linux_supply_gregset (const struct regset *regset, int regnum, const void *gregs, size_t len) { int regi; - char zerobuf[MAX_REGISTER_SIZE]; + char zerobuf[FRV_MAX_REGISTER_SIZE]; - memset (zerobuf, 0, MAX_REGISTER_SIZE); + memset (zerobuf, 0, FRV_MAX_REGISTER_SIZE); /* gr0 always contains 0. Also, the kernel passes the TBR value in this slot. */ diff --git a/gdb/frv-tdep.h b/gdb/frv-tdep.h index c1a0f35456c879c655198820f5319bf0ab42b9f7..9c8c32eb08b6e4b4d87139b201008c1ee419f6a9 100644 --- a/gdb/frv-tdep.h +++ b/gdb/frv-tdep.h @@ -92,6 +92,9 @@ enum { frv_num_pseudo_regs = last_pseudo_regnum - first_pseudo_regnum + 1, }; +/* Big enough to hold the size of the largest register in bytes. */ +#define FRV_MAX_REGISTER_SIZE 8 + /* Return the FR-V ABI associated with GDBARCH. */ enum frv_abi frv_abi (struct gdbarch *gdbarch);