[v2,57/58] gdbserver: simply copy the pointer in 'set_target_ops'
Commit Message
From: Pedro Alves <palves@redhat.com>
The 'set_target_ops' function takes a target op vector and creates a
clone of it via XNEW and memcpy. This is not necessary. 'the_target'
is a singleton, and the argument that is passed to 'set_target_ops' is
always the address of a global, static object. Therefore, update the
implementation to simply copy the pointer.
gdbserver/ChangeLog:
2020-02-10 Pedro Alves <palves@redhat.com>
* target.cc (set_target_ops): Simply copy the given target pointer
instead of creating a copy of the pointed object.
---
gdbserver/target.cc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
@@ -270,8 +270,7 @@ target_supports_multi_process (void)
void
set_target_ops (process_stratum_target *target)
{
- the_target = XNEW (process_stratum_target);
- memcpy (the_target, target, sizeof (*the_target));
+ the_target = target;
}
/* Convert pid to printable format. */