From patchwork Mon Oct 17 20:55:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 16590 Received: (qmail 105302 invoked by alias); 17 Oct 2016 20:56:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 105273 invoked by uid 89); 17 Oct 2016 20:56:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 spammy=Hx-languages-length:1716 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Oct 2016 20:55:51 +0000 Received: from ESESSHC015.ericsson.se (Unknown_Domain [153.88.183.63]) by (Symantec Mail Security) with SMTP id 27.4A.31035.4DA35085; Mon, 17 Oct 2016 22:55:49 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.63) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 17 Oct 2016 22:55:48 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.110.144] (192.75.88.130) by AM3PR07MB385.eurprd07.prod.outlook.com (2a01:111:e400:8820::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.4; Mon, 17 Oct 2016 20:55:46 +0000 Subject: Re: [PATCH] Fix -trace-save crash when argument is missing To: Yao Qi References: <20161014202536.21670-1-simon.marchi@ericsson.com> CC: "gdb-patches@sourceware.org" From: Simon Marchi Message-ID: <28f9b2c1-a6db-db14-65ae-63e4630381b1@ericsson.com> Date: Mon, 17 Oct 2016 16:55:35 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: X-ClientProxiedBy: SN1PR05CA0006.namprd05.prod.outlook.com (2a01:111:e400:5197::16) To AM3PR07MB385.eurprd07.prod.outlook.com (2a01:111:e400:8820::11) X-MS-Office365-Filtering-Correlation-Id: 38a041bd-8510-41f3-6bde-08d3f6cff851 X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB385; 2:yAaSnLBh4xgTPPQEAZbnDpyVqBK1W4zrX7UF3Z55gE4xzWCYq15qsZt2SN5ZgY3mAiyTkFROLsNUf8R/LAkuo07hlqGcPflAMdo2a3TGId1PGN7CbhVX6mwqHheHSH+dpZun4hoYONIbJ93gq+K0HDVXOrTMqxpd0jS3VLuowrMROD4kv6JAnPRjMJKvV45IYPXsAYH8a+hVkZCVy+yR5g==; 3:YJKZj7sVNGLzYREhn4r94OM6PEJ4lg+rmCH5XKCNzbhrsX5IzjFHbTn0qXhV5cIIV4675yAk987iDO+DCaAfu2kwiCQ1qmHXL6OOHG1iWtu47RFteacuPDxZJxzui1wzEJaUxgSNysUeXu41CjOAgQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR07MB385; X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB385; 25:5rsqmUrvco1PKf7vwzumS/x9KL/nW7ilSIpKMgyqXcb3Uu0MuPKbma9SRBwZG6H31U41k6x5EqeErpxuc/rFQ9LTBbOVN2OvQHCAivNDxYHdBaa75sJKkBRyfxD5eflsCY1KzdkKk9qG2JaHt4FMtdWMs3bJm/ZRRT9gFJtKUDuhfJacI//2oFLYAWM6oO+Jg4ViBYPXLsPPYE7xxIURfkLZ3orhOWIl7uXUzkSt2uuLSOk2f8HSFxk/2iaSgTo0hKUZCV2+VDLt1WVkQvj3E+nDZ6w/czYHDcOm4LLiwqGL3rZs5YLty6nUf5jmXA5gGTz/rhaRqcMeECWcYNOsSv+++frTK30EvheDg8rsYlQ9mICNOEFsJTrhon7KRrlFn6+2w+RCi+G/Opsp5vqQV3qgXBE1Zzikvu0eSWPwEJxFPkJr3ozmbgWu3OJ+IIAf1Hq8avPyCPVqPak8MhqMMkYiwtKrZpqalHjMXK/m3GJRncdc/l7Ch2d1DKRX4kX0w+LBzkuf4t2dD+ENSmJ3CcALZhNu4xFnujp6DoMVJs86DXyFz5ocHUFcnWwCSnxQg2xIe/LSHUBCteM6f6fe7/nCOxccLLkKvWHsWGBvQ3pZlVPY0RdBT6DrMUwVu5I9wam0XeMeAzjDB3QWVtBwj7faLPEFnDAqcvck1RK9HxnKeV6fInIk8YEHpAr5sFUYUjM5VlXO+zWlvWBbJs6Im+j4aPsB2SGDvYR6XpCXQB3ptbhaKaoaRXAAJPznkf/l X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB385; 31:a91HdgF0A2C/y7mTC9xRn0hEV7bJLi0w+YxPUYCVjzgr2NVYBaIJXEACVqHQLnEMbD1ME6wifevZGjyTZjndx97Tr+81halnEtAGGkQ4bgnBXm9QsWdL1f/TDn0H4hi7KXyOIf46/WdJVwF+l1do2d1ohj642P0ifQsz1xlOQXqQaiH33iCLYN+CIcQorDLQyGoAD9JQfG+IFYA3hRuFxbTHZP70CiusZ5tRElJ8pslLZyCUE0lzNIJeSdB33f/Xv28Riby8L8wpTlpBuzfbfQ==; 20:X0hQ9AIPEWQNa9g+C7tLwUQyC+ck0yi6qcGIzP95CymXcUcSB77w+xeqyh0AGl04hg5vIREYnzpIM9syz/td/Dom3gHTYhm/NuoEqC4qn/GZ9J1MTGXFGLRT+ugCV8bFFG5u+eEHIRjQl3JMXd9cOmVdRYny+kZ/Aj3ldCepMDZ6zfM9ihjxRw86/0WkNDjOD9eI89L2Jka+7oxUiybbclQWqx+ueaPnsemqJCFIMceguxW4Qiq+5zMre0DYJVOFwOQRByCQD529VwRLlPEioNNuDk6GqstO5te//gG8G9X3i0r1bIamyykZzP2306raG4bD79ZG7dCOkw2kuWpLlDKp0tiFEL4x3o6WStVv1M6KHP9aM83hC8Jr0VOyjHuFbRbp+wHs8BX0FVPvowQvdnjB/26607JNG10qgBqodkRrON5v3kkN1q9z0gtCZTIY0KDYCrLX1Z7Mppt2tCMyV4/ot+EEXG1kPDh3BxYqZaOXbEbdM0H2dt8inRzSw+gx X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:AM3PR07MB385; BCL:0; PCL:0; RULEID:; SRVR:AM3PR07MB385; X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB385; 4:4Xv5BTJl8jWiUAEmo7EKoL9Vt9nnmXDsnfrKBOt+1a/tU3SDeXaZ4S73vQ51H3qFvvBUukC1YiMdlRxcWl5Zy9hwN6TeWBkxIROIXP8IVq8BkMDoZGX9CFeKa+rfWNRt6KvKo12ws8VHEBT5L5IGRVhd0LKF4yZM78Wp7gmgJ2S+kXJytVprFC5QbQR4md/W1+f3a4BWg0pmv+/HkTr2+zHGYvLr0oYG7LbEZjWJl+Nnz5sncv3pTB9pzQ+U5xQ945XAYC0+ZgyZ6XEQMeuFH60JwMa7Oo+Y5NP3VDKAe+OXr3iIC4RqVfceepWPbMe9wveDQvMhS78uBmdjHER5MHwdTJ/3JwJ4shaCztjsvEoylPaTAWvfBfCx8NIpzmmtoGbLsprDbGYLwZyhBisid955LnZNVTI+IS/BH3KZtQSAXins654vwCUl8/egBpeT X-Forefront-PRVS: 0098BA6C6C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(377454003)(189002)(377424004)(199003)(24454002)(54534003)(1411001)(97736004)(4001150100001)(36756003)(4001350100001)(305945005)(7736002)(93886004)(101416001)(54356999)(33646002)(64126003)(110136003)(76176999)(65826007)(23676002)(106356001)(230700001)(19580395003)(19580405001)(5660300001)(31686004)(42186005)(65956001)(66066001)(47776003)(81156014)(2950100002)(65806001)(2906002)(6916009)(6666003)(4326007)(92566002)(586003)(105586002)(3846002)(6116002)(81166006)(50986999)(7846002)(189998001)(83506001)(31696002)(68736007)(86362001)(575784001)(8676002)(50466002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR07MB385; H:[142.133.110.144]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTNQUjA3TUIzODU7MjM6OHZUVzV4VlVYT2dEZWdtbDZtRmpteEZtY0k0?= =?utf-8?B?d01oRzNKNCtZeXFDU255M1p0VkRpVzd0eHp3QW9MMHdhR2RwaUo0STZSc3RU?= =?utf-8?B?RWRIblo1RmVnQXBoVmVhUkVBMXpzNUR0a2MyUEJYOWJ5VVBGZFNZVXR0SGFY?= =?utf-8?B?UjYrdUFORXMzSGlDTVdjNUR6K3FTbkNhSytLTng0VUZRZXcyY2x1cTBxN212?= =?utf-8?B?dkJmSnM4U0tYWTlrYlpoRnNZRmlBQzlKRTkyVE5JdUJPM1ZMd2tOYis3MUps?= =?utf-8?B?czlNMjNqRVBOL0FYV0RnUkJ3Zk4zV0tpYis2VGtLVEZCZGZTdlg5SGp3aWo4?= =?utf-8?B?VWI5WjFBVjJCblFBTFhUandzRjJlWGJuM3JDdk5HZ2VrU3k2cUZZWjJPQjdo?= =?utf-8?B?NEcyK0ZiaEk2NXpVWTFxWHFSSzhnY0tUOW9Wd040OE8zSXN3TGY5WGdDcnc3?= =?utf-8?B?STQrYUxUcnJoODdna3F0Wk5Mc1p2QzdMT1JmckVyKzBvWTJqN01UQVZsbGpE?= =?utf-8?B?ZTdKQWdZWEdkaDB5YjRTQTVSS29zMFV0cmhkTDduVkxOSzFkdWs5RTZyYVRV?= =?utf-8?B?K1JOMXFXdVRNdHlxOEJYQWtTT0V2VlhxQ1RSaU1TWGw3YzdnQU9IVnVpdDdq?= =?utf-8?B?S0g0VndTdjB1SjdZWGFIcEV4Q0hCVC81Vmw2TWxnaWlic3dLTlhsbTJZWWpi?= =?utf-8?B?UXNaUXVNbDRuYVR1R2NOajFEZGU0WlRselI0TG8xKzEvWmlOV0g2M0hPeDEx?= =?utf-8?B?RGVKM21DYzJVRWR1Rjd0aHJYK2dDa1pkQnBwY2d0UzZSZE5ta3pkRmFaY0ww?= =?utf-8?B?UldrcG5GMFkzVTVkd1EyWGN0eHE4QlN6dkxENWR3UWJlaDhhcTB6YVlGNWVZ?= =?utf-8?B?d2JPaFo2eTdCQ3F6ZFBmTlZJZHlORHNlb0xOOG1nVTBmbCtnRmhCWCt2Z2pR?= =?utf-8?B?d1VBb28zcThsMWg4Q25HYTF4dDIxSXJpSW53K3d2bEJDNUV0dG9WQXAzYWtm?= =?utf-8?B?bFpRVjRacW9VQ0RVMlhHRXRjTlNrREpIS2ZJREhSbHd0WlBTbDhhc1FKZWhJ?= =?utf-8?B?VkhZdWpmcVp3b2VqRHplNWpDQVpvUWRUaXhZMERHWWRRdWxjdTV4TGd6Y3F1?= =?utf-8?B?WWY4SllBbzlxbHFiYisxMTY1LzF5b1cwaHJ0RWswYWROUVkwVVlhbFIreTZl?= =?utf-8?B?bmJxVkI5Sng2cmVVa09rSUtWWXpleHJEVnoxak4xTW8vdWdJanBCeXhwSy9V?= =?utf-8?B?WFl2OW4vOGphd3RXTzU5cU9salArbllWZGMvRE9tbWpvOHBXZitxMHlJZTNj?= =?utf-8?B?VFBvS3ZZQXpOVXJjNWJBZlN6cW91M2QxVVVBRnVjY3l3aS9ReGdad1hHYWpZ?= =?utf-8?B?UHFucy81WlJQWXBZTUZUNUxWb1NuZ2VDbnBQTWZBK21OSDdtZjl4TGU5ZkNY?= =?utf-8?B?T3Z5UGQ3QVpRZlFjWHUyZFFUZ3c2dVN6QmUxUlF5bXEvSEh3c1lPZmNVMFZO?= =?utf-8?B?Szg1c1BzaTcrc1dJVm1JTW9iMi9EUmRnaU1IUmNCam9CcUlKQ3BCSVRMNVB0?= =?utf-8?B?bkZGTHA1Y0xHL1Y3RFJRNGpCQnN5QnZtN01aYWRuN1RFcGRqZnd0Nm9NZExo?= =?utf-8?B?aEhRYXkzYUJjenRYUERTSE1iZGk3UFRkTEpGYm5nRnRWSjhHRGZPM3U4MndP?= =?utf-8?B?YXhUVjdDUnhPUFUwUWUwV2tjdEpxR3ptRWJyT0RXOERodkJ4eVVZTzRQc3l2?= =?utf-8?B?ME1saWU2RGx0eHpOVCs0amdtWWlPbHdhZFRvdjd2dGZVclg2SElTenArcVBt?= =?utf-8?B?NzMwQVpyWEprU0RMTTB3TUtWRytJWHYvcVIyQWFsYm53eVJiZDZJd2M1Z2tk?= =?utf-8?B?ZGpER1o1SHZmU3FOMnBlZkxFS1R6RmVHSElUM01qa1V1Qi9TRFQ5OE5aN2to?= =?utf-8?Q?ubWhFhwbd+d/ymDbJU/VRIXhU0NAA=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB385; 6:z9/W/uScCUE5XL3pQhoY0dRHEKeC8hEkGFsPLB5nCRfNBuwniUaQDsrJiWm/mSDu4t4EQcThL5U9ComPJQJ649zDcKxZduOK4pQ31MvMZUabpGE7feLIwWDc8R9Zfmf1c+S4EATK/hwgQqLMOC5lPD/8jRxSdAvp3TpdGYznYb1kK5fwR8fS8LHU87MSxIAZ2W12ZoMUlgomENBsHqpgPQvNI/iavDbGCfTappwe5PBnbGPjGW9fel0gQkJbGBKHQu39bNapiRSdoL5e6dA1lsgSqsaHPc/VUudH3x73biwrPKwCQ6ghDIALf9vFVK0w; 5:I03rONQ/NgESTgpPi92tyOi4lmm7KqWA3p/aekNbfvEQFB/ouls+DV09CaIo7tI5j6L6MzCUwE7kO90KmXy2z4HgcxRzUxCuYrsylBS0B6HqYnPK9yGDLbE90Vt8gjowaaiUR2T+N1huqmT9ViJfIA==; 24:uqSm/vuM6F2ogYOTtCOf523XFbgDuqcKh7hS4h+/paI8JhNqgk9jVESNpxYRGXnKOJdRnJJx5QQHL6O3rCux8hpyv/Z3ueoZDyudbd10rEM=; 7:Z6/m8/gXKtGsyKE6Qaviav8f6TzD066zqlBtJIJx3MAo7TTaV9KIc2rSWWXT0kBKlDdUFym5ipLNCgOgpcZ7BUUkgg/7LZmf7I7+L1v9n+syDpUpO5Z8fkj98eN+1/Izy/9YYzSqi2vAWLKDyfKhr5vmxIVtTpFYpxh8+vXw7SFwXJnJj3iiI8llrxiGQ2uf8il7Sglwpf9hW8RF0cmbPwV3egcyGu7SNw707wS5DLfuFJyoFwdpitaThxfotBoi8yP76t/TracBhv0T08ccXCBcAN2r4eLCYTOH4wCaHQMTM47gkafSuNr8o3f7MDc1ZzBwULGCHHkTMOZPXK/fSHv9ehS6EiLYu9ccoG8CfvY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2016 20:55:46.7295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR07MB385 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes On 16-10-17 04:49 PM, Simon Marchi wrote: > Pushed. Here is the final version: ... Oops, I had forgotten to update a comment. I pushed this quick fix: From 3ccdb4324b0dc9fa46ee7cad9b370f8c7c370c3b Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 17 Oct 2016 16:54:24 -0400 Subject: [PATCH] Fix comment in mi-trace-save.exp This fixes a comment I forgot to update in the previous patch. gdb/testsuite/ChangeLog: * gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args): Update comment. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.trace/mi-trace-save.exp | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index f0c8415..9d35283 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2016-10-17 Simon Marchi + * gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args): + Update comment. + +2016-10-17 Simon Marchi + * gdb.trace/mi-trace-save.exp: New file. 2016-10-13 Yao Qi diff --git a/gdb/testsuite/gdb.trace/mi-trace-save.exp b/gdb/testsuite/gdb.trace/mi-trace-save.exp index 96bb70d..edb3a59 100644 --- a/gdb/testsuite/gdb.trace/mi-trace-save.exp +++ b/gdb/testsuite/gdb.trace/mi-trace-save.exp @@ -21,7 +21,7 @@ load_lib mi-support.exp mi_gdb_start -# Test without the required "filename" argument. +# Test with the wrong number of arguments. proc test_trace_save_wrong_num_args { } { set err_re [string_to_regexp "^error,msg=\"Exactly one argument required (file in which to save trace data)\""]