From patchwork Thu Feb 12 15:49:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Taylor X-Patchwork-Id: 5053 Received: (qmail 18562 invoked by alias); 12 Feb 2015 15:49:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 18543 invoked by uid 89); 12 Feb 2015 15:49:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mailuogwhop.emc.com Received: from mailuogwhop.emc.com (HELO mailuogwhop.emc.com) (168.159.213.141) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 12 Feb 2015 15:49:23 +0000 Received: from maildlpprd04.lss.emc.com (maildlpprd04.lss.emc.com [10.253.24.36]) by mailuogwprd04.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id t1CFnKX2021610 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 12 Feb 2015 10:49:20 -0500 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd04.lss.emc.com t1CFnKX2021610 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd04.lss.emc.com t1CFnKX2021610 Received: from mailhub.lss.emc.com (mailhubhoprd01.lss.emc.com [10.254.221.251]) by maildlpprd04.lss.emc.com (RSA Interceptor) for ; Thu, 12 Feb 2015 10:49:04 -0500 Received: from usendtaylorx2l.lss.emc.com (usendtaylorx2l.lss.emc.com [10.243.10.188]) by mailhub.lss.emc.com (Switch-3.4.3/Switch-3.4.3) with ESMTP id t1CFn7QC006985 for ; Thu, 12 Feb 2015 10:49:07 -0500 Received: by usendtaylorx2l.lss.emc.com (Postfix, from userid 26043) id 0D7A75DE513; Thu, 12 Feb 2015 10:49:05 -0500 (EST) Received: from usendtaylorx2l (localhost [127.0.0.1]) by usendtaylorx2l.lss.emc.com (Postfix) with ESMTP id 74F225DE511 for ; Thu, 12 Feb 2015 10:49:05 -0500 (EST) From: David Taylor To: gdb-patches@sourceware.org Subject: [PATCH] doc of pre-defined or builtin trace state variables Date: Thu, 12 Feb 2015 10:49:05 -0500 Message-ID: <2301.1423756145@usendtaylorx2l> X-EMM-MHVC: 1 X-RSA-Classifications: public X-Sentrion-Hostname: mailuogwprd04.lss.emc.com X-IsSubscribed: yes Our tracepoint users want certain capabilities for which 'pre-defined' or 'builtin' trace state variables seem like they would be a good fit. So, I started looking into what it would take to modify both GDB and our GDB stub to support them. Imagine my surprise to discover that GDB already supports them, but it is not documented! Here's a patch. The pdf, html, and info targets build without complaint. The modified paragraph in the pdf file looks okay. gdb/doc/ChangeLog: 2015-02-12 David Taylor * gdb.texinfo (Tracepoint Packets): Document the builtin and name fields of the QTDV packet. diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index b8e1f7f..62726ff 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,8 @@ +2015-02-12 David Taylor + + * gdb.texinfo (Tracepoint Packets): Document the builtin and name + fields of the QTDV packet. + 2015-02-09 Markus Metzger * gdb.texinfo (Branch Trace Configuration Format): Add size. diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index d1f22de..c4f03b2 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -36812,7 +36812,7 @@ the ones in effect during the trace run; even a small discrepancy could cause @samp{tdump} not to work, or a particular trace frame not be found. -@item QTDV:@var{n}:@var{value} +@item QTDV:@var{n}:@var{value}:@var{builtin}:@var{name} @cindex define trace state variable, remote request @cindex @samp{QTDV} packet Create a new trace state variable, number @var{n}, with an initial @@ -36820,7 +36820,12 @@ value of @var{value}, which is a 64-bit signed integer. Both @var{n} and @var{value} are encoded as hexadecimal values. @value{GDBN} has the option of not using this packet for initial values of zero; the target should simply create the trace state variables as they are -mentioned in expressions. +mentioned in expressions. The value @var{builtin} should be 1 (one) +if the trace state variable is builtin and 0 (zero) if it is not builtin. +@value{GDBN} only sets @var{builtin} to 1 if a previous @samp{qTfV} or +@samp{qTsV} packet had it set. The contents of @var{name} is the +hex-encoded name (without the leading @samp{$}) of the trace state +variable. @item QTFrame:@var{n} @cindex @samp{QTFrame} packet