From patchwork Fri Oct 6 02:37:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: asmwarrior X-Patchwork-Id: 23367 Received: (qmail 113990 invoked by alias); 6 Oct 2017 02:37:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 113909 invoked by uid 89); 6 Oct 2017 02:37:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=zhang, Zhang, kindly, his X-HELO: mail-pg0-f67.google.com Received: from mail-pg0-f67.google.com (HELO mail-pg0-f67.google.com) (74.125.83.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Oct 2017 02:37:20 +0000 Received: by mail-pg0-f67.google.com with SMTP id i195so8643820pgd.3 for ; Thu, 05 Oct 2017 19:37:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=H8hZWFXYV5WfqHuiMw3fIg+b+4RVQTptcfZXmEIk/Kk=; b=nwXRY9LQktKTIER4qkvZO7jJ4jdntZnNrrpEG2M0TwEbUyPmov6vHjwY8gkueNX1iC Xik5y9byg+LvzdchZtq2W8q15n5/jkHhV1WNgPV4UQuMylyy8LW3AkECIMsQlX+Pq/dL hhgsYvXEi8gKMgGvYwA8y31A6UsDD1VECsO6GDJYbnAzWcSSoUXm77pg4/EZxHts+DhK /6Qjpm3iaxMLoDt9uQFK61z6Ukfl5Ud4ScJeZ8Syu3OTrU61E+VIgRxXK//+4KgLs389 k8FZxdFy3wScBMIaSIzfiRTAzXWugtGkmQmAgzcyiPVkADa1pOs8/eA+TyhP3KvQ/0ob CMqg== X-Gm-Message-State: AMCzsaWsayf21sWyc+miReBDksTvfKHEN9ZkDsmU7IfBJuT3DV/oRlBR gOtn207PfP7npV6Jyin3A7fQEg== X-Google-Smtp-Source: AOwi7QAzHrfe2wmH2nXU8iwIfTOAySCiNttYdoTk2VZC6z4u0yeUGiV70FvNfA8d+1WzaITGmTzQIA== X-Received: by 10.98.217.2 with SMTP id s2mr668116pfg.298.1507257438483; Thu, 05 Oct 2017 19:37:18 -0700 (PDT) Received: from [0.0.0.0] ([47.88.216.52]) by smtp.googlemail.com with ESMTPSA id s81sm463919pfg.162.2017.10.05.19.37.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Oct 2017 19:37:17 -0700 (PDT) Subject: Re: [PATCH v5 2/3] Implement "set cwd" command on GDB To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org References: <20170912042325.14927-1-sergiodj@redhat.com> <20170929225852.21872-1-sergiodj@redhat.com> <20170929225852.21872-3-sergiodj@redhat.com> <874lrg5goz.fsf@redhat.com> <6520ea6a-6be7-db93-1d3e-1b156bc95564@redhat.com> <87mv5841qt.fsf@redhat.com> <87y3osxj6i.fsf@redhat.com> <871smkxaco.fsf@redhat.com> <22dfe787-0c70-b2c1-c1b0-752d2e712f42@redhat.com> <83lgkrzd23.fsf@gnu.org> <87k20bwiis.fsf@redhat.com> From: asmwarrior Message-ID: <21e02d72-ed9c-5e63-5981-00ec92908257@gmail.com> Date: Fri, 6 Oct 2017 10:37:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:56.0) Gecko/20100101 Thunderbird/56.0a1 MIME-Version: 1.0 In-Reply-To: <87k20bwiis.fsf@redhat.com> On 10/4/2017 2:10 PM, Sergio Durigan Junior wrote: > On Wednesday, October 04 2017, Eli Zaretskii wrote: > >>> Cc: GDB Patches , Eli Zaretskii >>> From: Pedro Alves >>> Date: Tue, 3 Oct 2017 22:29:27 +0100 >>> >>>> Well, Pedro kindly pinged me on IRC to let me know that I had totally >>>> misinterpreted his request to move a paragraph from the "set cwd" >>>> section on gdb.texinfo to the "cd command" section. Anyway, here's the >>>> updated patch. >>> >>> Thanks, this version looks good to me, but please give Eli a chance >>> to take a look too. >> >> LGTM, thanks. > > Thanks, pushed. > > bc3b087de2401c65c02730d346e8bea4dc0504ae > I see a build error when building GDB under msys+mingw gcc 32bit. g++ -x c++ -std=gnu++11 -g -O2 -I. -I../../../binutils-gdb/gdb/gdbserver -I../../../binutils-gdb/gdb/gdbserver/../common -I../../../binutils-gdb/gdb/gdbserver/../regformats -I../../../binutils-gdb/gdb/gdbserver/.. -I../../../binutils-gdb/gdb/gdbserver/../../include -I../../../binutils-gdb/gdb/gdbserver/../gnulib/import -Ibuild-gnulib-gdbserver/import -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wno-format -Werror -DGDBSERVER -c -o win32-low.o -MT win32-low.o -MMD -MP -MF .deps/win32-low.Tpo ../../../binutils-gdb/gdb/gdbserver/win32-low.c ../../../binutils-gdb/gdb/gdbserver/win32-low.c: In function 'BOOL create_process(const char*, char*, DWORD, PROCESS_INFORMATION*)': ../../../binutils-gdb/gdb/gdbserver/win32-low.c:566:48: error: 'get_inferior_cwd' was not declared in this scope const char *inferior_cwd = get_inferior_cwd (); ^ make[4]: *** [win32-low.o] Error 1 It can be simply fixed by adding the header file: gdb/gdbserver/win32-low.c | 1 + 1 file changed, 1 insertion(+) Thanks Yuanhui Zhang diff --git a/gdb/gdbserver/win32-low.c b/gdb/gdbserver/win32-low.c index c11926f7c6..f9c890f164 100644 --- a/gdb/gdbserver/win32-low.c +++ b/gdb/gdbserver/win32-low.c @@ -33,6 +33,7 @@ #include #include #include "gdb_tilde_expand.h" +#include "common-inferior.h" #ifndef USE_WIN32API #include