From patchwork Wed Apr 24 03:02:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 88940 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3E862384A06B for ; Wed, 24 Apr 2024 03:02:52 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 9DB68385840D for ; Wed, 24 Apr 2024 03:02:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9DB68385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9DB68385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713927749; cv=none; b=p4Xs4fmDkton3WqnRGE1gOYeuEt54yUCuoALCnxpWKfcPvnvXCjiERDfgnD0xouosvxSic+z56PweanaigVXiXDaBAln6a4Paqnlqa6LOssm+H3GcYHE7QCvXeZKrhz2N8y8lqvQxHI0iMhH5bCpSimeqatPGEbDp9K+DlI4yk4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713927749; c=relaxed/simple; bh=Vkq5i7/VFm9zqhkAv9auDGnVxhQJw2vvRRRmAzl22kc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=EBq/BKVDFVoOC7Nbi+eD4gjeQ82wfR3Z0AxmAmJJ/Sj36B0MUq9MNH++Jg/fV7E8jKG9IbE/TspLSqndEoyueNIr63W0VzynF++boebVKoz/FnPc1vy9L+dbx+x3KwgelY9gcvMczmpEnwIClTQiXqQ4P5/SEKuQfy6OA/VXv88= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 43O32FkG057045 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 23:02:19 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 43O32FkG057045 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1713927740; bh=sRVeo3KNuQQJc/vqhkVEFOhoNzpp4ye5tcN7GdaU0dg=; h=From:To:Cc:Subject:Date:From; b=on/Yke9ABcQpGeSiP2NkFl4z8S5N8O/AzkOdrK6OiE6iRNkG6/XRo+SceJdJ7fv6k CL5qDARVb4ZpCzRIkh+wly8GK5JWXj97CRTT/zlmDl4in3XD5yfF/gPmTLyvNwRRg3 u0uiQ7Lo160HGmHkr92F6G8VQexswpxeqgH/ZWXs= Received: from simark.localdomain (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A9B661E030; Tue, 23 Apr 2024 23:02:14 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed] gdb: include extract-store-integer.h in charset.c when PHONY_ICONV Date: Tue, 23 Apr 2024 23:02:12 -0400 Message-ID: <20240424030214.2840605-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 24 Apr 2024 03:02:15 +0000 X-Spam-Status: No, score=-3188.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org From: Simon Marchi When building on a system where "phony iconv" is used (NetBSD in this case, not sure why), I get: CXX charset.o /home/smarchi/src/binutils-gdb/gdb/charset.c: In function 'size_t phony_iconv(int, const char**, size_t*, char**, size_t*)': /home/smarchi/src/binutils-gdb/gdb/charset.c:140:8: error: 'extract_unsigned_integer' was not declared in this scope = extract_unsigned_integer ((const gdb_byte *)*inbuf, 4, endian); ^~~~~~~~~~~~~~~~~~~~~~~~ /home/smarchi/src/binutils-gdb/gdb/charset.c:140:8: note: suggested alternative: 'btrace_insn_number' = extract_unsigned_integer ((const gdb_byte *)*inbuf, 4, endian); ^~~~~~~~~~~~~~~~~~~~~~~~ btrace_insn_number Add the necessary include. Change-Id: I10b967584645961c86167a8395d88929a42bef03 --- gdb/charset.c | 2 ++ 1 file changed, 2 insertions(+) base-commit: bfe6fb329a1921624a93d768d2bafafeb2c31aec diff --git a/gdb/charset.c b/gdb/charset.c index 4c1debef6143..17a9ca81b2eb 100644 --- a/gdb/charset.c +++ b/gdb/charset.c @@ -71,6 +71,8 @@ #ifdef PHONY_ICONV +#include "extract-store-integer.h" + /* Provide a phony iconv that does as little as possible. Also, arrange for there to be a single available character set. */