From patchwork Fri Apr 19 15:13:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 88745 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A8841384640E for ; Fri, 19 Apr 2024 15:15:29 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by sourceware.org (Postfix) with ESMTPS id E50673849ACF for ; Fri, 19 Apr 2024 15:14:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E50673849ACF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E50673849ACF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713539652; cv=none; b=ENKuAhlwpzUREUNVzqvgttnthDF/ouG37K1Midstt5ZBkuYhDOIBVglJLfqsqOvXoqQhVCdv2FjZOoAYLH/Ow5jWTxPE0GrDiwwjllkEf4J9UmtOSku2W/ioOl1oKs3LdfNpkRt+eECHQQOOgUpILW84GtTfovkgBD5xiUiwUlc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713539652; c=relaxed/simple; bh=rb3T+8lA4Lo03H7fHJlSz4/7FEUA6zZHwD1fIfYQcoM=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=cp6WDgc7OPZoiPVCGNBm6wN60K+qYy8QCZb8m0dVoFb2b9V9bAQDZSpnydJNSL8FN7epH7Vq5t7INUgDtwVybDG3iCeYAEmlwg4NTxz3RECdmTXnPXUGsU3lyJEmApp6VnNVX55CN+Z8F30j5NiUZDZMZPHLbHvX0Gm4jdZDhls= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-343c7fae6e4so1889029f8f.1 for ; Fri, 19 Apr 2024 08:14:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713539649; x=1714144449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0ijeoMI+Au2qgpmyNkpFAwByGxfLk9QFs7kLUn1eLVg=; b=tWirvHIJ6O9feuYypbuv1bZTaL93PC/8vUbgDi4kGjuyN/u+EVqcGt2WJh43sDyueX AfidW3rqlW4HjqEf1PVTj7PiZrHKuso3ApliQjUNxY9JdfyiBHnjydjcUUGx/q65tMnq HyHSXOAUtC5iPmOInyrSeDIYUE5PSAJOkkmasOt0wApgppv04ap2SScO6xB18EFbYZsd tG8ZfDEk5lnk/GaGj9vpYrr3dPTJl/grj6Zu3oRyjqKD1zxwo5UVgiA9MMrk24GwG618 mu+RHwsUZE5B3GlajgkadMadgO9KySBEeenAC0sAZHKpa8yTp545dxFiEwZnBt7q3nZU VuBg== X-Gm-Message-State: AOJu0Yyp+GZk67jX0z7CJHwPMubsE1p20A1iJ6j015VJaLKMxAraUJnx ey86ofHiDB3O/nEKWI3/edLVVuS31FccraonV8r5BzpdesaXMsmK7umcWkCw X-Google-Smtp-Source: AGHT+IGWzfLnyYXCvTUB6HZcTDZWXtiUASy6lOYS/WoLJ2Rrs0D0wOcNSMaAmaWcm3asEtZwvCXnkw== X-Received: by 2002:a5d:4586:0:b0:34a:587:9344 with SMTP id p6-20020a5d4586000000b0034a05879344mr1392018wrq.25.1713539649423; Fri, 19 Apr 2024 08:14:09 -0700 (PDT) Received: from localhost ([2001:8a0:f93d:b900:2438:d637:5572:c30a]) by smtp.gmail.com with UTF8SMTPSA id p8-20020a05600c358800b00418f72d9027sm4649114wmq.18.2024.04.19.08.14.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Apr 2024 08:14:08 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 08/12] gdbserver: Fix vAttach response when attaching is not supported Date: Fri, 19 Apr 2024 16:13:38 +0100 Message-ID: <20240419151342.1592474-9-pedro@palves.net> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240419151342.1592474-1-pedro@palves.net> References: <20240419151342.1592474-1-pedro@palves.net> MIME-Version: 1.0 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org handle_v_attach calls attach_inferior, which says: "return -1 if attaching is unsupported, 0 if it succeeded, and call error() otherwise." So if attach_inferior return != 0, we have the unsupported case, meaning we should return the empty packet instead of an error. In practice, this shouldn't trigger, as vAttach support is supposed to be reported via qSupported. But it doesn't hurt to be pedantic here. Change-Id: I99cce6fa678f2370571e6bca0657451300956127 --- gdbserver/server.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdbserver/server.cc b/gdbserver/server.cc index 2633df08ddb..789af36d9a4 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -3318,7 +3318,10 @@ handle_v_attach (char *own_buf) prepare_resume_reply (own_buf, cs.last_ptid, cs.last_status); } else - write_enn (own_buf); + { + /* Not supported. */ + own_buf[0] = 0; + } } catch (const gdb_exception_error &exception) {