From patchwork Wed Apr 17 16:55:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Hawkins X-Patchwork-Id: 88589 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B1F193858C62 for ; Wed, 17 Apr 2024 16:56:19 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by sourceware.org (Postfix) with ESMTPS id 060DD3858D20 for ; Wed, 17 Apr 2024 16:55:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 060DD3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=obs.cr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=obs.cr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 060DD3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::836 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713372960; cv=none; b=WgCaQWqfXaOO9oTGN6S8nTWXZJJXMBFpoYHzUUHQbgCJ9yYLQ79yfc9+xzj/z1+S4bpJht5SLDNUAaH+Fak+lJDsoC6TnTiMTepW8mGSqw/Pro1tp+S1kJgqft8xK/NOq/2U/bmdG+bXCIUAMTZpGf+hFdtJYjONpdxmQRMwf9U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713372960; c=relaxed/simple; bh=q4NRuYYLVi0CLH5kTeHho+d2peRhLRpL0JekBKJWV8c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=MpRQR36lq2XSE25FTiEXO3zfYxd3k2+hSneOOx0WmfSEkIZ424fh042slTKT4v5LZ0OdoC51nNFUKTQEEw9e0EvUdQEydH+Hxj+edNS/BEN3m8BECHKKJcUjOSjYK7LpQlzrwB+gUKLuF2P66SDgzFcbYb4BZ5pAzRmmnhLEa50= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-437202687bfso17980971cf.2 for ; Wed, 17 Apr 2024 09:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obs-cr.20230601.gappssmtp.com; s=20230601; t=1713372958; x=1713977758; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=N6prcpbRTBRZ3bujAdxjglgo+0kWQXQGjxKsDEy0zSg=; b=sXY9eGbE5gMeJRLwIKVh5PA9MgXSRPU12E9/1EwlRRu1W4SHzYngoIvHf3dm9doUGp cDjTrWkFMRRwKno/X36Z+/zQDQ6GWxH868k1H0xcpMDkhcap5xrQvrZLZwQjsMP4EfPg 0qM/SOaL+bDCaMzdmBiTq/jkM7fMY4mFwrJXbwFK7MpyIojXZDqMag54u56s+2lLUJ8/ /2fsbBRnO2H2kNTdXM7CatUfe8TjqofV/m/T32R1BiAtN6bfw+E/v26GAjlwdACEFngM v4Asf2lrUjUSEZMLlu6O5qOn9M30fMMCgn4y5RyBciHG95reiEuMMzzt0LpQRyDF7sTv Ie/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713372958; x=1713977758; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N6prcpbRTBRZ3bujAdxjglgo+0kWQXQGjxKsDEy0zSg=; b=wbIvZN8t3GIVJOtp9qOXJyUiZl55ytAGCEZ94dY+s2/e6cTR1XnTUncBLbHm+U6Y2P ahm+siUDb4nhQU3DOw/FeUU9bffqJYgcPQ48zng2T7WHjtpzQhokGx3+YsI0yZ2877ca M6pFKr8BhYHJWlRvdq6PV9yHlf6s379xdQjSrlqlM2qC4z6f5zH+rtyvPFrk/WOdBdZZ vPvLfOIyy9eGHABhzmwi355djhwInDXmYrwYC67qY/65yJ/kTm+seKxESCszmIoAjYk7 q0SIGA7kVjpkXAzFcztjoBFsZEN51vAZioYyrggjrt2fYd0TCZeW+93zYImnPC9fEnAU AZUA== X-Gm-Message-State: AOJu0YzzQ6JOM4KmYwB1/BWuXNKuXirQ3ZPzi6DK+XRLzdmr8JeotPwg nmaCZ43cLfJ8Ga/GuRQVsnSzjWduafLcxHsbe2wkMEOVz9QD2/rQqvkxaTzdEfvlvFxo4/U0BC5 J X-Google-Smtp-Source: AGHT+IGSMsx15wVQMjou0JsqQt3t4c0XRKR+48sgCud99dWhg2wWEbFQacb1Xy9xG8xMXRcA0Fwg4g== X-Received: by 2002:ac8:578c:0:b0:437:7570:fb0c with SMTP id v12-20020ac8578c000000b004377570fb0cmr7032qta.30.1713372958174; Wed, 17 Apr 2024 09:55:58 -0700 (PDT) Received: from ininer.rhod.uc.edu ([129.137.96.15]) by smtp.gmail.com with ESMTPSA id y18-20020a05622a165200b0043722cf9813sm2726731qtj.27.2024.04.17.09.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 09:55:57 -0700 (PDT) From: Will Hawkins To: gdb-patches@sourceware.org Cc: Will Hawkins Subject: [PATCH v2] Add DW_TAG_compile_unit DIE to Dummy CUs Date: Wed, 17 Apr 2024 12:55:54 -0400 Message-ID: <20240417165555.531273-1-hawkinsw@obs.cr> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Dummy CUs help detect errors and are very helpful. However, the DWARF spec seems to indicate the CUs need a DW_TAG_compile_unit in addition to the header. This patch adds that. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31650 Signed-off-by: Will Hawkins --- Notes: v1 -> v2 - Add proper trailer to commit message noting the Bugzilla. gdb/testsuite/lib/dwarf.exp | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp index c694375b534..1a97f83f8e6 100644 --- a/gdb/testsuite/lib/dwarf.exp +++ b/gdb/testsuite/lib/dwarf.exp @@ -2999,6 +2999,7 @@ namespace eval Dwarf { proc dummy_cu {} { # Generate a CU with default options and empty body. cu {label dummy_cu} { + compile_unit {} } # Generate an .debug_aranges entry for the dummy CU.