From patchwork Wed Apr 17 13:44:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 88583 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 77E4D384AB72 for ; Wed, 17 Apr 2024 13:44:46 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by sourceware.org (Postfix) with ESMTPS id 07EE83858D20 for ; Wed, 17 Apr 2024 13:44:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07EE83858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 07EE83858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713361462; cv=none; b=esv+AhGrdlqVy9TG2LAjjlmymv7FZXINkib75XI5FEiy9YHn2eGw1nFyDad6gCAYRbZfLOk9yjBTmVnekzXRX1NBArRgnr5SXTKXd+X5W3kggYyx23QpsVlWP+PI1lJK20Q4bK+l5UNH2WyHDE0gpIbM4izBm0d0j78dbxh2iYs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713361462; c=relaxed/simple; bh=uxHNOkrRZWq1ZFbxzlnjLpmr2Wn3JtypW5Mw0V14+dI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PTgWa1rE0vCMh+ddh+pkpMM6FF2B4Ao6qc/MbDzxIVDvyZMN7qnpHFwIYcDQBTDLK/0P68kRLZdHoSTRRxoCDbGR1QB2hYka26ZaaepXtWuniQCMMgUCRsftcww/V8fQIKCjsCPoJZ9bankGTTJPXQ6brNk0Qyu2Xx044X8Rn1Y= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-7d5e4097a9aso225517839f.3 for ; Wed, 17 Apr 2024 06:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713361457; x=1713966257; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lRkKav+YJcSEDqAxiXdDoKDSaKpSbrk22qZHVyS6Ris=; b=NOHpmlm9/LmLuWGLSAvsRncW2qeRzmOgubavC3YkQfQeG1dV8negroPBqJPYCGj7fs Ybw3Y8SXjkUarc3AHNbDCAiMqvSr17pSRm8uwxes8jK9tLvWutqA1btx41dFerMsjm/G zLXzcXAmp5VcmA+gFTNC9P1WJLttuyQgn8mAB6NWRakNL7BdlZH97ZUZ59hQeY+75EYm 9x1AXwl74m7X3jphwWdQH7k6j4LPydNnakaE+SjYtgArCz4ekHJOXSKcs889uKIyuhNL jylD34yGuN0GPE+yPem6Av8SYwQ1E+4dWIXtVBC6ZwtJ7YPST7LwRbjl0GAG9eDGqhDd swkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713361457; x=1713966257; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lRkKav+YJcSEDqAxiXdDoKDSaKpSbrk22qZHVyS6Ris=; b=a+tK88dDtA3O67VTifsjRvO5MI//Culpo2ijdOuWMlt15S9gfLa/2ElcoDTJSgko7f vVaaqjDEB9RGeadhJ5cqdaOXnbclYTusc5kXJWwGqfeFVB6E83UyvtPE0hNYpLRIBgl8 x3X+i+jWzTFkiC1m//eM5PyRdzG+rAKXL3Jz8q+HBDgB/bMJ7q58C+p3CHmpAn42GvPa usuqirPAcdI9WQvhEviNq+8m8ZsDnFqHkWat7TAQfcU6zyXb7FlZqwU2FMGV3AeG6v1S xw5K/FNprmDEtSAdXvqfRVzTPy9sQ0xsKq8xwa1gQLN0JL5gAtRtS5xTlZnE/Eb4Q3EJ +DRg== X-Gm-Message-State: AOJu0YyZ13wC4jygRRSyHBNjTEhIBUeOau6fRkYfGii2o1lHhhPp2S/9 L3TKbQYO85H62V5xwH1kuxDC4PoEoXd1+Bhg3OMuetdaeBBDz2qQjaqvL4cNd9sh8ytBogzwqEw = X-Google-Smtp-Source: AGHT+IELQbzt/CCoMbq74Dn70iu8orYn7w1LDIP/lXNJPNoO9pIBrBZorm4qlDW/0ul0XHGQGjZFGQ== X-Received: by 2002:a05:6602:3f02:b0:7d6:745f:5d74 with SMTP id em2-20020a0566023f0200b007d6745f5d74mr24732821iob.11.1713361457191; Wed, 17 Apr 2024 06:44:17 -0700 (PDT) Received: from localhost.localdomain (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id q6-20020a056638238600b004849340e49csm142094jat.178.2024.04.17.06.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 06:44:16 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: mark@klomp.org, Tom Tromey Subject: [PATCH] Use section name in DWARF error message Date: Wed, 17 Apr 2024 07:44:09 -0600 Message-ID: <20240417134409.4000591-1-tromey@adacore.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org A bug points out that a certain error message in read_str_index uses a hard-coded section name. This patch changes it to use dwarf2_section_info::get_name instead, like the other errors in the function. No test because it didn't seem worthwhile. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31639 --- gdb/dwarf2/read.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 061db8c2a2a..af69e1d9d9e 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -17469,8 +17469,9 @@ read_str_index (struct dwarf2_cu *cu, str_offset = bfd_get_64 (abfd, info_ptr); if (str_offset >= str_section->size) error (_("Offset from %s pointing outside of" - " .debug_str.dwo section in CU at offset %s [in module %s]"), - form_name, sect_offset_str (cu->header.sect_off), objf_name); + " %s section in CU at offset %s [in module %s]"), + form_name, str_section->get_name (), + sect_offset_str (cu->header.sect_off), objf_name); return (const char *) (str_section->buffer + str_offset); }