From patchwork Wed Apr 17 07:01:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 88571 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9C1ED3858D3C for ; Wed, 17 Apr 2024 07:02:30 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 240973858D33 for ; Wed, 17 Apr 2024 07:01:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 240973858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 240973858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713337326; cv=none; b=UUHIQFcMj1sv6TwZYWrNg5z/T8uSKiPvXSLuwcBW38Xhpo8Ca/mjeUnvf+L20hfsOQLTltwCYlXWdluYS3BfEf1ry3qZgguurBEvQFmNEnxK7eJHEBYWqzssE/pqxZaCxNdCTweP6cYP1JL+/qaw7j6/j51zWD8QQW25nLSt8lk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713337326; c=relaxed/simple; bh=VVDbBF4HJ0b10+UT3PNVMe70QgOkUkryV6FaXFvoOTw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LmJ6zTSvQ4c9ECegi0C+6PZ28ZwUMl/g3QFrHqEfY+h1x+4YMjixMNyM5DpEFIj68kqXI+2ZldIY1fnZYnhvsJh84YpHf1/uT7H2uzQ+B7gYZSzq3oBWsq2fnHm5q53rIQUf84TEBO2KXNdXG2aQvBTkvAvWMrZnmHSTDwgIXWQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTPS id wnbarEZRil9dRwzIpr4uaC; Wed, 17 Apr 2024 07:01:55 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id wzIprGlttYakKwzIprT8wd; Wed, 17 Apr 2024 07:01:55 +0000 X-Authority-Analysis: v=2.4 cv=a4T79lSF c=1 sm=1 tr=0 ts=661f73e3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=49YbivgxOhtPMClrE-gA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2r6LH2+OhHjqXY7lkDLj5DEwJk7LfJkEp6O80CG3O7Q=; b=qVKj9E1vjw/axYWUfpdsFca2NO F44+dbrs0eV6kyPpj/I8m6YTAxTIcSIpF3NT0zaF1TZ4vc8DQQWtjS7XSHFQm48PYTLIPZhMKlnPn CZgbetm588lAdtbFL0V3+xkqg; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:51536 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rwzIo-002vDX-2K; Wed, 17 Apr 2024 01:01:54 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove a copy from c-exp.y:parse_number Date: Wed, 17 Apr 2024 01:01:45 -0600 Message-ID: <20240417070145.1013104-1-tom@tromey.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rwzIo-002vDX-2K X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (localhost.localdomain) [97.122.82.115]:51536 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNQ9D+fAOl6mekvKTnEIgxoaUVFPQfq7WZpyhG4ptSwsfqL2qySLdD7XxD4Vp2ijTk+lbYkJUXY/eFmht5eTmgvq8zH9aMmBONwDGnR2cyxPGtr/fmcD ah7KXoTZDS64Z7v1KaBmvdhf/8ysLuKbKaCtIgZu/G3GBXsbGzd7JcleCViuwTqjCEgnlxfTwKuq4ll0zrkX+Wo0OminXmH2J3U= X-Spam-Status: No, score=-3021.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org parse_number copies its input string, but there is no need to do this. This patch removes the copy. Regression tested on x86-64 Fedora 38. Reviewed-by: Keith Seitz --- gdb/c-exp.y | 31 +++++++++++++------------------ 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/gdb/c-exp.y b/gdb/c-exp.y index 459a4cf1e8f..663c30f9517 100644 --- a/gdb/c-exp.y +++ b/gdb/c-exp.y @@ -1940,46 +1940,41 @@ parse_number (struct parser_state *par_state, /* We have found a "L" or "U" (or "i") suffix. */ int found_suffix = 0; - char *p; - - p = (char *) alloca (len); - memcpy (p, buf, len); - if (parsed_float) { - if (len >= 1 && p[len - 1] == 'i') + if (len >= 1 && buf[len - 1] == 'i') { imaginary_p = true; --len; } /* Handle suffixes for decimal floating-point: "df", "dd" or "dl". */ - if (len >= 2 && p[len - 2] == 'd' && p[len - 1] == 'f') + if (len >= 2 && buf[len - 2] == 'd' && buf[len - 1] == 'f') { putithere->typed_val_float.type = parse_type (par_state)->builtin_decfloat; len -= 2; } - else if (len >= 2 && p[len - 2] == 'd' && p[len - 1] == 'd') + else if (len >= 2 && buf[len - 2] == 'd' && buf[len - 1] == 'd') { putithere->typed_val_float.type = parse_type (par_state)->builtin_decdouble; len -= 2; } - else if (len >= 2 && p[len - 2] == 'd' && p[len - 1] == 'l') + else if (len >= 2 && buf[len - 2] == 'd' && buf[len - 1] == 'l') { putithere->typed_val_float.type = parse_type (par_state)->builtin_declong; len -= 2; } /* Handle suffixes: 'f' for float, 'l' for long double. */ - else if (len >= 1 && TOLOWER (p[len - 1]) == 'f') + else if (len >= 1 && TOLOWER (buf[len - 1]) == 'f') { putithere->typed_val_float.type = parse_type (par_state)->builtin_float; len -= 1; } - else if (len >= 1 && TOLOWER (p[len - 1]) == 'l') + else if (len >= 1 && TOLOWER (buf[len - 1]) == 'l') { putithere->typed_val_float.type = parse_type (par_state)->builtin_long_double; @@ -1992,7 +1987,7 @@ parse_number (struct parser_state *par_state, = parse_type (par_state)->builtin_double; } - if (!parse_float (p, len, + if (!parse_float (buf, len, putithere->typed_val_float.type, putithere->typed_val_float.val)) return ERROR; @@ -2005,14 +2000,14 @@ parse_number (struct parser_state *par_state, } /* Handle base-switching prefixes 0x, 0t, 0d, 0 */ - if (p[0] == '0' && len > 1) - switch (p[1]) + if (buf[0] == '0' && len > 1) + switch (buf[1]) { case 'x': case 'X': if (len >= 3) { - p += 2; + buf += 2; base = 16; len -= 2; } @@ -2022,7 +2017,7 @@ parse_number (struct parser_state *par_state, case 'B': if (len >= 3) { - p += 2; + buf += 2; base = 2; len -= 2; } @@ -2034,7 +2029,7 @@ parse_number (struct parser_state *par_state, case 'D': if (len >= 3) { - p += 2; + buf += 2; base = 10; len -= 2; } @@ -2047,7 +2042,7 @@ parse_number (struct parser_state *par_state, while (len-- > 0) { - c = *p++; + c = *buf++; if (c >= 'A' && c <= 'Z') c += 'a' - 'A'; if (c != 'l' && c != 'u' && c != 'i')