From patchwork Mon Apr 15 15:56:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 88503 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CA713384646C for ; Mon, 15 Apr 2024 15:57:35 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 081693858426 for ; Mon, 15 Apr 2024 15:56:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 081693858426 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 081693858426 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713196578; cv=none; b=vY6RMI2FklTZSvciZKnbjbr/aQ4FAhR98vbmjBCfP/5wwGsckWpEBV9R2XR9wk+ipaCGKPg7a5+MrYTkzvQzmVYBb2CCntxqLi9jU+Tulkwvw2C40+CU5d6ZJK6yvBkMmcVolp3UlPqfHpHA9GUHMJ8dFLLcQBm5cIBEnOZGm3I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713196578; c=relaxed/simple; bh=Q4leltYKt7zUraippRAsgg3uYvL1BWrIW/0QlTNI6gA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=XpAUfzKHML5WnA9AgxcrX75rDwS2BJ3qDim9xaV058wT42BWj0ydZmMRHIqLZMepkv9s4vqmr0FcmHyWa02eV9SgLOxy09E0eOPw0S4bqlz1lpzfivyX+PUPKORtEtgazgfDywA2Nu4lv9+PiNuvidgVpe7DC1+8+Ym0vl1H5rI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CBB7E372E7 for ; Mon, 15 Apr 2024 15:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713196574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UhRowhe4jsIESZnTNVERpxrwMsuCkce6AoSkLqT2DBo=; b=k+vEc3PyHGLqhADZXV+WMD+8J1IhlE6yTMxYllgyf3lKNA4Es7Ehxo8xJO6kuItZlSYIHQ oKbDVrgV+oeNsa1r1FgvJCW9VICVZ1Uyo74VbAKlCdukC/Us4j86pLClu93LRxyvXGBb0j wlZCFqhuDng2lx/T0jdg3SpRhC/aj0E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713196574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UhRowhe4jsIESZnTNVERpxrwMsuCkce6AoSkLqT2DBo=; b=6m6bS7jm/UKQneUhue0KJbONkRkRaD8GDYMJQmZKLFfXzBNBdpbgV+pYK1e53LJrjqpJs6 p/CxttziV6r1i7Dw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=k+vEc3Py; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6m6bS7jm DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713196574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UhRowhe4jsIESZnTNVERpxrwMsuCkce6AoSkLqT2DBo=; b=k+vEc3PyHGLqhADZXV+WMD+8J1IhlE6yTMxYllgyf3lKNA4Es7Ehxo8xJO6kuItZlSYIHQ oKbDVrgV+oeNsa1r1FgvJCW9VICVZ1Uyo74VbAKlCdukC/Us4j86pLClu93LRxyvXGBb0j wlZCFqhuDng2lx/T0jdg3SpRhC/aj0E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713196574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UhRowhe4jsIESZnTNVERpxrwMsuCkce6AoSkLqT2DBo=; b=6m6bS7jm/UKQneUhue0KJbONkRkRaD8GDYMJQmZKLFfXzBNBdpbgV+pYK1e53LJrjqpJs6 p/CxttziV6r1i7Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B6B1F13957 for ; Mon, 15 Apr 2024 15:56:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qM1jKx5OHWaVRgAAD6G6ig (envelope-from ) for ; Mon, 15 Apr 2024 15:56:14 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 5/7] [gdb/testsuite] Move gpu-parallel.lock to cache dir Date: Mon, 15 Apr 2024 17:56:25 +0200 Message-Id: <20240415155627.22108-5-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20240415155627.22108-1-tdevries@suse.de> References: <20240415155627.22108-1-tdevries@suse.de> MIME-Version: 1.0 X-Spam-Score: -3.17 X-Rspamd-Action: no action X-Rspamd-Queue-Id: CBB7E372E7 X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.17 / 50.00]; BAYES_HAM(-2.16)[95.97%]; MID_CONTAINS_FROM(1.00)[]; DWL_DNSWL_LOW(-1.00)[suse.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FUZZY_BLOCKED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns, suse.de:dkim] X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The lock directory returned by lock_dir is currently $objdir. It seems possible to leave a stale lock file that blocks progress in a following run. Fix this by using a directory that is guaranteed to be initially empty when using GDB_PARALLEL, like temp or cache. In gdb/testsuite/README I found: ... cache in particular is used to share data across invocations of runtest ... which seems appropriate, so let's use cache for this. Tested on aarch64-linux. --- gdb/testsuite/lib/gdb-utils.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/lib/gdb-utils.exp b/gdb/testsuite/lib/gdb-utils.exp index c0b96d3c2bf..1f30d807ff0 100644 --- a/gdb/testsuite/lib/gdb-utils.exp +++ b/gdb/testsuite/lib/gdb-utils.exp @@ -180,7 +180,7 @@ proc lock_file_release {info} { # Return directory where we keep lock files. proc lock_dir {} { - return $objdir + return [make_gdb_parallel_path cache] } # Run body under lock LOCK_FILE.