From patchwork Thu Apr 11 05:26:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Metzger, Markus T" X-Patchwork-Id: 88328 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2CEBA384AB6A for ; Thu, 11 Apr 2024 05:27:09 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by sourceware.org (Postfix) with ESMTPS id F0091384AB69 for ; Thu, 11 Apr 2024 05:26:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0091384AB69 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F0091384AB69 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712813178; cv=none; b=K35HkNExe80IWoXHZWcsjFWpG3IVR0pQ5ua4Qjl5vrnbkRvUk5RFTl/CIjJrJ1mwU4IbdVZ4+FgTKJwhWXZJ4zga+rf2bqwwCTKbJhr6SUVciJua+bhGjA015wZ/Oag/t5Mchvb03b+BnUYABsrUoITOyCsSSu4UcnlOm6aLpPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712813178; c=relaxed/simple; bh=tTekNDHsNDySJdkN2yMnYAoyyxXOUvYQtZNwWCIq/2c=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=JW6vIeP8konG4ey5WS1nAEzN9/vXNGjRTKDatJRKbshf3mWSWZdlZuqU4ph2TCgoTSwSz3HoD6sDdCAIcBktyuLCFVzeUTGYFUlGzCFCnOLklmtL0PonofqzOR2f9avBsQiqA/3+6e33MJKBOXSatJ9MOsN4ceUGpOfWh2bILpE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712813177; x=1744349177; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tTekNDHsNDySJdkN2yMnYAoyyxXOUvYQtZNwWCIq/2c=; b=e1by86FCSK/NoTKJ+8pDFaGhQZcA/ZRNRxgn9dqjovfsKx0fprqP1/jp p7NIMvkLcfk0BAgf1nJvwRpYfdrZ1Ykd88ZhNJDoBNy5h1zFkmcybqM2A 40UcVB9jyv2Kq7/PjKWGOiQTpnmcTniBfwUtI+2EJyRtN+ULeQ6CSPt1j OcsoQYYVTPtcA5JF7pWc+4Wn+93WkEMg1Kxlt0PylLD++xI+EcRBqshil gGze5I4Tjlnbv6IuMS2jSGHw4HLWM9PeBR32dfSgks43fxL51O9Kv8n8y ztjZjrNT0m8g/2ZJcuI7MKGm7gEdSLBvICDb6mpQJ3msgxR16nzspL5Rx g==; X-CSE-ConnectionGUID: ZzXXUmjcRnaqq+DXYE7x7A== X-CSE-MsgGUID: hUMerXEmRYKu3bG+sJER0g== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="8368004" X-IronPort-AV: E=Sophos;i="6.07,192,1708416000"; d="scan'208";a="8368004" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 22:26:16 -0700 X-CSE-ConnectionGUID: 0UJuZHNCSEa3m2HwHqrbLw== X-CSE-MsgGUID: kRciNfgFQO2yy8Nr36mOpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,192,1708416000"; d="scan'208";a="20764478" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 22:26:15 -0700 From: Markus Metzger To: gdb-patches@sourceware.org Cc: pedro@palves.net Subject: [PATCH v2 3/6] gdb, btrace: remove record_btrace_target::supports_*() Date: Thu, 11 Apr 2024 05:26:01 +0000 Message-Id: <20240411052604.87893-4-markus.t.metzger@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240411052604.87893-1-markus.t.metzger@intel.com> References: <20240411052604.87893-1-markus.t.metzger@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Let's not introduce support for breakpoint types the target beneath does not support, even though we could while replaying. Otherwise, users may set breakpoints during replay that then couldn't be inserted into the target when switching back to recording. --- gdb/record-btrace.c | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index 1d946f9d3f2..66f283b8680 100644 --- a/gdb/record-btrace.c +++ b/gdb/record-btrace.c @@ -130,10 +130,7 @@ class record_btrace_target final : public target_ops bool can_execute_reverse () override; bool stopped_by_sw_breakpoint () override; - bool supports_stopped_by_sw_breakpoint () override; - bool stopped_by_hw_breakpoint () override; - bool supports_stopped_by_hw_breakpoint () override; enum exec_direction_kind execution_direction () override; void prepare_to_generate_core () override; @@ -2706,18 +2703,6 @@ record_btrace_target::stopped_by_sw_breakpoint () return this->beneath ()->stopped_by_sw_breakpoint (); } -/* The supports_stopped_by_sw_breakpoint method of target - record-btrace. */ - -bool -record_btrace_target::supports_stopped_by_sw_breakpoint () -{ - if (record_is_replaying (minus_one_ptid)) - return true; - - return this->beneath ()->supports_stopped_by_sw_breakpoint (); -} - /* The stopped_by_sw_breakpoint method of target record-btrace. */ bool @@ -2733,18 +2718,6 @@ record_btrace_target::stopped_by_hw_breakpoint () return this->beneath ()->stopped_by_hw_breakpoint (); } -/* The supports_stopped_by_hw_breakpoint method of target - record-btrace. */ - -bool -record_btrace_target::supports_stopped_by_hw_breakpoint () -{ - if (record_is_replaying (minus_one_ptid)) - return true; - - return this->beneath ()->supports_stopped_by_hw_breakpoint (); -} - /* The update_thread_list method of target record-btrace. */ void