From patchwork Wed Apr 10 10:19:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 88289 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E09F3858D39 for ; Wed, 10 Apr 2024 10:20:08 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id B79F93858D20 for ; Wed, 10 Apr 2024 10:19:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B79F93858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B79F93858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712744387; cv=none; b=Wh+a98CeV23hOXUu9lsVd9D5xKe9ZxDQ+A/h+a34pQf/oUyjGbw9ke5gg2qsEkAbGWJqM15z3PC1MRE+iUedeOt3/UF9uVFSY0x/2v7BpxOD8d1e2T1EMFdg5RXHIw9nRGcb+apeCuxtQnum7W8QAP8fyYSLIJGxilIddbSQgbQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712744387; c=relaxed/simple; bh=MVFDlQhA4a1nF9r9UTOfFT9UcUDUTwW3TuCRnU9cVlA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=fe3ACtOuy/xtZn4c0yVtF6wMPPm//SfZgBWG/1BlgMjyjwcPx/uuLVdF3BJQvQ78ny3QY7epdOiP2dk5Hrr0uuTk77mSWOiEbe3FiyGQQcGJqeJfaF/nVAMdGxEtHgq/UOHiMzrf7cX1LNKX34pHZICF5a5NNnDUni05Pl4IQ4M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C7D6534E85 for ; Wed, 10 Apr 2024 10:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712744384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=OfZmSmKh099HIumNG3ZxssFyQ7fWVe4LYRQhSilPVG4=; b=NgLK0lQw1I6MwaPiextGDr7uXwwpp3+nse9v19ZSbMvCfFlANcoSZaLwPKyZTZ25PwAQZ6 1MX6mWzJzNDD3B0ekGE7f8o+ogmYpDERx1Dp83QsseJml5FPF1L9JOgtNm76ClSKgu3nNa bCQt8JP6V/I4BQqqt+MMzOMloRDCT40= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712744384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=OfZmSmKh099HIumNG3ZxssFyQ7fWVe4LYRQhSilPVG4=; b=HOkC309YKzHGxscpULrPyjPtKI48E8tZlAif48QOxuD5waVZfm0q1ci3nB+kSlV+swgwzJ U2MlhEDmqrHhQnBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NgLK0lQw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=HOkC309Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712744384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=OfZmSmKh099HIumNG3ZxssFyQ7fWVe4LYRQhSilPVG4=; b=NgLK0lQw1I6MwaPiextGDr7uXwwpp3+nse9v19ZSbMvCfFlANcoSZaLwPKyZTZ25PwAQZ6 1MX6mWzJzNDD3B0ekGE7f8o+ogmYpDERx1Dp83QsseJml5FPF1L9JOgtNm76ClSKgu3nNa bCQt8JP6V/I4BQqqt+MMzOMloRDCT40= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712744384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=OfZmSmKh099HIumNG3ZxssFyQ7fWVe4LYRQhSilPVG4=; b=HOkC309YKzHGxscpULrPyjPtKI48E8tZlAif48QOxuD5waVZfm0q1ci3nB+kSlV+swgwzJ U2MlhEDmqrHhQnBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B30DD13942 for ; Wed, 10 Apr 2024 10:19:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Fv5yKsBnFmZzWQAAD6G6ig (envelope-from ) for ; Wed, 10 Apr 2024 10:19:44 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/testsuite] Fix gdb.threads/access-mem-running-thread-exit.exp with clang Date: Wed, 10 Apr 2024 12:19:43 +0200 Message-Id: <20240410101943.2981-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Score: -1.08 X-Rspamd-Action: no action X-Rspamd-Queue-Id: C7D6534E85 X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-1.08 / 50.00]; MID_CONTAINS_FROM(1.00)[]; DWL_DNSWL_LOW(-1.00)[suse.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; BAYES_HAM(-0.07)[62.62%]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns, suse.de:dkim] X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org When running test-case gdb.threads/access-mem-running-thread-exit.exp with clang, we run into: ... (gdb) print global_var = 555^M No symbol "global_var" in current context.^M (gdb) FAIL: gdb.threads/access-mem-running-thread-exit.exp: all-stop: \ access mem (write to global_var, inf=2, iter=1) ... The problem is that clang removes the unused variable. Fix this in the same way as done in commit b4f767131f7 ("Fix gdb.base/align-*.exp and Clang + LTO and AIX GCC"), by incrementing the variable. Tested on x86_64-linux with gcc and clang. --- gdb/testsuite/gdb.threads/access-mem-running-thread-exit.c | 2 ++ 1 file changed, 2 insertions(+) base-commit: bdefc073061ff9e9334a1306e9c70745104dc57f diff --git a/gdb/testsuite/gdb.threads/access-mem-running-thread-exit.c b/gdb/testsuite/gdb.threads/access-mem-running-thread-exit.c index 5902542ee5b..af05b13c763 100644 --- a/gdb/testsuite/gdb.threads/access-mem-running-thread-exit.c +++ b/gdb/testsuite/gdb.threads/access-mem-running-thread-exit.c @@ -102,6 +102,8 @@ main (void) { int i; + global_var++; + for (i = 0; i < 4; i++) { struct thread_arg *p;