From patchwork Mon Apr 8 20:19:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guinevere Larsen X-Patchwork-Id: 88199 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 162F33858C39 for ; Mon, 8 Apr 2024 20:20:58 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8C1B83858C50 for ; Mon, 8 Apr 2024 20:19:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C1B83858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8C1B83858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712607583; cv=none; b=eNWfCelcnCwks9Xp21CgO79u9eRQPmasG47AKsJAva09EilJUIXSpZuQan33jsgUXsF+Ge9Su9xpUS7GWg8EPztboqdCZutQHDM/D/riAMNuyI5462P6vgspOTY4XUndFgWfyIo1NwxSUxVWkOTJyQit7fWC0QkkILCopaSmwl0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712607583; c=relaxed/simple; bh=XBMDIPkfU41dhoVSvqWA2bSfkoKlp196Ur82NtuBG0w=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=jhwukVVzh/zpBisxVpeMoj1+RLP4rT0EDss+UUWO54/+muBURen0tbkb4+ItRMKzOg48ROl7xNmm9mvvVpFEh9Gs5gngWgS/G3pMjDyldUIxBi/MA3DOh4/+kPm3zXXk26qWOtBY05Z0zPcQmKOOlHOEjsLb6riL1bjn5FsFNy0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712607579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YGAZLJWCw1ISjsV0kI/6Ip7VoTZi5oPayhexqegiOBA=; b=Kz5j1uOtradT91dXBh0CF3rcRPU/O9m138O8WHzbsj7n8pgFAM61CE6h4jK3pQqX1AQyyB 0H93IMyFBfRvylvTLbjg3oSpjOJ6Wlmk4+bgcVtqwdzlhiIXAuJ8OV8/qf9DKGgzxbH+m0 FpXBJRQU3rg1qV5sCAzvufRmz64xFK0= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-503--8zzNzAdNUyOrC4N9nVlvg-1; Mon, 08 Apr 2024 16:19:36 -0400 X-MC-Unique: -8zzNzAdNUyOrC4N9nVlvg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 84A7929ABA11; Mon, 8 Apr 2024 20:19:36 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.96.134.170]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91A481C0A923; Mon, 8 Apr 2024 20:19:35 +0000 (UTC) From: Guinevere Larsen To: gdb-patches@sourceware.org Cc: Guinevere Larsen , Jan Kratochvil Subject: [PATCH v2 5/5] gdb/testsuite: Test for a backtrace through object without debuginfo Date: Mon, 8 Apr 2024 17:19:15 -0300 Message-ID: <20240408201915.1482831-6-blarsen@redhat.com> In-Reply-To: <20240408201915.1482831-1-blarsen@redhat.com> References: <20240408201915.1482831-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Fedora has been carrying this test since back in the Project Archer days. A change back then caused GDB to stop being able to backtrace when only some of the object files had debug information. Even though the changed code never seems to have made its way into the main GDB project, I think it makes sense to bring the test along to ensure something like this doesn't pass unnoticed. Co-Authored-By: Jan Kratochvil --- .../backtrace-through-cu-nodebug-caller.c | 28 ++++++ .../backtrace-through-cu-nodebug-main.c | 32 +++++++ .../gdb.base/backtrace-through-cu-nodebug.exp | 87 +++++++++++++++++++ 3 files changed, 147 insertions(+) create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c new file mode 100644 index 00000000000..a33f86d1ece --- /dev/null +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c @@ -0,0 +1,28 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2005-2023 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +typedef int (*callback_t) (void); + +int +caller (callback_t callback) +{ + /* Ensure some frame content to push away the return address. */ + volatile const long one = 1; + + /* Modify the return value to prevent any tail-call optimization. */ + return (*callback) () - one; +} diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c new file mode 100644 index 00000000000..f958c0200c7 --- /dev/null +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c @@ -0,0 +1,32 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2005-2023 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +typedef int (*callback_t) (void); + +extern int caller (callback_t callback); + +int +callback (void) +{ + return 1; +} + +int +main (void) +{ + return caller (callback); +} diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp new file mode 100644 index 00000000000..89122c26138 --- /dev/null +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp @@ -0,0 +1,87 @@ +# Copyright 2010-2023 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test that GDB can generate accurate backtraces even if some of the stack +# trace goes through a function with no debug information. + +standard_testfile -caller.c -main.c +set objmainfile ${testfile}-main.o +set objcallerfile ${testfile}-caller.o + +# recompile the inferior with or without CFI information, then run the +# inferior until the point where the important test starts +# returns TRUE on an ERROR. +proc prepare_test {has_cfi} { + global srcdir subdir srcfile srcfile2 objmainfile objcallerfile binfile + if {$has_cfi} { + set extension "cfi" + if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" ${objcallerfile} \ + object [list {additional_flags=-fomit-frame-pointer \ + -funwind-tables -fasynchronous-unwind-tables}]] != "" } { + untested "couldn't compile without cfi" + return true + } + } else { + set extension "no-cfi" + if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" ${objcallerfile} \ + object [list {additional_flags=-fomit-frame-pointer \ + -fno-unwind-tables \ + -fno-asynchronous-unwind-tables}]] != "" } { + untested "couldn't compile with cfi" + return true + } + } + if {[gdb_compile "${objmainfile} ${objcallerfile}" \ + "${binfile}-${extension}" binfile {}] != ""} { + untested "couldn't link object files" + return true + } + + clean_restart "$binfile-${extension}" + + with_test_prefix "${extension}" { + + if ![runto callback] then { + fail "has_cfi=$has_cfi: Can't run to callback" + return true + } + gdb_test_no_output "main frame-unwinder disable ARCH" + return false + } +} + +if {[gdb_compile "${srcdir}/${subdir}/${srcfile2}" ${objmainfile} \ + object {debug}] != "" } { + untested "couldn't compile main file" + return +} + +if { [prepare_test false] } { + untested ${testfile}.exp +} else { + gdb_test "bt" "frame_unwind_find_by_frame failed.*" \ + "verify unwind fail without CFI" +} + +if { [prepare_test true] } { + untested ${testfile}.exp +} else { + # #0 callback () at ... + # #1 0x00000000004004e9 in caller () + # #2 0x00000000004004cd in main () at ... + gdb_test "bt" \ + "#0 +callback \[^\r\n\]+\r\n#1 \[^\r\n\]+ in caller \[^\r\n\]+\r\n#2 \[^\r\n\]+ in main \[^\r\n\]+" \ + "verify unwinding works for CFI without DIEs" +}