From patchwork Wed Mar 27 15:22:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rohr, Stephan" X-Patchwork-Id: 87704 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 658143858012 for ; Wed, 27 Mar 2024 15:23:06 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by sourceware.org (Postfix) with ESMTPS id 1F6D83858D34 for ; Wed, 27 Mar 2024 15:22:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F6D83858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F6D83858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711552940; cv=none; b=Gzuqf2fSyoohsjLB4KUlXnVYQnaaQDmkeG8WOgFYA6rXlKgvEfHqXJAddiRi2JvRY7jeXIDIeaXLH9J58Q0CN5crbDPaKPhm5zzBvDogQTuUBBzyFIPhC9cOSTSxgCrA5znQOZG6RyeSmOTjHfhPbPTw1q+pMpOFARt9Ouqu6L4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711552940; c=relaxed/simple; bh=cSvGCm8fh2LDnzLBHs3tORuKSamGSuhU2kddIeDkT/Q=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=n11NHPprSIanQmHNYsY/K2OTKdxOK+UhtOmSGjhByeub5Bmv9Tiu72yUGnUb3qOFDVLOJsZv++z+NhAPYrizE2nEEfFID+HPXd9ptGGrRxZXtMKRYpUlekAYkRI+ktGECSwmOsue2rDN8anwsAWcRf+sH00jm9IFTvqYFWikHls= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711552938; x=1743088938; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cSvGCm8fh2LDnzLBHs3tORuKSamGSuhU2kddIeDkT/Q=; b=T04hWFgeKh1lpHtEUwkT17iTbRsSrKWFPbnIg3WKqVK3SFmTdsl7s3O3 mAybQA7tgSrqaZ9OyX9SMeNr+OXFpSmGDgkJ7zQdEKPyDDyKx0h+vfoJo y/XG6OzTZKzA9jUmP9DxGLJ9iYf3vczQ25yz5zCfIGIHByWNun6UahCQP 6HhZ9j0humDeEmNsMf71ZQDEIKADcZZtbt8kpIXk4A5mx+WAVkTwqh2TG nEUVmFpE0Fme+qFL3v6G1pbKXv1KLxVwcvBr0ab10bZt7C1Xc6GjaoREM Bfs/zVmeZdejHq6PDuLedX9pDTUVZdyZjZXf2sbvUEf0KBizkkJFeigm1 A==; X-CSE-ConnectionGUID: uhoGX8BYQyCpLEUY/tLZSg== X-CSE-MsgGUID: u+OJCMtbQKGGPgLVJR2K/g== X-IronPort-AV: E=McAfee;i="6600,9927,11026"; a="6527908" X-IronPort-AV: E=Sophos;i="6.07,159,1708416000"; d="scan'208";a="6527908" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2024 08:22:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,159,1708416000"; d="scan'208";a="20796150" Received: from jf.jf.intel.com (HELO localhost) ([10.165.54.65]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2024 08:22:17 -0700 From: Stephan Rohr To: gdb-patches@sourceware.org Cc: aburgess@redhat.com, tom@tromey.com Subject: [PATCH v3 1/1] gdb: Fix assertion in 'value_primitive_field' Date: Wed, 27 Mar 2024 08:22:08 -0700 Message-Id: <20240327152208.8321-2-stephan.rohr@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240327152208.8321-1-stephan.rohr@intel.com> References: <20240327152208.8321-1-stephan.rohr@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org From: "Rohr, Stephan" GDB asserts that the data location of a value's field with a dynamic data location is resolved when fetching the field's value in 'value_primitive_field'. This assertion was hit because of bogus DWARF generated by the Intel Fortran compiler. While that compiler should fix the DWARF, we prefer GDB to error out here instead, e.g. to allow the user to continue debugging other parts of the program. --- .../locexpr-data-member-dynamic-location.c | 32 +++++ .../locexpr-data-member-dynamic-location.exp | 129 ++++++++++++++++++ gdb/value.c | 4 +- 3 files changed, 164 insertions(+), 1 deletion(-) create mode 100644 gdb/testsuite/gdb.dwarf2/locexpr-data-member-dynamic-location.c create mode 100644 gdb/testsuite/gdb.dwarf2/locexpr-data-member-dynamic-location.exp diff --git a/gdb/testsuite/gdb.dwarf2/locexpr-data-member-dynamic-location.c b/gdb/testsuite/gdb.dwarf2/locexpr-data-member-dynamic-location.c new file mode 100644 index 00000000000..dbe591ab884 --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/locexpr-data-member-dynamic-location.c @@ -0,0 +1,32 @@ +/* Copyright 2024 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +struct container +{ + int *data; +}; + +int size = 5; + +int var_a_data[] = {5, 8, 13, 21, 34}; +struct container var_a = {var_a_data}; + +int +main (void) +{ + return 0; +} diff --git a/gdb/testsuite/gdb.dwarf2/locexpr-data-member-dynamic-location.exp b/gdb/testsuite/gdb.dwarf2/locexpr-data-member-dynamic-location.exp new file mode 100644 index 00000000000..1dd2e91ffdd --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/locexpr-data-member-dynamic-location.exp @@ -0,0 +1,129 @@ +# Copyright 2024 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# +# Tests that GDB prints an error when fetching a value's (dynamic) field +# with unresolved data location. For a reproducer, we setup the following +# struct type: +# +# struct container +# { +# int *data; +# }; +# +# We use a variable 'size' to define the upper bound 'DW_AT_upper_bound' for +# the non-static field 'data'. The error reproduces with invalid DWARF, i.e. +# when pushing the memory location of an instance 'var_a' of struct +# 'container' on the DWARF stack: +# +# DW_AT_location { +# DW_OP_addr [gdb_target_symbol var_a] +# DW_OP_deref +# DW_OP_stack_value +# } SPECIAL_expr} + +load_lib dwarf.exp + +# This test can only be run on targets which support DWARF-2 and use gas. +if {![dwarf2_support]} { + return 0 +} + +standard_testfile .c -dw.S + +if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { + return -1 +} + +# Make some DWARF for the test. +set asm_file [standard_output_file $srcfile2] +Dwarf::assemble $asm_file { + cu {} { + DW_TAG_compile_unit {} { + declare_labels integer_label array_label struct_label var_a_label + set int_size [get_sizeof "int" 4] + set addr_size [get_sizeof "void *" 8] + + integer_label: DW_TAG_base_type { + {DW_AT_byte_size $int_size DW_FORM_sdata} + {DW_AT_encoding @DW_ATE_signed} + } + + array_label: DW_TAG_array_type { + {DW_AT_type :$integer_label} + {DW_AT_data_location { + DW_OP_push_object_address + DW_OP_deref + } SPECIAL_expr} + } { + DW_TAG_subrange_type { + {DW_AT_type :$integer_label} + {DW_AT_upper_bound { + DW_OP_addr [gdb_target_symbol size] + DW_OP_deref + DW_OP_lit1 + DW_OP_minus + } SPECIAL_expr} + } + } + + struct_label: DW_TAG_structure_type { + {DW_AT_byte_size 8 DW_FORM_udata} + } { + DW_TAG_member { + {DW_AT_name "data"} + {DW_AT_type :${array_label}} + {DW_AT_data_member_location 0 DW_FORM_udata} + } + } + + DW_TAG_variable { + {DW_AT_name var_a_valid_location} + {DW_AT_type :$struct_label} + {DW_AT_location { + DW_OP_addr [gdb_target_symbol var_a] + } SPECIAL_expr} + } + + DW_TAG_variable { + {DW_AT_name var_a_invalid_location} + {DW_AT_type :$struct_label} + {DW_AT_location { + DW_OP_addr [gdb_target_symbol var_a] + DW_OP_deref + DW_OP_stack_value + } SPECIAL_expr} + } + } + } +} + +# Now that we've generated the DWARF debugging info, rebuild our +# program using our debug info instead of the info generated by +# the compiler. + +if { [prepare_for_testing "failed to prepare" ${testfile} \ + [list $srcfile $asm_file] {nodebug}] } { + return -1 +} + +if ![runto_main] { + return -1 +} + +gdb_test "print var_a_valid_location" \ + " = \\{data = \\{5, 8, 13, 21, 34\\}\\}" + +gdb_test "print var_a_invalid_location" \ + " = \\{data = is_constant ()); + if (!TYPE_DATA_LOCATION (type)->is_constant ()) + error (_("cannot read %s, expected an already resolved data " + "location."), arg_type->field (fieldno).name ()); /* For dynamic data types defer memory allocation until we actual access the value. */ v = value::allocate_lazy (type);