From patchwork Wed Mar 27 14:30:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 87701 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A83BC3858407 for ; Wed, 27 Mar 2024 14:31:11 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 3FB623858C55 for ; Wed, 27 Mar 2024 14:30:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FB623858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3FB623858C55 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711549843; cv=none; b=D2fFzYCRsVwWyhXNGnYk7muCgzSbS4zNo5vLipesNC26LvmxjampcugZVUtCri7F337bWIBMX/3Sg+/+vwHRmsMQlI+Bv/s+CfGyOuQljULSZEiJKCJ6ya2zFzXQWEQDcTznuEfBsxilH1g2kwiOhQe1NTE74//DTpFJkQk5WKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711549843; c=relaxed/simple; bh=uA9GW6RECjw4b2E5ZOCcbHH4MiJKDMrlad6IKe5mdCk=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=DwUeW44FJqZrvc7HX7PX7M3GiaF9Bxgvpph/6MGoepGBN7EyiIcdc4Z+prapcHOQrDEjJouOVJoZfvAWLizSxLYYah4JLs9CbIxFaRSKJzfx3jT3KPjrLFxmj3CktZ91KQg4qNX7SGkeCWl+PHYaQZTUv//H9h4oII4ijvGa6nE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 472EF38B19 for ; Wed, 27 Mar 2024 14:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711549840; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1j+NsdiyHx0uHkSoJ2LjKPTfDicj1Jka+ZZQdyZCtuc=; b=Ba/cm+Au7dkpQPPk2XoLqi8di+ucGsUm6RZ5jRisJB0SwL0I20WGkpBbIPYcR9BTWX/ucy ZEQGhIBdNp9FF9eIMiN7oH+6/fIaA2/K7274YNWRINOHavpkwpKR/fxjFTc6K5mKolME2q fRZeNM+ngMaHKgd72N4zZE7A833nujE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711549840; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1j+NsdiyHx0uHkSoJ2LjKPTfDicj1Jka+ZZQdyZCtuc=; b=DPPmc27rZmaRCBAOs0h86i7c13Sra0P8bzZq6qdtl8wcRKFrEJyUuujL1fppHr/gNJNqum x+cuSkuiUsBj37DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711549839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1j+NsdiyHx0uHkSoJ2LjKPTfDicj1Jka+ZZQdyZCtuc=; b=cBWjrZNZZwXvG3JdzlBnISzAeWTa0Xe9psgDddSL8/n4YdcZ6f6fYgBJVWRjBk5mpszWZJ rCtsAY3e83cOOAd/xmd0fmgDG8h1/tShDX2HIwY7cUhsn7ZSalNqSKYN/d5BdqH+YHroSn 6+3+gQU5kf/IUWN4YzpikOUMO9uce90= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711549839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1j+NsdiyHx0uHkSoJ2LjKPTfDicj1Jka+ZZQdyZCtuc=; b=9A04Mt0y72/5VNerjleovwvy9H3xJ/k39JArIsztNWDaY7LeYFhSWq/uMyleXGaswqrysJ 75Em5c4p4GCANxCA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 30A5D13B04 for ; Wed, 27 Mar 2024 14:30:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id YDSJCo8tBGa/WAAAn2gu4w (envelope-from ) for ; Wed, 27 Mar 2024 14:30:39 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 3/3] [gdb/testsuite] Add missing includes in gdb.trace/collection.c Date: Wed, 27 Mar 2024 15:30:38 +0100 Message-Id: <20240327143038.20021-3-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20240327143038.20021-1-tdevries@suse.de> References: <20240327143038.20021-1-tdevries@suse.de> MIME-Version: 1.0 X-Spam-Level: X-Spamd-Bar: / Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=cBWjrZNZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9A04Mt0y X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [0.83 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:98:from]; R_MISSING_CHARSET(2.50)[]; TO_DN_NONE(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-1.66)[92.85%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_LOW(-1.00)[suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[] X-Spam-Score: 0.83 X-Rspamd-Queue-Id: 472EF38B19 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org On fedora rawhide, with test-case gdb.trace/collection.exp, I get: ... gdb compile failed, collection.c: In function 'strings_test_func': collection.c:227:13: error: implicit declaration of function 'malloc' \ [-Wimplicit-function-declaration] 227 | longloc = malloc(500); | ^~~~~~ collection.c:1:1: note: \ include '' or provide a declaration of 'malloc' +++ |+#include 1 | /* This testcase is part of GDB, the GNU debugger. collection.c:228:3: error: implicit declaration of function 'strcpy' \ [-Wimplicit-function-declaration] 228 | strcpy(longloc, ... ); | ^~~~~~ collection.c:1:1: note: include '' or provide a declaration of \ 'strcpy' +++ |+#include 1 | /* This testcase is part of GDB, the GNU debugger. collection.c:230:8: error: implicit declaration of function 'strlen' \ [-Wimplicit-function-declaration] 230 | i += strlen (locstr); | ^~~~~~ collection.c:230:8: note: include '' or provide a declaration of \ 'strlen' ... Fix this by adding the missing includes. Tested on aarch64-linux. --- gdb/testsuite/gdb.trace/collection.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/testsuite/gdb.trace/collection.c b/gdb/testsuite/gdb.trace/collection.c index efcc2e389da..8379b7d7eaf 100644 --- a/gdb/testsuite/gdb.trace/collection.c +++ b/gdb/testsuite/gdb.trace/collection.c @@ -19,6 +19,9 @@ * Test program for trace collection */ +#include +#include + /* * Typedefs */