From patchwork Fri Mar 22 19:04:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 87537 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CAB103858298 for ; Fri, 22 Mar 2024 19:05:18 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by sourceware.org (Postfix) with ESMTPS id 5C6D93858415 for ; Fri, 22 Mar 2024 19:04:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C6D93858415 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5C6D93858415 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711134292; cv=none; b=j9LauTB33W2TdtUdXff+UcO8UG0aaHHPAACZBnVFPtDs1875HQmjnBN4bCfDDFJhxm6wvi5/010iXWzoT08YePAP+nvpDu+9WRWRBPUi6C2QR/EQsE5f1xBUOI3HsRCicXmf/upBiBhGfO49w8NTlQbtnRj0MZBOrVTbVB3ja4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711134292; c=relaxed/simple; bh=nyzLxGoXlu6SoSfqmn1ZKp9CTWGsO4cqKB4nfSPU5jE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=oNm4ojCKimirfV2G67p014eyk9iuu1/xd2JdZn86V67/1cSq9DWee2GC/HdII2xZ04A/IPJepY+mL27KHUuFaB7oFqSsiyvXmw9f859CH11u1oiEpBM6FR8is8RbBDYDM+FW9U+2UBp7L1Ca4h20r0uo8e7xm/A2Wtn3VmCXAHI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-341808b6217so1392175f8f.3 for ; Fri, 22 Mar 2024 12:04:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711134277; x=1711739077; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D2QjPzhIMMk2yvetYV0ZGFU3P5mu8s+fPGGEuGbARj4=; b=KlN3lhhe9wrLzHZ1ve8UoKqVJ6cnnE6YyiiM3qEIuLoHlrQYd8hb9KnvcpS2WJaS+D YVlglTAx2GN7gDUx7vON+vjoLIx4xPDqT7sG4Qw9hMaTYzJVgeY2bPCzy+HZ7ElRi6Ls zB4lw14IrgltbFyJjbug6rA0RQngy7QWoZ0/g7Z1733NpdFfaycb8Di9pHci3CLCZjwS nHIa4y+ItTBq945SpIZBQC451VXdkdOUxw5en2h4fjU9If6I+4bbTvNxPbU503Vs8pI6 b4yKU3fA1GghxrDC1Jed32ldKsAc+xzwAau5tEG3ApN8ArZWXs5Jmo1MCTgnuLYvdbJg yZwA== X-Gm-Message-State: AOJu0YwPoHX7w4+Sf2YQnxuS4QsgW6xw9zoow7PLKjLsrxX/NijPWzJM x2Wi7QlZNG0ikbXpcThOgNHQoE/WRE1HOG3czEI0TAbHVqlFEaJ3oQtL0NbD X-Google-Smtp-Source: AGHT+IGlM9qFaFXdqBch3uf0p1KbDKFNgZFAJ/ecrxJ2JeT3U4lrFbaf5Nw35x83D4oRZ3MoIOhiNw== X-Received: by 2002:a05:6000:1952:b0:33e:767a:c3a2 with SMTP id e18-20020a056000195200b0033e767ac3a2mr196098wry.17.1711134276933; Fri, 22 Mar 2024 12:04:36 -0700 (PDT) Received: from localhost ([2001:8a0:f918:ab00:3ba9:feec:1922:9a68]) by smtp.gmail.com with UTF8SMTPSA id cr1-20020a05600004e100b0033b48190e5esm2657007wrb.67.2024.03.22.12.04.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 12:04:36 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 4/4] windows-nat: Use gdb_realpath Date: Fri, 22 Mar 2024 19:04:24 +0000 Message-ID: <20240322190424.1231540-5-pedro@palves.net> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240322190424.1231540-1-pedro@palves.net> References: <20240322190424.1231540-1-pedro@palves.net> MIME-Version: 1.0 X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Use gdb_realpath instead of realpath in windows-nat.c:windows_make_so, so that we don't have to manually call free. Change-Id: Id3cda7e177ac984c9a5f7c23f354e72bd561edff --- gdb/windows-nat.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 278bfb0e1f1..ee38b985efa 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -891,12 +891,9 @@ windows_make_so (const char *name, LPVOID load_addr) } else { - char *rname = realpath (name, NULL); + gdb::unique_xmalloc_ptr rname = gdb_realpath (name); if (rname != nullptr) - { - so->name = rname; - free (rname); - } + so->name = rname.get (); else { warning (_("dll path for \"%s\" inaccessible"), name);