From patchwork Fri Mar 22 19:04:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 87538 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 684BF3858412 for ; Fri, 22 Mar 2024 19:05:39 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by sourceware.org (Postfix) with ESMTPS id 5C0663858D32 for ; Fri, 22 Mar 2024 19:04:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C0663858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5C0663858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711134278; cv=none; b=n01oDnYZT1faetRgWWBMPReCcUWCH8rHiNnjjHq6fPN2Hf8sUdP2knk2JYnkldHeyrjxUSvxv5sR98DHVycO9XHZ6W+i4bLhAHZYI1YDH6QBrZXVzDfhjq6M/K+suXj1oY3Bc1Xwcc4d00+WNYDZhzeXTxJsTWJElhRI9ejJozg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711134278; c=relaxed/simple; bh=eQXa46t7Zy5rG5wF23pCk+dDy3g2biM9immruxiazmM=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=ZNJJ2gDdsfe5tVwyFL1NoOj1JvaGQnEQprH79sv+vsa4Sc0nQbnkJ73u4ZWlSy72U/+t8X7V4wdQ9pivRIh9a4wPDFYoGRtgS3bXnebQU9/qazsX+U08OokVp4Vsa4b1qKvM/JQRpiaZ6suSMh1oGguIAcSrJoBUp8AtTHv/BjI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-34169f28460so1367282f8f.2 for ; Fri, 22 Mar 2024 12:04:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711134271; x=1711739071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mMUBrr0zbFXVGUz8Kia1IQwQV3J7Cl4tQY2saY6cfEs=; b=oNYthZmDuP8HmJ8MeeccG2MkmByZwnXNtn72EidGdkjqHQ2syFMbWcpy8le34kKp4l TA8SZWgwXQYjEXvS1E/zlbIxVi3okQXILpAHxhnYmFVIqDb55hvtozSjvIFo2Oc/X8j5 OrOAHuUqMTbufNjihuHPQMp39jNt1jNIUTkKYAe3KF3p2xD5uTLQwfoz+E+bY7v2uN5P LngmBpJhtPYN5b3QfOvcNp6yMJkEUxyzg7UimtuI+Vv2i5tyN/zJ9DXvFnANJQVC2GxP 30+zYa7O9oUS7ikh8SC6WzJ73CqjsriOJXDJ+FO3tUv4xluWkeObeEeOMVFD7VreWMbr Y+tQ== X-Gm-Message-State: AOJu0YyZ6Ej/73jvALf+BL3sokXslmGrf+vmvElqXKD0gZ45+TtCJQ6d /Q01yshGHhtUGZRGgRNr1rImgXtIyCY2XCASc+QSX7YWRnsFd+c2mxfXnS04 X-Google-Smtp-Source: AGHT+IE/F6MukyvpfCzSGSQ3QF5P2inAOU8eGDjc9nNpV7LWsdcMce0A6Srml81LQfSybKhPdTn9MA== X-Received: by 2002:adf:e902:0:b0:341:7269:e4d0 with SMTP id f2-20020adfe902000000b003417269e4d0mr202774wrm.54.1711134270823; Fri, 22 Mar 2024 12:04:30 -0700 (PDT) Received: from localhost ([2001:8a0:f918:ab00:3ba9:feec:1922:9a68]) by smtp.gmail.com with UTF8SMTPSA id fa18-20020a05600c519200b00414612a43a9sm308070wmb.28.2024.03.22.12.04.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 12:04:30 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 1/4] Remove SO_NAME_MAX_PATH_SIZE limit from core solib code Date: Fri, 22 Mar 2024 19:04:21 +0000 Message-ID: <20240322190424.1231540-2-pedro@palves.net> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240322190424.1231540-1-pedro@palves.net> References: <20240322190424.1231540-1-pedro@palves.net> MIME-Version: 1.0 X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org solib_map_sections errors out if the library file name is longer than SO_NAME_MAX_PATH_SIZE. solib::so_name and solib::so_original_name used to be arrays of SO_NAME_MAX_PATH_SIZE size, so that check made sense then. However, since commit 98107b0b17ac ("gdb: make so_list::{so_original_name,so_name} std::strings") those fields are of std::string type, so there's really no need for the limit. This commit simply removes the length limit check. Change-Id: I2ec676b231cd18ae900c61c5caea461f47e989e6 --- gdb/solib.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/gdb/solib.c b/gdb/solib.c index 952897c37fc..9497f5d3099 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -591,8 +591,6 @@ solib_map_sections (solib &so) the library's host-side path. If we let the target dictate that objfile's path, and the target is different from the host, GDB/MI will not provide the correct host-side path. */ - if (strlen (bfd_get_filename (so.abfd.get ())) >= SO_NAME_MAX_PATH_SIZE) - error (_ ("Shared library file name is too long.")); so.so_name = bfd_get_filename (so.abfd.get ()); so.sections = build_section_table (so.abfd.get ());