From patchwork Wed Mar 20 11:13:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 87405 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 634BA3858289 for ; Wed, 20 Mar 2024 11:13:48 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id E5C623858419 for ; Wed, 20 Mar 2024 11:13:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E5C623858419 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E5C623858419 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710933204; cv=none; b=xq3tbHnrRyvrVRVNyO3iPg4kH9/euRAxwLrNGB+0ss9mPKIHV66XEdmtXckTSNvSTmNMbxKdKqPzC4Dm34PNbMgDPQ0te7+gY8Cc5D/vFsG5otSVZ/2zWqD1rUXreTRxfHOSnQ6H03lLITjFhsPkWqtaUiGZ1raH76op3Vxz0Ns= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710933204; c=relaxed/simple; bh=JDwDYtQQcusJoMCApSGquq3JmfgeGl/9wxBnri1hmTU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xzqJa4/H7xMzO0E+GNOYYV3R+p+oq+677P6jLzgnwGYLJSfrsDLBulQ+wdTj57bvviIHs9yG59g7NhmawNOes6JZimOQDHCX2hW/m970OsKLZfsprZQPbLWPMPLFdzEAngxd3j9Ye2oerb95ZllN8ZFf/vSsgGmWUnZPEqqImP0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6e6adc557b6so6102193b3a.2 for ; Wed, 20 Mar 2024 04:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710933200; x=1711538000; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IrRz8BNbhXs8Ir9FQH73ElVErXKJwX2tqgfyENWqg9Y=; b=LdXjYvLiF9S+3P8QXokT5rPQMMwJkWTYy68WSGjCQ9as2a1NOsBma7NZeJML6mqzJa b6yCD49iBKwbAMqdEXsuka/M2dJ6D6ly1pQjkHADfMmCpqjV9XnSZzievw5NIcGeWDCu VHsozqtZxRU22LkCPux2eA3R8Ti7asnovZfGA9EEjQ5HD3pzslHhPrkrrVU7uKy4KjyC vnYXVpt5z+HO4oQPrvQohnjKKI6g81bZnTKzdZhtMyFLEz9Ao8+6PNtgNfYTQ1a4OUlT SvRU2kMh245ouhRiFS/KsXgtGKnuLqZ51UB2EsZ3HoQuZAVnV3BO/NLY6fd66e0WJDcd ccMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710933200; x=1711538000; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IrRz8BNbhXs8Ir9FQH73ElVErXKJwX2tqgfyENWqg9Y=; b=cltm/X/2ZNr98iTDpafYBuMSzNAGKwO45cg10O2iNX9SQnCCVwLE5x7+88WuXpSirW T8/EIssSQfq0Ou8IcoCZx5pRgb5dbWz+tI4iMAMOPVwFufT9YgiexLxgUs7zXmKlq9d7 TKlFWmRyFgKbbZiqpitW2OfnYVTJKaQbhevwe1gsdz6sETyP+r3OVFKwHq8HML3+IyXO 6h2hM+KZdEXS4eTsdpKOAfxzWBrKaNstK2X/zJEPnwkBzVryR8hJKElfmPJJVUAn96T6 1yh1FLMUcJXI//speO7LqhPeGd3hMbQ90/gx9heWtQBIorhkao1O+uHQGjmOzezOzIeK X48g== X-Gm-Message-State: AOJu0YyXmezBDZZ5cI8SQtFRhAiheBlMjDzOhLXrTOn5ZMJzHUVypYad 5hEGUraozd+sLoQLbydAgMcsIHYn5MtRvy85454XMVsoLzTQBjwm X-Google-Smtp-Source: AGHT+IFUcsg23+wRW8uoKqig96er2rvpLOQxnqJQWlFq7mvvESnmVN8vmL+EDw7Iq/MbKKRoEwTTDg== X-Received: by 2002:a05:6a20:2583:b0:1a3:8e26:4ba1 with SMTP id k3-20020a056a20258300b001a38e264ba1mr105435pzd.18.1710933199808; Wed, 20 Mar 2024 04:13:19 -0700 (PDT) Received: from gnu-cfl-3.localdomain ([172.58.89.72]) by smtp.gmail.com with ESMTPSA id m9-20020a62f209000000b006e689b25e38sm11628438pfh.90.2024.03.20.04.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 04:13:19 -0700 (PDT) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 52BB4740429; Wed, 20 Mar 2024 04:13:18 -0700 (PDT) From: "H.J. Lu" To: gdb-patches@sourceware.org Cc: felix.willgerodt@intel.com, jhb@FreeBSD.org Subject: [PATCH v2] gdbserver: Clear X86_XSTATE_MPX bits in xcr0 on x32 Date: Wed, 20 Mar 2024 04:13:18 -0700 Message-ID: <20240320111318.117728-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3020.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Since MPX isn't available for x32, we should clear X86_XSTATE_MPX bits on x32. PR server/31511 * linux-x86-low.cc (x86_linux_read_description): Clear X86_XSTATE_MPX bits in xcr0 on x32. Reviewed-by: Felix Willgerodt --- gdbserver/linux-x86-low.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdbserver/linux-x86-low.cc b/gdbserver/linux-x86-low.cc index 3af0a009052..933d1fb012a 100644 --- a/gdbserver/linux-x86-low.cc +++ b/gdbserver/linux-x86-low.cc @@ -938,6 +938,10 @@ x86_linux_read_description (void) xcr0 = xstateregs[(I386_LINUX_XSAVE_XCR0_OFFSET / sizeof (uint64_t))]; + /* No MPX on x32. */ + if (machine == EM_X86_64 && !is_elf64) + xcr0 &= ~X86_XSTATE_MPX; + xsave_len = x86_xsave_length (); /* Use PTRACE_GETREGSET if it is available. */