From patchwork Thu Mar 7 15:01:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Metzger, Markus T" X-Patchwork-Id: 86938 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC147385782D for ; Thu, 7 Mar 2024 15:01:38 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by sourceware.org (Postfix) with ESMTPS id 5F1053858C36 for ; Thu, 7 Mar 2024 15:01:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F1053858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5F1053858C36 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709823677; cv=none; b=whsUNSylZfR9cLh4VkWe520SbSo/Us8LdhTOYRb44VW7FvLvwCH8pND5frNQdzLPqLFguU2GaWD9nGnB+ZmnLG82UjqgGDVWqUWShAx6uwlprLvsfWHsegK9M9ELI4JDU4JaD1BqB0yS7BkOraykom5oMUK6FTLs6MNF1P6pKlY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709823677; c=relaxed/simple; bh=Vz0m06vEvLiAmiC4QF5x/X4yS4Lct9sX8gAItffHU6A=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=icJHx4fZ+8x3RhxqMCs039OFDKNmUqLgDyLQAARXRETQj/F/q5iVy5ZQ18vh2FUymvqNC7KA330UDF6CdNzrY7J0uwUo7zzW3Ptfc8mcbNEjRmBv9sq3uUETET6DYQEgJ9lWjsaBeBg05SASqf7r7UjTWcVbBUPUlBSpZuoX82g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709823675; x=1741359675; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=Vz0m06vEvLiAmiC4QF5x/X4yS4Lct9sX8gAItffHU6A=; b=UbKwnZJ94BruafxScVBw8dQNzhrsBCYHLOfB3GuMqLQWsRrVPDNQvO2N rxgHzBU7t6Uk/4coKa82v2lQdNJcWPYPkalE1MnSJKsGUvVeLqZtvnqJR kbHTpBSQTroPREIrC/KZlI+YTRZTzJr6rdZE4L6PyCKPMjkGWgtRtiAD8 TBnUSjdPa89F8DKom0EX/VB4hECDALqwE19iUZwEcV0Uvh+ApeUTB3ggY drz0NOuA6/tO9MKT2znPTc51jiUQLsc1N7t60+Pz3ivnbf7Z1+7iQsHXd XRCvDZr0z91JeXY1wh+TV2UIEETnxSma+/pr1n+6bZ0kAP6nDqPbQc8Ks g==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="4350764" X-IronPort-AV: E=Sophos;i="6.07,211,1708416000"; d="scan'208";a="4350764" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 07:01:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,211,1708416000"; d="scan'208";a="10210966" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 07:01:12 -0800 From: Markus Metzger To: gdb-patches@sourceware.org Subject: [PATCH] gdb, btrace: fix error diagnostics Date: Thu, 7 Mar 2024 15:01:10 +0000 Message-Id: <20240307150110.3348612-1-markus.t.metzger@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org When we improved error messages in cd393cec3ab gdb, btrace: improve error messages we cleared the original errno. When the error reason can not be explained in a more detailed error message, and we fall back to the default error message, it now gives Success as error. Restore the original errno to fix that. --- gdb/nat/linux-btrace.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/nat/linux-btrace.c b/gdb/nat/linux-btrace.c index 50de2415589..f8352b62b8b 100644 --- a/gdb/nat/linux-btrace.c +++ b/gdb/nat/linux-btrace.c @@ -422,7 +422,8 @@ cpu_supports_bts (void) static void diagnose_perf_event_open_fail () { - switch (errno) + int orig_errno = errno; + switch (orig_errno) { case EPERM: case EACCES: @@ -443,7 +444,7 @@ diagnose_perf_event_open_fail () break; } - error (_("Failed to start recording: %s"), safe_strerror (errno)); + error (_("Failed to start recording: %s"), safe_strerror (orig_errno)); } /* Get the linux version of a btrace_target_info. */