From patchwork Thu Mar 7 13:28:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Metzger, Markus T" X-Patchwork-Id: 86930 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 684253857715 for ; Thu, 7 Mar 2024 13:30:26 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by sourceware.org (Postfix) with ESMTPS id 97E2B3857BBC for ; Thu, 7 Mar 2024 13:28:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 97E2B3857BBC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 97E2B3857BBC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709818142; cv=none; b=Lw6ekD300cDuph9CQOoJqe9jf4iBzQEGsAaCnn4f/DCf9h895iQkgNBakszMWCdqhKpPFARs6kD8n7g4t61CQEYLOXgtKZV6+pDSUtxS/bC3AiE4HWMAh8IQNo1W/oAQz7+2KQO3PCp3eWMNrm4Il4kXj/TSoaLI5Ggh1kvMp3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709818142; c=relaxed/simple; bh=yvlxor1VbGhwkCCQxFwTdFMXaZ2KxhtckwEzAOJ7cTg=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=a+xT5pDcn6ify/ebpeg7j7B5yqZ9aZDkf7XXcAHkN3sDnvwL/Uh0IdW94oOf/e93jo8II02vmTKYTBiuFg+xLcrxcBY+jjBENDKY1/VSOe7h42OH3PVWfynQc9s15brvTqZxppp5d37TN6b8j4wWdIlXQkZexM9Nh1nM/6TpwLg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709818139; x=1741354139; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=yvlxor1VbGhwkCCQxFwTdFMXaZ2KxhtckwEzAOJ7cTg=; b=KXQMWZYq2NK05G4XrCIWtKEr3yvF4D8K9RwP/70viT4HeQtgMJ/eJPAx f5orCo8EnKj6l1EXQbRWxMMdPlZ5gXcDbWCswtM5Hm5zhE6054vfP1law 62yaEHIY1Tm5MQhjIlJFghM6zdqpIO7KShIBM+Mp6uVLCfWA10gYWlRKJ Z4jZdPK86muP65b516rVIEsgOffjkW2E5Avcr0mm3FlMwqNyGjprGKOLj yc7HjA6j5bgEnmAEVJP27BQkr8KHw2Hm1i1zLl7bf+wqC6l0qz7+E/hjw LPyCkenOcaCwD1bJm8HFgL0EQ8gmHzr4qek+jxcilnorkcC90bc9Eh8dh g==; X-IronPort-AV: E=McAfee;i="6600,9927,11005"; a="4654421" X-IronPort-AV: E=Sophos;i="6.07,211,1708416000"; d="scan'208";a="4654421" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 05:28:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,211,1708416000"; d="scan'208";a="10010151" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 05:28:57 -0800 From: Markus Metzger To: gdb-patches@sourceware.org Subject: [PATCH 3/6] gdb, btrace: remove record_btrace_target::supports_*() Date: Thu, 7 Mar 2024 13:28:42 +0000 Message-Id: <20240307132845.2909415-4-markus.t.metzger@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240307132845.2909415-1-markus.t.metzger@intel.com> References: <20240307132845.2909415-1-markus.t.metzger@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Let's not introduce support for breakpoint types the target beneath does not support, even though we could while replaying. Otherwise, users may set breakpoints during replay that then couldn't be inserted into the target when switching back to recording. --- gdb/record-btrace.c | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index dd6ef8db3a3..9f2999268d8 100644 --- a/gdb/record-btrace.c +++ b/gdb/record-btrace.c @@ -131,10 +131,7 @@ class record_btrace_target final : public target_ops bool can_execute_reverse () override; bool stopped_by_sw_breakpoint () override; - bool supports_stopped_by_sw_breakpoint () override; - bool stopped_by_hw_breakpoint () override; - bool supports_stopped_by_hw_breakpoint () override; enum exec_direction_kind execution_direction () override; void prepare_to_generate_core () override; @@ -2707,18 +2704,6 @@ record_btrace_target::stopped_by_sw_breakpoint () return this->beneath ()->stopped_by_sw_breakpoint (); } -/* The supports_stopped_by_sw_breakpoint method of target - record-btrace. */ - -bool -record_btrace_target::supports_stopped_by_sw_breakpoint () -{ - if (record_is_replaying (minus_one_ptid)) - return true; - - return this->beneath ()->supports_stopped_by_sw_breakpoint (); -} - /* The stopped_by_sw_breakpoint method of target record-btrace. */ bool @@ -2734,18 +2719,6 @@ record_btrace_target::stopped_by_hw_breakpoint () return this->beneath ()->stopped_by_hw_breakpoint (); } -/* The supports_stopped_by_hw_breakpoint method of target - record-btrace. */ - -bool -record_btrace_target::supports_stopped_by_hw_breakpoint () -{ - if (record_is_replaying (minus_one_ptid)) - return true; - - return this->beneath ()->supports_stopped_by_hw_breakpoint (); -} - /* The update_thread_list method of target record-btrace. */ void