From patchwork Fri Feb 23 16:55:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 86292 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4551A385828B for ; Fri, 23 Feb 2024 16:56:29 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by sourceware.org (Postfix) with ESMTPS id E4F423858CD1 for ; Fri, 23 Feb 2024 16:56:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4F423858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E4F423858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708707362; cv=none; b=RxtgkIaSVH64tJwICraqKi2VzypIAMplOg7Mpgfh9MATI3CTlRxmaizvdzD5lgSVaqLdgEtIi+uKf3UX/nW2+5T8os9qE1UPLrGG2niQNG00mRBkHCwrEYeEOdH/VpfNT0kwGmhonlCSbd7YtE0t+QTfG1K/a3zieqxAv+htj5Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708707362; c=relaxed/simple; bh=oWmMKzxLxDCYgVYPqZfkOkzsly5SdCrvatAVbN0TGh8=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Ki9XcyC88n5vbyPeiP9FRoK4Vkf8YACGQ4+Aj0Q5x32B6atnLbf6/NlORGcBsOOMyzRuDUkvST6PkZNz2EfhUiO/O0iuRyRBO76sISsHBqqWHVEzt4XzAIvYAzchTN4zYDBVjtyh/fB6bxEMQkEbz8qFGkqZaKpDAynCSv+34Jg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-41296dce264so4128375e9.3 for ; Fri, 23 Feb 2024 08:56:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708707359; x=1709312159; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7xe4o+5A/1FbE096KAsAqztiT78xCPMrDbdOXn6sJpY=; b=Px8hS2zwBRcuvmLxjNRzowMOlRa0tLL+516a4xGXBSeb4GO8amL2ugFSulDG+Zz9Zb GtsoOR+tGYDuZcO1wsG3WW5o/1ZeWoOYEoTRN2fJbCq1hKEP+SZ2mJ3wOnDV2r4yyt9J 0LmrmmlMaNKrFXaCwr5HGjpWekpFbpCWh/CXwqPI+4cIP78kbB58NU0TlY26PWtNzIZ5 mRp3x9Hf2/sn5QmNNP9YCHf4AYx7bXLFXvrVafaTzY7rAb+Vcyugw1RulXCIoocaAVXm 5RLriej1ntBjmKkeLp29XRwVXUUoZFzojlApN/JXVIKsQfC2yKxouhkRbi7kPOVJdsQm xycQ== X-Gm-Message-State: AOJu0YyjVTgFD5lPLeYQyARWFlh9uDb/y2OWtaW8MJV8c+ul1+TYk+IE IEqS55GLVcuX+A5W9IxDSdXNJt/Yw426eAhKMDxntLUPaJAbmpc3WU+7jGTL45o= X-Google-Smtp-Source: AGHT+IF5zqMoP/VlNjoKJIHMG5TJUlAZU1TACAxype0wHud3DABq4q9rpHYRo5lCIbBOVdmK8aelwg== X-Received: by 2002:a05:6000:4ed:b0:33d:6be8:bb61 with SMTP id cr13-20020a05600004ed00b0033d6be8bb61mr228606wrb.35.1708707359437; Fri, 23 Feb 2024 08:55:59 -0800 (PST) Received: from localhost ([2001:8a0:f918:ab00:ac50:2e85:9ec5:a3f0]) by smtp.gmail.com with UTF8SMTPSA id t25-20020adfa2d9000000b0033b79d385f6sm3392467wra.47.2024.02.23.08.55.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Feb 2024 08:55:58 -0800 (PST) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH] Fix throw_winerror_with_name build error on x86-64 Cygwin Date: Fri, 23 Feb 2024 16:55:56 +0000 Message-ID: <20240223165556.1006879-1-pedro@palves.net> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The GDB build currently fails on x86-64 Cygwin, with: src/gdbsupport/errors.cc: In function ‘void throw_winerror_with_name(const char*, ULONGEST)’: src/gdbsupport/errors.cc:152:12: error: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘ULONGEST’ {aka ‘long unsigned int’} [-Werror=format=] 152 | error (_("%s (error %d): %s"), string, err, strwinerror (err)); | ^ Fix this by adding a cast. While at it, the error codes are really a DWORD that results from a GetLastError() call, so I think unsigned is more appropriate. That is also what strwinerror already does: sprintf (buf, "unknown win32 error (%u)", (unsigned) error); The cast is necessary on MinGW GDB as well, where ULONGEST is unsigned long long, but for some reason, I don't get a warning there. Change-Id: I3f5faa779765fd8021abf58bb5f68d556b309d17 --- gdbsupport/errors.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: e433bca4847acd34b6178a392335ed10060639ec diff --git a/gdbsupport/errors.cc b/gdbsupport/errors.cc index 8ac3ed0da79..cccdc5cafb2 100644 --- a/gdbsupport/errors.cc +++ b/gdbsupport/errors.cc @@ -149,7 +149,7 @@ strwinerror (ULONGEST error) void throw_winerror_with_name (const char *string, ULONGEST err) { - error (_("%s (error %d): %s"), string, err, strwinerror (err)); + error (_("%s (error %u): %s"), string, (unsigned) err, strwinerror (err)); } #endif /* USE_WIN32API */