From patchwork Tue Feb 20 15:21:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 86037 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CDB633858C41 for ; Tue, 20 Feb 2024 15:23:15 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 7F4973858D37 for ; Tue, 20 Feb 2024 15:21:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F4973858D37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F4973858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708442492; cv=none; b=IKSpgxKESftttMrOrjfTjb0fUYFNZwVlWyAOfQdy0ytlsZWTQrBoRluI1A7jR7uSY5dRdB1oTo2tntUXY1LurJwTH3mOhkdTDp8oKalyr55aP7DlFykCXWdOEozZ4QbyCCtDLR7u45xz4+wpnvS7nut5RnLQzPNf92O5M8HdA94= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708442492; c=relaxed/simple; bh=IVLDgjYF6AO7UyLVgTsCCLMgseMbqKPR4J2zuG+N9ws=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=pbtnX3BcArjLzziIjSyYiOFA8q4yu/iKnOZ7SO//uhUJE3uftLHpiro4awTh3UdIV5nFH9mT2zQBQFUP4ORaEZVJWNvU91XDEp4+eL0UegPWN4INDyi3iAuJah39/Cjjdv4HvvkUvcoSseeSdQA9Werx5tOoHcU+AyN3/Zk3S6w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12d.google.com with SMTP id e9e14a558f8ab-3650ea7f7d3so5787265ab.1 for ; Tue, 20 Feb 2024 07:21:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1708442487; x=1709047287; darn=sourceware.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=W08w9mDsW/if1berqk2+vmt/mY1riIPKEc3f7BmYuMQ=; b=X7DaEW/z80sYYhU/8rKhe7lTyT7gOTZlaT+w1CweJmy0FCds6wmVM5lfo3KTuo4Y7Q hKc5p9OFU3LyU5g8qlzWfB4EB+SUYrQoljP26gT6RRy3d2TL+LMyM3OfNF5z8OBpe/mc p6t49zUAToQ6MiFt0Eofz4vfIMYVVb6032OSzvIx4rtV3kaIZDMqn22RfycDPNqm022M NUejmjgGKRSyz5xph5vM4J4r6TioHwmGdovxUTKTY8PWngnxiF73FiRh98UTKUfDQNf6 p4V0QnoB1LwuspM3ymq5Z3rbeUx/NcF9XGhMIFrxycv9b4GUysK8sZPLHL8zt/eTgQwo lKQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708442487; x=1709047287; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W08w9mDsW/if1berqk2+vmt/mY1riIPKEc3f7BmYuMQ=; b=jWtM2vq0oEppkfJp23lH7cqTG5RlFU3UNp8eatBeY1r9NmfI+WMT8x9VKh+amf7KaX LW9coBNLe6JvpopmMa/p/Wq9LuNMBIvfSSNBwJKlKmI3iDr99rT2uziRRS0U90gP2uZ+ WJswPFtq24IcUX0YFQHAtyjTkwQXnOfgZ/nfjMb6libhJN7lNLkSh4jrbDBdScB3mTy8 yQRyGm+pOtrCgiKkY1rPkkaFeU0sg1tRSJ78JX+jSYofBGeYG65+xR4Ls0jRdZp6lXSQ XECMuo6PZ2l2l7fdcv3IhJAyFVHTrdfBS1X94hzy/JQN0xCfIMMy63iJEJMpjYRU9CPm nlaw== X-Gm-Message-State: AOJu0YzbJa5qBPFKygIqDfxopbTbzr7CHHzXcxaer2byh4sIEGo9RYz/ wRXNobYmzt/7dwef5RHj0d79QclWniMR1Zf0JW8ep3ycHpH3Jytttp1XZpHw85Rip71Jzzb0KR8 = X-Google-Smtp-Source: AGHT+IGgkjwxk7d3E1WgXSdyu1I/xyCAu7fSd0XcKdINIAX2TjqzeW3V8o2Dz8DTFDlo0Bvj7jX74Q== X-Received: by 2002:a92:b748:0:b0:365:d80:e1b2 with SMTP id c8-20020a92b748000000b003650d80e1b2mr11636211ilm.17.1708442487649; Tue, 20 Feb 2024 07:21:27 -0800 (PST) Received: from localhost.localdomain (71-211-170-195.hlrn.qwest.net. [71.211.170.195]) by smtp.gmail.com with ESMTPSA id k24-20020a023358000000b004743a0b8b8csm314914jak.153.2024.02.20.07.21.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 07:21:27 -0800 (PST) From: Tom Tromey Date: Tue, 20 Feb 2024 08:21:26 -0700 Subject: [PATCH v2 3/5] kfail a FinishBreakpoint test MIME-Version: 1.0 Message-Id: <20240220-py-simple-exc-v2-3-c672f1984b4d@adacore.com> References: <20240220-py-simple-exc-v2-0-c672f1984b4d@adacore.com> In-Reply-To: <20240220-py-simple-exc-v2-0-c672f1984b4d@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I noticed that one particular FinishBreakpoint test is only passing by accident -- the regexp is too broad and matches an error message. This patch changes the test to actually check what it claims to check; and then kfails the test because it doesn't work. I've taken this approach because this failure is only incidental to this series. Meanwhile I've filed a bug that I will leave open after this lands. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31391 --- gdb/testsuite/gdb.python/py-finish-breakpoint.exp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp index 45e2630337f..6b72ddb2186 100644 --- a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp +++ b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp @@ -73,7 +73,11 @@ with_test_prefix "normal conditions" { "check MyFinishBreakpoint hit" gdb_test "python print (finishbp.return_value)" "-5.*" "check return_value" - gdb_test "python print (finishbp_default.hit_count)" "1.*" "check finishBP on default frame has been hit" + # This test does not work and the result being checked for here + # used to match by accident. See PR python/31391. + setup_kfail "python/31391" *-*-* + gdb_test "python print ('HC=' + str(finishbp_default.hit_count))" "HC=1" \ + "check finishBP on default frame has been hit" gdb_test "python print (finishbp.is_valid())" "False.*"\ "ensure that finish bp is invalid afer normal hit"