From patchwork Sun Feb 18 01:10:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 85927 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 829763857011 for ; Sun, 18 Feb 2024 01:11:25 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id DC82F385E839 for ; Sun, 18 Feb 2024 01:10:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC82F385E839 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DC82F385E839 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708218613; cv=none; b=hzyH1veI6lx64cy36dzNVMoSfSW2VIyBVJQVegZgLAhGGwdp+AvIazems/mlvU1fCI/Uiou9Lvmak7/P4S24EwX1ggPyOi4886GyET1a/6kLH1+N7iL7DrrlmD6d/dPO19VY4N/19twY9rgu/8IFrvL5cxjLJ5PTGZ/9pTmQSfw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708218613; c=relaxed/simple; bh=c0Mef6NiKZg4mUEk/VvMtwh3Bs3gnsvF9gb63VGy7+k=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=vzeVNIg2A+cm71PHs7Tk/if870pXac9LfGBzd/8ZdOYQFSmKrrNC4XBkGkqtSNfhK1zZkP/AtOGkljUAuc6I2Ht6FylLe1rK6w9UXU0AviBIDDoiJoAPVs1aA2/WOfqYu9gHMUK+o4mK3z4hqt/kOI6RK72tT8gwEnLS2WzTCTo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5002a.ext.cloudfilter.net ([10.0.29.215]) by cmsmtp with ESMTPS id bU6urkwlUAxAkbVgzrxkoJ; Sun, 18 Feb 2024 01:10:05 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id bVgyr2qyR1SqmbVgzrfYv5; Sun, 18 Feb 2024 01:10:05 +0000 X-Authority-Analysis: v=2.4 cv=BeF70at2 c=1 sm=1 tr=0 ts=65d158ed a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=shbjjGfoNgC23kRWVzQA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qRMDOa6yD8JHmbl6uW0KT3xxOVQG+Z2ceIdPVSC6j5M=; b=bXcI4IFBZkLuT8tZtGTm5JtiMM 5eBidIUXQE2ojWk84u5AQ9lEl0r7fbLgE0Oxp3N9IByLv1XEOWQz/NzYdPP/Zvg9JoI7S9iDpTj+T 4zinYuopJif7Oliexnw7L55Hl; Received: from 71-211-170-195.hlrn.qwest.net ([71.211.170.195]:49770 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rbVgy-003IPy-1e for gdb-patches@sourceware.org; Sat, 17 Feb 2024 18:10:04 -0700 From: Tom Tromey Date: Sat, 17 Feb 2024 18:10:03 -0700 Subject: [PATCH 2/7] Remove unnecessary null check in lookup_minimal_symbol_by_pc_section MIME-Version: 1.0 Message-Id: <20240217-dwarf-race-relocate-v1-2-d3d2d908c1e8@tromey.com> References: <20240217-dwarf-race-relocate-v1-0-d3d2d908c1e8@tromey.com> In-Reply-To: <20240217-dwarf-race-relocate-v1-0-d3d2d908c1e8@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.170.195 X-Source-L: No X-Exim-ID: 1rbVgy-003IPy-1e X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-170-195.hlrn.qwest.net ([192.168.0.21]) [71.211.170.195]:49770 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKxDFP8Wvdg1hWnFxk0fHUtc5K9/CrdAElfMEo9uNlYgMHCJYHlZJDG0vEONTwmSSY6Sg1zr52jwuMJ+rGOnSAx/p9nBvJ/30jejbHKPIaYinN7BwvH+ 68jz6fH6KZMNN/bBUa+eR/MBiwVLwRLcgUcG+B/4NHFQCr26bV+s2Np5sBQ10JR3ZibLwTNj+fU9GRNK5oOwqklBT8Gn6TaKuzk= X-Spam-Status: No, score=-3022.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org lookup_minimal_symbol_by_pc_section asserts that section != NULL early in the function, rendering a later check (and comment) unnecessary. --- gdb/minsyms.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/gdb/minsyms.c b/gdb/minsyms.c index ffded3781c4..f63d0f4af61 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -876,13 +876,11 @@ lookup_minimal_symbol_by_pc_section (CORE_ADDR pc_in, struct obj_section *sectio continue; } - /* If SECTION was specified, skip any symbol from - wrong section. */ - if (section - /* Some types of debug info, such as COFF, + /* Skip any symbol from wrong section. */ + if (/* Some types of debug info, such as COFF, don't fill the bfd_section member, so don't throw away symbols on those platforms. */ - && msymbol[hi].obj_section (objfile) != nullptr + msymbol[hi].obj_section (objfile) != nullptr && (!matching_obj_sections (msymbol[hi].obj_section (objfile), section)))