From patchwork Sat Jan 20 18:23:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 84492 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 288EE3858439 for ; Sat, 20 Jan 2024 18:24:57 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id A3A533858C3A for ; Sat, 20 Jan 2024 18:23:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A3A533858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A3A533858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705775003; cv=none; b=OZwRKjKTKkSRTDLTRP3Z0UGhvk/TSII70FhucC1AQSBIO5kjPNY3RENLwexecq7q1qyaQRz9iA9y9XU6GXxmlz2W44v5ybVF//4usK3Sogh/wt84V1yMx2FCqt5VPiy0/A3sxt14Un1ulOxHhGrgtNEP9P0QzJb7PIM1hjk1RPQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705775003; c=relaxed/simple; bh=ryhf8U6LpQzwkQckPqxHDAX6YovuAk4tDCi9ojy3NkA=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=gD+ap3Fm2hP79r+JH5PHRz355seyEG1pG1rxfTTPZKPXVlyyPioyRiFEaWLhfO8PU8AbeI4x2y+adxotwFjhNNJcaHc0iQW48rA+2XGDQK990Mg5NIWZJRmLaXmqIlyHM3CDlPU4WB26NS8SzMgCaYIc8PJ8cBE2NMpccOEFli4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5006a.ext.cloudfilter.net ([10.0.29.179]) by cmsmtp with ESMTPS id R56urG1GIAxAkRG0IrhScl; Sat, 20 Jan 2024 18:23:38 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id RG00rKk30im6ERG00ry2G9; Sat, 20 Jan 2024 18:23:20 +0000 X-Authority-Analysis: v=2.4 cv=Qft1A+Xv c=1 sm=1 tr=0 ts=65ac0f98 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=r1LDTmaU-BkirJkVBcIA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XLqkGwk0S2FW4Nt8MRxPgKdzCfnI2xlRPv8wff0rtOs=; b=F6g+45/iGkk838rrBx/HHU6RZJ YwQnmgieRIrc4HgcWa/UAIvKAh373TCMib1Vy8HcjKk/St2UK+jchjYXPiROzyIgJ///9l5HFIZiW uSj8okDCovtNNHSienQTofnIa; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:47898 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rRFzz-0049D4-2r; Sat, 20 Jan 2024 11:23:19 -0700 From: Tom Tromey Date: Sat, 20 Jan 2024 11:23:17 -0700 Subject: [PATCH v2 06/14] Move scrollok call in register window MIME-Version: 1.0 Message-Id: <20240120-tui-regs-cleanup-v2-6-a3cccc6a3573@tromey.com> References: <20240120-tui-regs-cleanup-v2-0-a3cccc6a3573@tromey.com> In-Reply-To: <20240120-tui-regs-cleanup-v2-0-a3cccc6a3573@tromey.com> To: gdb-patches@sourceware.org Cc: Tom de Vries , Andrew Burgess X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rRFzz-0049D4-2r X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net ([192.168.0.21]) [97.122.68.157]:47898 X-Source-Auth: tom+tromey.com X-Email-Count: 20 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEuJJjv5IncvGMdP2lKfjAyDrwwgU3hVrgsyAtEpTFMerKpl3aQrI8q5I//5vgfMfiLaMmZrQB71znOd879Juzg4I9SZOG/ku8HNBsCe4ireWXnp/7N+ vYrw9k4VUqoGrFmA900NUI+JA3V4XdI8i2+eztXN556RVjeHviPwpHG05LRe/wG3VSYuFs9QZN8kEq5MOtwQHmRj5lctaDR9akk= X-Spam-Status: No, score=-3023.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The register window calls scrollok each time a register is written to the window. However, we only need to call this once, at the start of display. (We could actually call it just once when the window is made, but that would involve making another method virtual or adding a new member -- both which I think are worse than this approach.) Tested-By: Tom de Vries Reviewed-By: Andrew Burgess --- gdb/tui/tui-regs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index 12301552c34..eeea03f87c1 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -236,6 +236,10 @@ tui_data_window::update_register_data (const reggroup *group, void tui_data_window::display_registers_from (int start_element_no) { + /* In case the regs window is not boxed, we'll write the last char in the + last line here, causing a scroll, so prevent that. */ + scrollok (handle.get (), FALSE); + int max_len = 0; for (auto &&data_item_win : m_regs_content) { @@ -448,10 +452,6 @@ tui_data_window::check_register_values (frame_info_ptr frame) void tui_register_info::rerender (WINDOW *handle, int field_width) { - /* In case the regs window is not boxed, we'll write the last char in the - last line here, causing a scroll, so prevent that. */ - scrollok (handle, FALSE); - if (highlight) /* We ignore the return value, casting it to void in order to avoid a compiler warning. The warning itself was introduced by a patch