From patchwork Sat Jan 20 18:23:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 84487 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CD8A638582AF for ; Sat, 20 Jan 2024 18:23:55 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 59F443858D39 for ; Sat, 20 Jan 2024 18:23:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 59F443858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 59F443858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705775000; cv=none; b=annYtgtStkNkFV3uXWxNH0NYfJiFluj/GWUO897vkPYB59PiB3L53/k5+WBrPm9p62NfkcNdt881AHblcfHSgI2ug+pPRxJSA4Uvk0y17iDztXO/Bxxwjp/FkcqtLHZ/N6eCroa8Usk+egOvVdMrcvjOEn2UMomMcJPNCYCnP5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705775000; c=relaxed/simple; bh=H+5Q3Pf0K+Zt8DFvxsTVOd5/Pr8v9UQG8jY/QJiR9GM=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=QbZxHBfZJxP0/+MAeO5FSXPh+pHaOAHupmWX1nVHyw6GdNSU8p1KVYgfWf62A05vaqcITel/KGN/7gvsO2cxAer9+7hmc3KJqmA345dhuHgDO5QnlSNW1mpHpblYs1hn9nZuAOKCeXmcSFKdxql0z9U72L+2Kx2AG/I+Avxjirk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id RA18rZvlZ9gG6RFzzrvSX9; Sat, 20 Jan 2024 18:23:19 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id RFzyrA036WRcnRFzyryiWB; Sat, 20 Jan 2024 18:23:18 +0000 X-Authority-Analysis: v=2.4 cv=OPo0YAWB c=1 sm=1 tr=0 ts=65ac0f96 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=hVr_97Er9cj9lV5-WSwA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NL88E5v4U+mymawNA1uGxflGXnEpq+4rh1YPC94zZ4w=; b=jyzi23D6fH39TVCB+4MfJMLOLK iVg82tpc0VaPis9gEj1v7xm+2lVezihNy0RirWEso3muXP9Yal8xY6VzuU3R7jx+pXZZmR3i5gCR8 WSnRpzmcYq2u8b8c8UzJ0fh2n; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:47898 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rRFzx-0049D4-2g; Sat, 20 Jan 2024 11:23:17 -0700 From: Tom Tromey Date: Sat, 20 Jan 2024 11:23:12 -0700 Subject: [PATCH v2 01/14] Use pop_back in tui_register_format MIME-Version: 1.0 Message-Id: <20240120-tui-regs-cleanup-v2-1-a3cccc6a3573@tromey.com> References: <20240120-tui-regs-cleanup-v2-0-a3cccc6a3573@tromey.com> In-Reply-To: <20240120-tui-regs-cleanup-v2-0-a3cccc6a3573@tromey.com> To: gdb-patches@sourceware.org Cc: Tom de Vries , Andrew Burgess X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rRFzx-0049D4-2g X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net ([192.168.0.21]) [97.122.68.157]:47898 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGdveD59ZyOaTERTN8kIDdIypeerUH2TqmP75jtj7N3U4HfDeJHJB20zzfYjxfKeeLfECRD3RzP0ukh5FHp05QsVvOILKolSWkJEg20YRZ3ZT4pO1krb PItLlxKWHkWpICHWB9SIFXxvZpQ67GZByan6uGRX2JqkTXgolobrOEPETo+O2py0OiQlbE/4vpusxHrM4ORGpqRvSkM6CoLVc9g= X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org tui_register_format can use string::pop_back now. Tested-By: Tom de Vries Reviewed-By: Andrew Burgess --- gdb/tui/tui-regs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index 4a6696d99e7..590e9e81317 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -96,7 +96,7 @@ tui_register_format (frame_info_ptr frame, int regnum) /* Remove the possible \n. */ std::string str = stream.release (); if (!str.empty () && str.back () == '\n') - str.resize (str.size () - 1); + str.pop_back (); return str; }