From patchwork Thu Jan 18 20:32:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 84371 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 11D6B38582BF for ; Thu, 18 Jan 2024 20:33:57 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 5B0723858C2F for ; Thu, 18 Jan 2024 20:32:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B0723858C2F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5B0723858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705609935; cv=none; b=G0lDCHZhmt+2xFPei7hxWBiZxoCCg5cpP78osmnJzze6I6NJu60Xr4bn/3EOR0Jn920VXe9gycV/l5xnEt0QFHsHeVu20XofEYrviefVDOBsyACwPkb2E0gVMu7nL4qPbUVHLoyqfZFpZ1o55QbAt4vFgZ4UWMBsGwol7HiOuoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705609935; c=relaxed/simple; bh=nkm7PjJoBeFzefaCRQ27O2aKROgfjPgqHD72fuaAD7w=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=QCug+EHscHgR9UD6Bu+IdRSCtIn7+Wz//Qus94g2MOn3D7RWuarN7AWLM/bmc/O9A3TSb8D9tm/wgsNl4o21JjuJlXwmcd3VXfJvDMXWJcBd47emcbngx94AKgktqxT9Ccr0wHzFUMjkSuxYOqV7dqBf77OnWsZUC5keF4ZXrvw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTPS id QXSmrSdPaTHHuQZ3ar9Wwr; Thu, 18 Jan 2024 20:32:10 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id QZ3Zr1sUwV9xYQZ3ZrCTkh; Thu, 18 Jan 2024 20:32:09 +0000 X-Authority-Analysis: v=2.4 cv=NfP1akP4 c=1 sm=1 tr=0 ts=65a98ac9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=j2nSuGdwE-VHdcfjFbAA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qyRIJN0KBvkD6eKFh2XcbAyxxi+74ubBY62q46wRwuc=; b=WnDFYrCSXOEvR07WmMPgGtBSMv dExz0ADMbUKBQa/4AhsVH3tjWG2tluc1jVH4o0xnhoIx26Zi3sxEUNAO7dzLbEnKltuhJ8WQlhUsm FqV48XkDda/GMuuOdtRNGG0iX; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:50746 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rQZ3Y-002DCj-2C for gdb-patches@sourceware.org; Thu, 18 Jan 2024 13:32:08 -0700 From: Tom Tromey Date: Thu, 18 Jan 2024 13:32:05 -0700 Subject: [PATCH v2 07/30] Remove NR_DOMAINS MIME-Version: 1.0 Message-Id: <20240118-submit-domain-hacks-2-v2-7-aecab29fa104@tromey.com> References: <20240118-submit-domain-hacks-2-v2-0-aecab29fa104@tromey.com> In-Reply-To: <20240118-submit-domain-hacks-2-v2-0-aecab29fa104@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rQZ3Y-002DCj-2C X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net ([192.168.0.21]) [97.122.68.157]:50746 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEpzuecdhtE0BTQqm/dDSBc77x38VYD2CUUFhFjm+mN28Djx2/gOoOjzCleAlUnL08uFRm3TRvC3WZF6BzHQIj7qvsD9cK+s+blsmjDuSCIlsSX/P8Zf 9FYAqi27i4lKkvd7UUma2V185M17BZPemLCIdKdr5Ej5H+NgzlhvDFuFNYEiuaZ/gNN7PeRKSyjz0bgCEmdjSMPe5XmS0xXqDV0= X-Spam-Status: No, score=-3022.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org NR_DOMAINS is only used for a static assert, but we no longer need it now. If we add too many constants to this enum, GCC will warn about the bitfield overflow: error: ‘symbol::m_domain’ is too small to hold all values of ‘enum domain_enum’ --- gdb/symtab.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gdb/symtab.h b/gdb/symtab.h index eecd999b7e6..3f2d98add1e 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -922,15 +922,11 @@ enum domain_enum /* Fortran common blocks. Their naming must be separate from VAR_DOMAIN. They also always use LOC_COMMON_BLOCK. */ COMMON_BLOCK_DOMAIN, - - /* This must remain last. */ - NR_DOMAINS }; /* The number of bits in a symbol used to represent the domain. */ #define SYMBOL_DOMAIN_BITS 3 -static_assert (NR_DOMAINS <= (1 << SYMBOL_DOMAIN_BITS)); extern const char *domain_name (domain_enum);