From patchwork Thu Jan 18 20:32:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 84382 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6EE3C385840A for ; Thu, 18 Jan 2024 20:36:41 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 34249385840B for ; Thu, 18 Jan 2024 20:32:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34249385840B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 34249385840B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705609939; cv=none; b=k+uBJyYyoZzBAcosnKl/IpoewFhDu+4SnAsvdflltrUYYfmJU9EB68tiKAo06iaoBcFI7n+UFNQ6uCJ3vAs5c1rX9EG2vAjO+4q6gbHrswdPzldKWHgo4NXvzG7+Y7JJ4obtTmXHRFx3OXygyMDztwPI8ZI154rUr9YruDG5lMA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705609939; c=relaxed/simple; bh=AuxQEH8z3m7GWlxnPS3+5t44NK1io8aKAyEQOk/xXAk=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=UzchNBPMVP+DvkMygIJuRfVJGuDge9FQfVWny0qJz2G8uj0lLxZZRADxsOUQ2wjksIs1pPWvxh39s/VU2eGoMVkNJuZNidxdUkC3qJu4T15i87hl9/gR924djVj2AZOa7hIaSL8MG7DSqIYzd/jg58z8AjiwkRLfSJ2UZM9WBDo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTPS id QWgNrIHza8uLRQZ3crw3CD; Thu, 18 Jan 2024 20:32:12 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id QZ3brcvQXPwzWQZ3brqpLk; Thu, 18 Jan 2024 20:32:11 +0000 X-Authority-Analysis: v=2.4 cv=T8yf8tGQ c=1 sm=1 tr=0 ts=65a98acb a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=xBr83xsTwwIbWKOzC-sA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=H7HwQa+5ZZBGzk1TE+V9GuiHS665zCnpUkMdWe6sOuY=; b=p6flsg/14NNYIudPV1otOK/Zgs J/oEElkoyC6cW8Xe/mvaXZ67/gbfjeSP8DezRSZSdkM3fNF3RGVtsKzhO01KawTS+Pq59qbCHn6Ww UNeLw9F3+6E8RTR6PLJdU3RbF; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:50746 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rQZ3a-002DCj-2P for gdb-patches@sourceware.org; Thu, 18 Jan 2024 13:32:10 -0700 From: Tom Tromey Date: Thu, 18 Jan 2024 13:32:12 -0700 Subject: [PATCH v2 14/30] Remove a check of VAR_DOMAIN MIME-Version: 1.0 Message-Id: <20240118-submit-domain-hacks-2-v2-14-aecab29fa104@tromey.com> References: <20240118-submit-domain-hacks-2-v2-0-aecab29fa104@tromey.com> In-Reply-To: <20240118-submit-domain-hacks-2-v2-0-aecab29fa104@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rQZ3a-002DCj-2P X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net ([192.168.0.21]) [97.122.68.157]:50746 X-Source-Auth: tom+tromey.com X-Email-Count: 16 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfH1BuLF/b+3XF3/JXDNWWKi2K+mZmnVBUqV5vRE9SQdC6LImQrCLgFsDfrubI5O8Wjmji85DyHJBipzZKNmPIyyCgDnHMsk3xQIj9gojzplt2ZcYtNkr doZmFWdbEzgRpU4zOxSCB/PlGIrihrI5JvCLAaBKduv+KNpjvmYRBtr1ghg6aaVhueQoNLav05K2sRh73E+LUycgh6E3A9ywdb0= X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org completion_list_add_symbol checks that the returned symbol has VAR_DOMAIN, but also checks that its address class is LOC_BLOCK. The domain check is redundant -- only functions can possibly be LOC_BLOCK -- and leaving this in place will cause a regression when combined with a later patch in this series. This patch preemptively removes the redundant check. --- gdb/symtab.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/symtab.c b/gdb/symtab.c index 7c56dbadf8c..76a771b1166 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -5631,7 +5631,6 @@ completion_list_add_symbol (completion_tracker &tracker, the msymbol name and removes the msymbol name from the completion tracker. */ if (sym->language () == language_cplus - && sym->domain () == VAR_DOMAIN && sym->aclass () == LOC_BLOCK) { /* The call to canonicalize returns the empty string if the input