From patchwork Wed Jan 17 12:21:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 84249 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 640E03861800 for ; Wed, 17 Jan 2024 12:22:25 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id A21FD3858C2C for ; Wed, 17 Jan 2024 12:22:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A21FD3858C2C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A21FD3858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705494123; cv=none; b=YiKQntEKvSuG8Mxwr2bLU0UtppG8ijQp+JdrKvRjTkb9B6yZc1Na+Nqz5bn0UQ/amjmgeTFzD8vEQmf0L5FwjXCLRZM9YYqnADSd3cb9HO0e0Tx+7xWff62bBD5s9oGuqa0ZKwKFpinD8mxD2TAD8jBFRjZM7BEJnJUHCwNp+/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705494123; c=relaxed/simple; bh=7lhjrUDnvW9dz1Y2ycTSv5HA1XJLDCWAt6zULUy1erg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KiuqHTvRVKkLnQnE7T9LHSmi50RDX4jm8jwQc4R+CT4MJwv7hzQilr/M6qhqlR9wHFtz8BjZ4TYAzdZ1WmoWxB0x3xn23xa4mYILQc5jsNwuq9Qi1AhuX8fHSlQKQ+E09wEeGqt3LVTwelIOxFlXTrekx7e4A3kWprjb8ckldY8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-36082f3cb06so59491255ab.1 for ; Wed, 17 Jan 2024 04:22:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1705494121; x=1706098921; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=T/BCvc4TYowKV2XdyjES7wZVmpEIIh0oPem9Me3bw8g=; b=ccEI1eEl6Lsb3tpuPLuusAgse5YGGiaknIgrsgEcVyPaOlhSoKkTFJmKKqfy12JmHl +NNuQp4T9kAePA2QXs+XRzKFyai4UXDNsvjEOrXc0DgN0zqxec/MvZNB2l1cvGJ9uyZk XWpq0WEDcPB7p9U7wQN84EZ7K33M2TlQN4Q6J91ANqHJuxGF65zXLtjJQebtiQ1fGqsb lZ1zj2zsiOKrvn7Lj0hJSJwuGv2xSBJiXS50+7FpK5YlGg3k6i+JQpZn/EBKLqkA+sCn b/JL0v9nBs4v7GjSrKTRofDMIVGm7pbZBbxRIxfDsNm22uTaUxayjQrP4LD0gFkE1wrq Dfpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705494121; x=1706098921; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T/BCvc4TYowKV2XdyjES7wZVmpEIIh0oPem9Me3bw8g=; b=HBUwRX0jBjVv9J4VD2kmc4JKBcuUITFhBKuv6470VqbVV8wdgnlfwj02jJXSuYlrQ9 EvFC1+dl/karwChIW/1caVJwZNZGx7EEsqktPPOaQbSdd0BroU42L+L9Ux4tAfzDvEGx CC/661K49RygVvGQrS5FpaLGUyqbdVEqLbkh7YShMUPbXEL/Oao7UfMvXrf7xq90b8bt OzID3k0fY9sDIoxdorrpbL/FPs2o4jisDDxVxhndq9lVdiUNLhGHaF4c6uyTTmSic7Gs E46VcWvNYGK13g12Fa92Hcx624ZfYFsACBnIgC6pilpc+jA+6MpzWWV5WVsWLIDwr0lG IFcg== X-Gm-Message-State: AOJu0YxYQPCCXcNIr7RVLefVqLl/gcDDCqj+efzALsc3hGPIZcATpae8 avF+ZdPkq7Bjkr/6o1K9o+U8C+A5C518rO51xRdxSsircA== X-Google-Smtp-Source: AGHT+IGDvZrQkxQbTeMKVCG9vH2aE2WFkdUpoYIIbwPDwPp3gZbHKWCt7pWKKm56DzHZ8VLOw2q+LQ== X-Received: by 2002:a05:6e02:eca:b0:35f:ed80:9c7b with SMTP id i10-20020a056e020eca00b0035fed809c7bmr9042079ilk.44.1705494120859; Wed, 17 Jan 2024 04:22:00 -0800 (PST) Received: from localhost.localdomain (97-122-68-157.hlrn.qwest.net. [97.122.68.157]) by smtp.gmail.com with ESMTPSA id p16-20020a92da50000000b0035fd0a61f5fsm4172878ilq.49.2024.01.17.04.22.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 04:22:00 -0800 (PST) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Fix handling of DW_OP_GNU_push_tls_address Date: Wed, 17 Jan 2024 05:21:54 -0700 Message-ID: <20240117122154.2880311-1-tromey@adacore.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org In one spot, DW_OP_GNU_push_tls_address is handled differently from DW_OP_form_tls_address. However, I think they should always be treated identically. --- gdb/dwarf2/loc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/dwarf2/loc.c b/gdb/dwarf2/loc.c index 062bd12909f..6cc9cc62650 100644 --- a/gdb/dwarf2/loc.c +++ b/gdb/dwarf2/loc.c @@ -1955,12 +1955,12 @@ dwarf2_get_symbol_read_needs (gdb::array_view expr, case DW_OP_lt: case DW_OP_gt: case DW_OP_ne: - case DW_OP_GNU_push_tls_address: case DW_OP_nop: case DW_OP_GNU_uninit: case DW_OP_push_object_address: break; + case DW_OP_GNU_push_tls_address: case DW_OP_form_tls_address: if (symbol_needs <= SYMBOL_NEEDS_REGISTERS) symbol_needs = SYMBOL_NEEDS_REGISTERS;