From patchwork Fri Dec 29 10:41:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Natalia Saiapova X-Patchwork-Id: 82998 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 09180385841F for ; Fri, 29 Dec 2023 10:44:03 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by sourceware.org (Postfix) with ESMTPS id 7768F3858403 for ; Fri, 29 Dec 2023 10:42:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7768F3858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7768F3858403 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=134.134.136.126 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703846570; cv=none; b=pPOz48JfLVVfojP0pRMQkndaFvCfsagnl4EVVDr5WzIbiDc4cUJsCgFDSplE+Yn9GsKWQuwyIS42ML8j3dGq8Tyj56RMfmQdSYpqSOUY8U0a5AocUYEM93Z3kVq85yegWQ4PJSXkel66MMHQ/D7ZMvYmFZIN9Od4jctWEkhLw0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703846570; c=relaxed/simple; bh=W1uarJYGjqAAPCn1vZ3ni2pWeizVTYpvLYVrUSDisCo=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=sXOQVKbVHFxmG5L73g/mEg7HMiiazSTz858jjcub7tLdh1/421YopGgJ9XH+CAZ73xGdNHZxz7tCeuJP/Xa2tzSuoxjOGr6Nlvp3i9gqXkMO1ujG2jHNHzPdrhYEtNzVQYDYDtEsASayr/7s4aSCeRAPdcrMsSpkFSbYUcAxUMk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703846564; x=1735382564; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=W1uarJYGjqAAPCn1vZ3ni2pWeizVTYpvLYVrUSDisCo=; b=jW3SA7LtFF+EEL4hvmzO/zeSaoPaEkYlLHQfRQWhhehqmnZYiH7AVv2H mZSvuP4FeUCnHCGfv33BL5tfceqG7SK1l0d0mAJCRxLaQzqCQVXJEV4rq cokIT0fLv73QHavHhGdUsD4ShHhwItPt3Cya1jpy36U1HOvYfV8uW8pUp e7Jw/Hnl0Q08dUwfKWid0Rxi4Sgaky1rzrYWh0zveaZvpSDrSdOiTQYwA /NEkTZVM0JJZi0AjFkQyJesj+Xd/1Nx6QcKLYwOw+dLivGWIH+y9VuyOO EwmL4SSObfWu6wmlVhN/0P5En2k0C/MPAN6ptec3eIBTKaQe4tyH+yger A==; X-IronPort-AV: E=McAfee;i="6600,9927,10937"; a="381613094" X-IronPort-AV: E=Sophos;i="6.04,314,1695711600"; d="scan'208";a="381613094" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2023 02:42:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,314,1695711600"; d="scan'208";a="27111955" Received: from unknown (HELO localhost) ([10.211.177.238]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2023 02:42:43 -0800 From: Natalia Saiapova To: gdb-patches@sourceware.org Cc: tankut.baris.aktemur@intel.com Subject: [PATCH 2/6] gdb, cli: remove left-over code from "set_logging_on". Date: Fri, 29 Dec 2023 10:41:58 +0000 Message-Id: <20231229104202.7878-3-natalia.saiapova@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231229104202.7878-1-natalia.saiapova@intel.com> References: <20231229104202.7878-1-natalia.saiapova@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This is a refactoring. Remove the left-over code, which rewrites the logging filename in "set logging on" command. The code became unused after the deprecation of "set logging (on|off)" command. Before the deprecation, the command could also take a file name and rewrite the logging file, e.g.: (gdb) set logging on lalala Copying output to lalala. Copying debug output to lalala. After the command was deprecated and reimplemented as an alias to "set logging enable on", additional input after "on" became invalid: (gdb) set logging on lalala Warning: 'set logging on', an alias for the command 'set logging enabled', is deprecated. Use 'set logging enabled on'. "on" or "off" expected. (gdb) set logging on lalala "on" or "off" expected. (gdb) set logging enable on lalala "on" or "off" expected. (gdb) set logging enable on Copying output to gdb.txt. Copying debug output to gdb.txt. --- gdb/cli/cli-logging.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c index a74e43034e8..e2ce0262538 100644 --- a/gdb/cli/cli-logging.c +++ b/gdb/cli/cli-logging.c @@ -160,11 +160,6 @@ handle_redirections (int from_tty) static void set_logging_on (const char *args, int from_tty) { - const char *rest = args; - - if (rest && *rest) - logging_filename = rest; - handle_redirections (from_tty); }