From patchwork Thu Dec 21 19:16:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 82691 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AD36838497B6 for ; Thu, 21 Dec 2023 19:17:32 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 063CA385842B for ; Thu, 21 Dec 2023 19:17:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 063CA385842B Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 063CA385842B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703186240; cv=none; b=IwuvPeRLxuYdQqLlmf5I6tZJgR3RN5KOrCjA3KsbnJTvP7sNSmdgEcGEkCmob3Hp7znxJJmGmJbWdu/Bq2i5UTJ1dIcY+fF8szWFJq2wX+W8cT3zd7rm0jGdJB3FUjXzAx3/dTRrhhk0G+eVw1etGRuW9mMtX15j8wI5HQgjsxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703186240; c=relaxed/simple; bh=/wg8SS782kb7Png+pqs0/XyfiVOVtOrMCClrSyaClIw=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=YEp2hLyLfmKjwU4fiBL7I5bS/hD6BW3aWZCF+CzizmBK9HSPMZBfoDqoejrhBQ2EtUKk/KjqyalcOy2VskGufxhJalqE5LnGUkf0bR65HRgsa+tYg71sTp2ZYIVj8JC4LnhTQQoEuj6wVxKRgc1kcuoHvJMGS4TJyKo5FzI2MRk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smarchi-efficios.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 45C561E0BB; Thu, 21 Dec 2023 14:17:18 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 1/9] gdb: don't set frame id after calling cooked_read_value Date: Thu, 21 Dec 2023 14:16:22 -0500 Message-ID: <20231221191716.257256-2-simon.marchi@efficios.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231221191716.257256-1-simon.marchi@efficios.com> References: <20231221191716.257256-1-simon.marchi@efficios.com> MIME-Version: 1.0 X-Spam-Status: No, score=-3496.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I don't think that setting the next frame id is needed there, all code paths in cooked_read_value do set it properly, AFAIK. Change-Id: Idb9d9e6f89c2c95c5ebfeec2a63fde89ed84cf3d --- gdb/sentinel-frame.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/sentinel-frame.c b/gdb/sentinel-frame.c index 3e5b9be2edf6..9a9e4c29198e 100644 --- a/gdb/sentinel-frame.c +++ b/gdb/sentinel-frame.c @@ -54,7 +54,6 @@ sentinel_frame_prev_register (frame_info_ptr this_frame, gdb_assert (is_sentinel_frame_id (this_frame_id)); value = cache->regcache->cooked_read_value (regnum); - VALUE_NEXT_FRAME_ID (value) = this_frame_id; return value; }