From patchwork Sun Dec 17 06:52:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaydeep Patil X-Patchwork-Id: 82328 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2547A3858011 for ; Sun, 17 Dec 2023 06:52:56 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) by sourceware.org (Postfix) with ESMTPS id D45F53858D39 for ; Sun, 17 Dec 2023 06:52:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D45F53858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=imgtec.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=imgtec.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D45F53858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=91.207.212.86 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702795963; cv=none; b=ekNbAzRUl6VfDVNccI9zdZYQOrg4T4H7O73Q1SoYb5PCtF+sQyL7wc5a8M7fhQW6Juc8+JSffI40ejVrorqD0tlP2lXaHqSDWkucr/ygkzbWBK3sWSx7kccNjZJG8r5RPF1GWZ6sNULuY2BpAYMyJfwisYkZNjgHP/l1nYQ8brw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702795963; c=relaxed/simple; bh=WN1eDb5lQZDUdQAHgoMblMil/DTQMOFbCZqnHC/Bwss=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YDtiLzQ31w4PabaIzsEHxicvOB9+P2nA7q0zbmJK08RWLX26wLFm83tlD9HV8/tT4HxUHMuL8nNOG1vFs8QDEH+ZAxJlOsYVjihtrIzFCvF4zy0dDxNnRo+hThRanH57n7FHMEPbY+2I++VDvTLLn3LyUxXgMdVq42r7NikIWr4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BH6lrRZ009683; Sun, 17 Dec 2023 06:52:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= dk201812; bh=CQWniQh+QXDXnsC7L8gsoEtSF0AmSL2Dm7jk4rAicOI=; b=lhj TK+rAHbhST3vYnbOI+SChWV2I2+vVh3CpzCneLlJ9aTo8Rt/RKMITWB6rdvb2eJb 0G01TaLrlUY8KE5U1D5rah2cKCFAH2LELwnmIVFML3rh1JBZGIFNLVXDERrpve/j l2+jSuImGVRtOfW2mF9Z7fDKHOKFrQSTG2dbv0ICruXUyJ2JNmmB4Fl1N0Y3WQri zB+DdplKTX1fn86mHX7rjs8s5wwlagkY4x01n6/bf/VejpCuptHeXr6fYtbddBhN Xk8W2A3WE0LytRxdjm9GW+nU0CLn1vkcHGx3N0+CJZZJgNc9g6v+wt05sbBpcYpJ ORXlmJr8At8o11a2biQ== Received: from hhmail05.hh.imgtec.org ([217.156.249.195]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 3v131s0mja-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sun, 17 Dec 2023 06:52:30 +0000 (GMT) Received: from hhjpatil.hh.imgtec.org (10.100.136.70) by HHMAIL05.hh.imgtec.org (10.100.10.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 17 Dec 2023 06:52:29 +0000 From: To: CC: , , , , Subject: [PATCH v3 1/3] [sim/riscv] Fix crash during instruction decoding Date: Sun, 17 Dec 2023 06:52:16 +0000 Message-ID: <20231217065218.3799535-2-jaydeep.patil@imgtec.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231217065218.3799535-1-jaydeep.patil@imgtec.com> References: <20231217065218.3799535-1-jaydeep.patil@imgtec.com> MIME-Version: 1.0 X-Originating-IP: [10.100.136.70] X-ClientProxiedBy: HHMAIL05.hh.imgtec.org (10.100.10.120) To HHMAIL05.hh.imgtec.org (10.100.10.120) X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631 X-Proofpoint-GUID: lwv5N04SxS8pW2yqbuzJ0WncMzs-GsQ4 X-Proofpoint-ORIG-GUID: lwv5N04SxS8pW2yqbuzJ0WncMzs-GsQ4 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org From: Jaydeep Patil The match_never() function has been removed and thus step_once() crashes during instruction decoding. Fixed it by checking for null pointer before invoking function attached to match_func member of riscv_opcode structure. --- sim/riscv/sim-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c index afdfcf50656..8a23d2aa1f9 100644 --- a/sim/riscv/sim-main.c +++ b/sim/riscv/sim-main.c @@ -1041,7 +1041,7 @@ void step_once (SIM_CPU *cpu) for (; op->name; op++) { /* Does the opcode match? */ - if (! op->match_func (op, iw)) + if (! op->match_func || ! op->match_func (op, iw)) continue; /* Is this a pseudo-instruction and may we print it as such? */ if (op->pinfo & INSN_ALIAS)