From patchwork Sun Dec 17 19:50:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 82354 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 43CC938582BA for ; Sun, 17 Dec 2023 19:51:59 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id B01BC385841D for ; Sun, 17 Dec 2023 19:50:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B01BC385841D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B01BC385841D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702842633; cv=none; b=dTII9OCKEgF0JqnEIwVoLkFyykoLNS9Iy67Cilmu0tuEqP89Ldv+lUzsDfR4ZxYTeLL0tzgIMamFvOvSR5izvn4Eb1iFBl1QEU8STSOBcJr/YSdTGxiVYpJrXW2H+HHVbqm25RDUBxfOsv1GJwnYxFmdCORtjbM0tSxAOqrnSE8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702842633; c=relaxed/simple; bh=CThhGGkWU7dxmPBPAbReW8tJXgAqE6JfdxPixWjmlHI=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=cMi2lQMa6I0QIzZYW7C9dDyMGHyb6iO2NQ2mQT7Y1KkNRWNn6KYscQ5zycQ/Yle/g5Z9cVRMFMj63CH8WbU2lqsLPDMmyDZZ/f/Q9pNrJaS/w0AtQFk6YeW0asdqN4rPT/jJPoaEcoJm06177+11Zd/zvflPU4DljSWqWD9B3cQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTPS id ErUurzjl1WcCIEx9irQEBp; Sun, 17 Dec 2023 19:50:30 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Ex9hr9fHO97pzEx9hryMbf; Sun, 17 Dec 2023 19:50:29 +0000 X-Authority-Analysis: v=2.4 cv=ULDOoQTy c=1 sm=1 tr=0 ts=657f5105 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=r1LDTmaU-BkirJkVBcIA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BFumwIIs9jEoZM83Kf20vx6pPMY4rLFzrBwtRzTcuHw=; b=RUC1TaYu0g7935beJ0kv4HRIYR qSnRC/zk+mR7/m+XEOM69lguNnBI4qFL+laFWjg9ld1UKHcW+6Vy012Ox3I+/pxvlqHNvA9oaqrqe CXNcfw5pLgJ5Q9KpLdcWnbes9; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:40716 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rEx9h-004MyY-0C for gdb-patches@sourceware.org; Sun, 17 Dec 2023 12:50:29 -0700 From: Tom Tromey Date: Sun, 17 Dec 2023 12:50:31 -0700 Subject: [PATCH 06/14] Move scrollok call in register window MIME-Version: 1.0 Message-Id: <20231217-tui-regs-cleanup-v1-6-67bd0ea1e8be@tromey.com> References: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> In-Reply-To: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rEx9h-004MyY-0C X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net ([192.168.0.21]) [71.211.161.25]:40716 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDmC23CQIoAWmmTcamYAWPp9tO8o8JgBEPXTLE5ZVUwPCPlKGlqZ5a0XVIkO3EL5xP8X/Bb8063T8WZu44Pkqy3V5faKRv8ee6GDY+UAdSm/fMeMMw+C N5mjs4d7NNsJKxrsE3w3a3r5eA2/Wq5vA9/agzv+BinIk2hdwd8VUVKLJ8xwN3bPzJxTYTR5T70/wFpG6pgTCb5hYYfoGOf0XYk= X-Spam-Status: No, score=-3022.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The register window calls scrollok each time a register is written to the window. However, we only need to call this once, at the start of display. (We could actually call it just once when the window is made, but that would involve making another method virtual or adding a new member -- both which I think are worse than this approach.) --- gdb/tui/tui-regs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index 9108e460d6f..0ad23e93778 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -237,6 +237,10 @@ tui_data_window::update_register_data (const reggroup *group, void tui_data_window::display_registers_from (int start_element_no) { + /* In case the regs window is not boxed, we'll write the last char in the + last line here, causing a scroll, so prevent that. */ + scrollok (handle.get (), FALSE); + int max_len = 0; for (auto &&data_item_win : m_regs_content) { @@ -449,10 +453,6 @@ tui_data_window::check_register_values (frame_info_ptr frame) void tui_register_info::rerender (WINDOW *handle, int field_width) { - /* In case the regs window is not boxed, we'll write the last char in the - last line here, causing a scroll, so prevent that. */ - scrollok (handle, FALSE); - if (highlight) /* We ignore the return value, casting it to void in order to avoid a compiler warning. The warning itself was introduced by a patch