From patchwork Sun Dec 17 19:50:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 82345 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 25ADA38582B6 for ; Sun, 17 Dec 2023 19:51:02 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 721A63858C42 for ; Sun, 17 Dec 2023 19:50:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 721A63858C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 721A63858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702842631; cv=none; b=OSUpOMg32IZ9BKYzVbrdlXKJBX4yQ/Ok1iTspg09kYu+XUBgpRxRup8X8JumABf5gmJM/1ce23chgtPsoQo8Rj2ZtjjOIAHAWQX6lYubGW6A6GNHfCFnLQQg4+8UtDKKV8aUjGuLNMnD2h5Un1MYef/2HY3FrNxN8ef3RdTzCHc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702842631; c=relaxed/simple; bh=4Lm2er4kMg+Lc6NprM8uX4XENR7AySUfpbowy5m3x3Q=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=D1Dpuxq1+tfTfewkR1898+/LlKjZE+T1+sjqTLRE0Sl+kPG5c1PH2IMIuM8MdPibbzsTsAX5/EoW8zubifDMIu0BEXrkcgHX2ibjq0cFMzCvIevD5vgkhDTgk9E+aHoDP0BBjDPOshl1BTZuBDMYqRLeolfBlb4iiggZnszy/Jk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6009a.ext.cloudfilter.net ([10.0.30.184]) by cmsmtp with ESMTPS id EqAgrbmbQ8HteEx9hr8G0m; Sun, 17 Dec 2023 19:50:29 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Ex9grXMZhBOccEx9grZZFp; Sun, 17 Dec 2023 19:50:29 +0000 X-Authority-Analysis: v=2.4 cv=J+25USrS c=1 sm=1 tr=0 ts=657f5105 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=KTarSb8FPFGiWbvvr6AA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8m9ckqmewO0WRJYtwC2OUK3N3OB1COLxCTJT1mNyu0c=; b=qwlqbwFj16j90evrVcZBUXv4C4 KxUnESE5R1oLb2BsnjhFE//Ra3OYg+ola4DkeGguHzJzbuuck6GfhjG+jh+JSLw0ixe7Ytn/2YUgW eKvxABFei7qetY9gjaWRIJp/Q; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:40716 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rEx9g-004MyY-1i for gdb-patches@sourceware.org; Sun, 17 Dec 2023 12:50:28 -0700 From: Tom Tromey Date: Sun, 17 Dec 2023 12:50:27 -0700 Subject: [PATCH 02/14] Minor C++ cleanups in tui-regs.c MIME-Version: 1.0 Message-Id: <20231217-tui-regs-cleanup-v1-2-67bd0ea1e8be@tromey.com> References: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> In-Reply-To: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rEx9g-004MyY-1i X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net ([192.168.0.21]) [71.211.161.25]:40716 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfD+ftO7MiWJbJ80mjbGOWXi7I37Sq2ViiACV9CW4fAzr6VCVDtn3OR8j9SfAp6Uk61fpVjdwd272a3XvttFU1Hto6XB8B5zSx6fbF6hzHnob7bDaPtbp UlZNuQTMAcolo2HCA8ehb4csdbxdju++6qx5/REgZ9u8khd0Bb4WHsgwybZfbS3qBPO/y7jOVUntU8olwJqwRSmggJko+5xt5EU= X-Spam-Status: No, score=-3022.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This changes a couple of spots to use nullptr rather than 0, and changes an int to a bool. --- gdb/tui/tui-regs.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index 6aabae23e69..91fbf75c250 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -173,7 +173,7 @@ tui_data_window::first_reg_element_no_inline (int line_no) const void tui_data_window::show_registers (const reggroup *group) { - if (group == 0) + if (group == nullptr) group = general_reggroup; if (target_has_registers () && target_has_stack () && target_has_memory ()) @@ -188,7 +188,7 @@ tui_data_window::show_registers (const reggroup *group) } else { - m_current_group = 0; + m_current_group = nullptr; m_regs_content.clear (); } @@ -472,9 +472,7 @@ tui_data_window::check_register_values (frame_info_ptr frame) { for (auto &&data_item_win : m_regs_content) { - int was_hilighted; - - was_hilighted = data_item_win.highlight; + bool was_hilighted = data_item_win.highlight; tui_get_register (frame, &data_item_win, data_item_win.regno,