From patchwork Sun Dec 17 19:50:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 82351 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5927A3858012 for ; Sun, 17 Dec 2023 19:51:44 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 42C0D385842E for ; Sun, 17 Dec 2023 19:50:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 42C0D385842E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 42C0D385842E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702842633; cv=none; b=xLwZkbGdeNJdzvIl4OZBPGJ/qQ9xbIRaxKO8/vlmcoEL77YPMSSH4AykCQ3qPzErC5GrcVZGaJCkGnavtt81PfDfRbxQ9ft1AXDnMRnd/Yx31X7K2FzVeP2J8XyZOiyTzR9B/6W7+4oKFWGeUpHNBVkdMgvRZGKSGVcwR84Z45M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702842633; c=relaxed/simple; bh=iC+fEAAQ+Fum4ouu3KIh0dcOc3co2GqQflfLg1WSly8=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=lj6uz+sUii88XsHcKk15aFfn5+DT3j2zlJI9RcDB6qyIW83g55AjHmOijxSwbS0DZwaZxl5FcLxRA+/QQJ/oY06AkK4Zz0QSbSYegqdrW+B+o0ArqFbaGB9/UcYd44GsFujrFfrEMTNzUPrfE1M4fZptZzRHbE0+wteByRCzDGk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTPS id EtKCrcFcQ8HteEx9ir8G0y; Sun, 17 Dec 2023 19:50:30 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Ex9irfL0g0xkrEx9irQ2O2; Sun, 17 Dec 2023 19:50:30 +0000 X-Authority-Analysis: v=2.4 cv=N7U6qkxB c=1 sm=1 tr=0 ts=657f5106 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=78A9mZFNi132CAqi_5sA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=b5XEY9mhCuwHiNN8I/cWFAv2DqdNS8hDf+ny3m9wKcA=; b=Dw1kPWMyZl12tFvc8lxayo4LOB cfywQFfhmOHDEkJDaR0g1UBSrQj3ePuai35ndC221ryhm+JoEsQjgxwQ0/zXrqsHqrSBhy2X9PEed O9zzI3kWraV2mO4HC8Txf68xe; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:40716 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rEx9h-004MyY-2q for gdb-patches@sourceware.org; Sun, 17 Dec 2023 12:50:29 -0700 From: Tom Tromey Date: Sun, 17 Dec 2023 12:50:37 -0700 Subject: [PATCH 12/14] Return void from tui_show_frame_info MIME-Version: 1.0 Message-Id: <20231217-tui-regs-cleanup-v1-12-67bd0ea1e8be@tromey.com> References: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> In-Reply-To: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rEx9h-004MyY-2q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net ([192.168.0.21]) [71.211.161.25]:40716 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMeVNVF3AntE5Sc8mDTQo+QRYbRKt/pca7ILWuSkLfDakaik8olPGclCR+ckDEUuO2hrVqEA6/I1edehO8HPgrRhbpSMXZCpwpF2ZJ0hv4I3ockudcwM ycYu+/1/nBhUuufop8tnz16LLY9QT/xN48LDn/fFDnX1n9Iu/MNGjdQ1NWk7eJ1UzqqDvTL+gtVqJVeHZrFrRFk6XTB4q9arPhk= X-Spam-Status: No, score=-3022.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Nothing uses the tui_show_frame_info result any more, so change it to return void. --- gdb/tui/tui-stack.c | 16 ++++++---------- gdb/tui/tui-stack.h | 2 +- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/gdb/tui/tui-stack.c b/gdb/tui/tui-stack.c index 8bf65ea3556..f40948b2305 100644 --- a/gdb/tui/tui-stack.c +++ b/gdb/tui/tui-stack.c @@ -262,13 +262,11 @@ tui_locator_window::rerender () wmove (handle.get (), 0, 0); } -/* Function to print the frame information for the TUI. The windows are - refreshed only if frame information has changed since the last refresh. +/* Function to print the frame information for the TUI. The windows + are refreshed only if frame information has changed since the last + refresh. */ - Return true if frame information has changed (and windows - subsequently refreshed), false otherwise. */ - -bool +void tui_show_frame_info (frame_info_ptr fi) { bool locator_changed_p; @@ -292,7 +290,7 @@ tui_show_frame_info (frame_info_ptr fi) not changed. If frame information has not changed, then the windows' contents will not change. So don't bother refreshing the windows. */ if (!locator_changed_p) - return false; + return; for (struct tui_source_window_base *win_info : tui_source_windows ()) { @@ -307,13 +305,11 @@ tui_show_frame_info (frame_info_ptr fi) locator_changed_p = tui_location.set_location (NULL, sal, ""); if (!locator_changed_p) - return false; + return; for (struct tui_source_window_base *win_info : tui_source_windows ()) win_info->erase_source_content (); } - - return true; } void diff --git a/gdb/tui/tui-stack.h b/gdb/tui/tui-stack.h index ca95b2bf78a..3f71a4165de 100644 --- a/gdb/tui/tui-stack.h +++ b/gdb/tui/tui-stack.h @@ -51,6 +51,6 @@ struct tui_locator_window }; extern void tui_show_locator_content (void); -extern bool tui_show_frame_info (frame_info_ptr); +extern void tui_show_frame_info (frame_info_ptr); #endif /* TUI_TUI_STACK_H */