From patchwork Mon Dec 4 16:00:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 81290 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E43A385802A for ; Mon, 4 Dec 2023 16:01:06 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by sourceware.org (Postfix) with ESMTPS id 41F6D3858D28 for ; Mon, 4 Dec 2023 16:00:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41F6D3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 41F6D3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701705653; cv=none; b=lYlkrWy0MtwfWMjMcny/xktPFJ3e+InM0xJRfexxVuwq6Wbn6lbJ/W8Hi2XSnteSfv4AOb5bUjL1v0Mr4b22IgvXy+meKrWTkvJmtKXiWXS1b4P441tP5evkrDMvEN6d4Z+FAVJGb5IRVILRcPA0QuGNMPvcohQI6wQ9AvlGWSU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701705653; c=relaxed/simple; bh=pHjU++GnZ/n6P4mPPEzWjPnsr3yzoq6KGaBq7EN9OdI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Puk2pEMvneUupisDQfeAQHrC53Q+E8soq73r9CibZv6sSjbrQA/1DsxJCthuR9wHWkvKIdh9zYGGw6FiJraU//5U5kxCbBmBjlSI07ALLBaAV/Mr+E1PV/AUOcG/CT/DSWpjdqTFEyWobY1J9bATr8lNmgXhyLwub/V64aKz1tQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-7b42900b7acso103391639f.1 for ; Mon, 04 Dec 2023 08:00:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1701705651; x=1702310451; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=W9fyOO/r3N1rG1OZUd3PM5Is0eCmgC5En0Xnu+zmWIs=; b=B1fw3eCqoRSMEqn6hmxT+DdyqVIG45wDUktaWgvt6/8l+OFU88pRy7yqYH3UrWiAEX Ic4kIzv8kO9SvpYNLFm3h8rlxHUMLeYrVVs0ayV0TUpEuUYYiU2+ePBPSGyiqqeadg7m P4Gg2CX4dD9yNyPdOxIlbMvkTmCxQjAw56xJDMlErCCjZ1+ts7GdrkyzZtbCq6glRiCp azuXXhNaU5mZIA6WK//e5CrOwEtSivXtNw9+R7zqmbVAijQnXBYIu/K4x1kT0fQYRaU7 dOy5QKYqZzdM6UJxk3hHviS5L6GEGN04+2V3zc88q1OjJbGLEg9GWoex1YKqH89HYJtl Hdig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701705651; x=1702310451; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W9fyOO/r3N1rG1OZUd3PM5Is0eCmgC5En0Xnu+zmWIs=; b=bZ6kuJYf0LSJZICGGnVAFquwh8/pB0EsxOibsVXsaW69BPQ3pAWZ8xzjrzPVmvo2B2 m6L3J6XLEWvvkZvRa/niwGSbn9QN+S9rKTV52H3lbLtl83sp21r5KnUWrOqdXARHBojG an8CMUDYfbRoIktyrPPgMkhBBQIxMB/uJZDoxeDOju5UFUNL3vHMSH103pZEVVRivy9H eMnq5uVHmwBaybwGRGo9GcmzvzVSH4x2vLQh0rnQVuFERDG6XrMi5T9B6zfOaG/jM9po et6NuBGOYW9aHaVcyGzqu4cYmbnuY4/pNM/yt9fG6HpQUez4byCysntQ3iu1kCElLK1u wIfQ== X-Gm-Message-State: AOJu0YwKdVWYnJp+WdGkGl6mMpSj6cjorl313nc3l4q/JEG/Ddm1fbtH olacX82+j+9JLvGOmxywPIVrypRZF3XG+HTZnV4= X-Google-Smtp-Source: AGHT+IETFHBwHwTpRRpvzpQZYRrYyH74JcZ0yEB25IXXHYJRzT4wOoKUA3pL1o+g0shjaMLCalSL8g== X-Received: by 2002:a5d:835a:0:b0:7b4:37db:9fe0 with SMTP id q26-20020a5d835a000000b007b437db9fe0mr3327400ior.27.1701705651275; Mon, 04 Dec 2023 08:00:51 -0800 (PST) Received: from localhost.localdomain (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id ft18-20020a056638661200b004667eb7fd91sm2617504jab.101.2023.12.04.08.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 08:00:50 -0800 (PST) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Remove incorrect "fall-through" comment Date: Mon, 4 Dec 2023 09:00:41 -0700 Message-ID: <20231204160041.3824884-1-tromey@adacore.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I found a "fall-through" comment in gdb/remote.c that was incorrect -- the code here cannot in fact fall through. --- gdb/remote.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/remote.c b/gdb/remote.c index 8ccc1266073..84daa8567b6 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -10044,7 +10044,6 @@ remote_target::putpkt_binary (const char *buf, int cnt) rs->buf.data ()); continue; } - /* fall-through */ default: remote_debug_printf_nofunc ("Junk: %c%s", ch & 0177, rs->buf.data ());