From patchwork Sat Dec 2 14:16:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Arsen_Arsenovi=C4=87?= X-Patchwork-Id: 81202 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8E144386183D for ; Sat, 2 Dec 2023 14:59:39 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [IPv6:2001:67c:2050:0:465::201]) by sourceware.org (Postfix) with ESMTPS id 88BF33858C98; Sat, 2 Dec 2023 14:59:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 88BF33858C98 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 88BF33858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2050:0:465::201 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701529162; cv=none; b=u1c3SFo8k5z18f0vmqH90MNqcjRBl/fo6B2gdhCCsQYbbs3pv2tXqeZ49UKhcubilc0NqMjkNtVKlK2kkNshohJLhDgdSXx48eOIsdL2nt8Iw2XqZ29HAtCA4+5WzTfsFpzxu+TeBh+7bqV1SI9L/WFC9yZvRNS2/vUDf1JkuNw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701529162; c=relaxed/simple; bh=R1SC6dgEySE+W3pkrGQYN+sjqiQBFmDt2qCsmFneYvw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FD6Bz4Gvv8nvuSOepwJUiD00b5t0XPOox4BQaTKRFkRCmMeqWD1blKUCfj/G6NRZvGmYFcpqZvvyNmLxMxchB3LalSAELjC7yQkiIAjH/0zwizrYnzD7lu9VN/W4+3l9IHXSY99smE/mL4q1JiL5fgsUpP5ZwQhqRhyNfqVyVLM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4SjCkX4PmQz9sjB; Sat, 2 Dec 2023 15:59:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1701529156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=nqGuNOYl1SLzo6ylGkUXn+s0jblVCXZ+ddT4AWHBo0Y=; b=ePPSTw7YXnwSZhgmsjXznG2+Bfhy3ApYI+NZ1iNMnsW+c97BJFXcZx025+Ivqq69dEhTbK 442Pa29HTmNu7Jlwr0md7GBeGDki9R/XGEj3JcmUe+gNpNhITv3tOZ/RZaAmr/GasgpBdZ lyQdFBkIZ/8fWzmQCdbXsnu0/5rCqMTOA8EO6th41KcWUKVak88TDKUs9ahET+7pcDqBA9 E5WAZvWTFdslNGn5p6BVuYw/kPBfApbFLOgbI1fSt7t2Wj9ZOIFAA8OHT1RnUR3LJycnCW oih/wmwY5V2tW1Yq2OQlIjQSTid5FlEg4IZS5fxyvkLpV9GUp4ZsFZp1uCopoQ== From: =?utf-8?q?Arsen_Arsenovi=C4=87?= To: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, binutils@sourceware.org Cc: =?utf-8?q?Arsen_Arsenovi=C4=87?= Subject: [PATCH] gettext: disable install, docs targets, libasprintf, threads Date: Sat, 2 Dec 2023 15:16:07 +0100 Message-ID: <20231202141722.1323526-2-arsen@aarsen.me> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4SjCkX4PmQz9sjB X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_INFOUSMEBIZ, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This fixes issues reported by David Edelsohn , and by Eric Gallager . ChangeLog: * Makefile.def (gettext): Disable (via missing) {install-,}{pdf,html,info,dvi} and TAGS targets. Set no_install to true. Add --disable-threads --disable-libasprintf. Drop the lib_path (as there are no shared libs). --- Afternoon, This patch disables various targets and features on the gettext module to fix problems reported by David Edelsohn and Eric Gallager in https://inbox.sourceware.org/CAGWvnynmWgNjup4cAwSbsy1vw_MJLQqSULwM=kTH_+Lt+_smbg@mail.gmail.com/ and followups and on IRC, respectively. The gettext module does not actually require any of these to be usable for the purposes of the toolchain, so disabling them seems to be a decent workaround. This seemed to fix the respective issues for both Eric and David, though, I could not get GDB to build on AIX with or without this patch applied (I needed to disable sim, gdb and gnulib modules). It is possible I am missing something. Due to some unfortunate circumstances, it's taken more time than anticipated to actually get this change tested, and I've had to context swap quite a few bits. Such a process has quite a lot of room for error. Tested on x86_64-unknown-freebsd13.2. Makefile.def | 13 +++- Makefile.in | 202 ++++++++------------------------------------------- [removed regenerated file from the patch below] 2 files changed, 40 insertions(+), 175 deletions(-) diff --git a/Makefile.in b/Makefile.in index da2344b3f3dc..3bd7d37e9605 100644 diff --git a/Makefile.def b/Makefile.def index 792f81447e1b..ba89d46b2495 100644 --- a/Makefile.def +++ b/Makefile.def @@ -80,8 +80,17 @@ host_modules= { module= gettext; bootstrap=true; no_install=true; // need it in some configuratons, which is determined via nontrivial tests. // Always enabling pic seems to make sense for something tied to // user-facing output. - extra_configure_flags='--disable-shared --disable-java --disable-csharp --with-pic'; - lib_path=intl/.libs; }; + extra_configure_flags='--disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf'; + missing= pdf; + missing= html; + missing= info; + missing= dvi; + missing= install-pdf; + missing= install-html; + missing= install-info; + missing= install-dvi; + missing= TAGS; + no_install= true; }; host_modules= { module= tcl; missing=mostlyclean; }; host_modules= { module= itcl; };