From patchwork Tue Nov 21 03:53:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 80402 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5481F3858439 for ; Tue, 21 Nov 2023 03:54:40 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id F09AE3858C98 for ; Tue, 21 Nov 2023 03:53:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F09AE3858C98 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F09AE3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700538804; cv=none; b=SwK4NS6OQ5LvDGWoBufgcSuKjSJNQeZMxil71pfkdWCYo0pX4jRuVvXXw+ELENjoRtYdsfbp+1486Q9XlXqLqjQOCIW+OXEdwTNq/19kwGd+gGeWfpPF2uxNjWg4HVXno09hT4TWwo6usq4Q3VZdq+ZgzLIUz2HJDAB3oacDD0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700538804; c=relaxed/simple; bh=jhmg/Ywi+OfSpzmzECHXqvEpVWL6d834YzdcybaTXDI=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=hCBYjxSJ4R/HrzmCrNVsbsqgnMPB1rfCPOyBQX2O2yRNHkKgtidssZkGrrhL/96yWsIW10T3cj/o52vsrwhaSdGFlI2jAdKawVFxmlceQ29lGqULqddIxMfOVKxi4s5DdcHqs7QRnzZhjwZQeiLjlsUeBy4cvDRRMK+6CuCU9z0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id 5BpmrSOJy8Hte5HpArHZWF; Tue, 21 Nov 2023 03:53:20 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 5Hp9rwHxJb8Qn5Hp9r3fjQ; Tue, 21 Nov 2023 03:53:19 +0000 X-Authority-Analysis: v=2.4 cv=IuQNzZzg c=1 sm=1 tr=0 ts=655c29af a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=pfhLtNyfPs45aFG1YTEA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZfbohtmvFd93cUKqi987Fd02MrPt6MsVWj+xEIv5eIg=; b=KYdur3OAlpL/GVJr27Sr9nwjtn WCIQKtt/IDIGnIGgNQt8UI621ckVDCFY5RmIZabcPnXelkQjr19Ukx5vOfaSsdypyD+9O62xRj/1o PAvYuH7kknUcRu1IW/Nf0SS+w; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:47856 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r5Hp8-0040be-2o for gdb-patches@sourceware.org; Mon, 20 Nov 2023 20:53:18 -0700 From: Tom Tromey Date: Mon, 20 Nov 2023 20:53:35 -0700 Subject: [PATCH 04/29] Fix latent bug in mdebugread.c MIME-Version: 1.0 Message-Id: <20231120-submit-domain-hacks-2-v1-4-29650d01b198@tromey.com> References: <20231120-submit-domain-hacks-2-v1-0-29650d01b198@tromey.com> In-Reply-To: <20231120-submit-domain-hacks-2-v1-0-29650d01b198@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r5Hp8-0040be-2o X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net ([192.168.0.21]) [97.122.77.73]:47856 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOOKDtDtZym7TwLQMYnpneKg1rxwVLSKpNiBDRF3jZZPAjPSJOd7PwQR9TzIXdbvcNJ2J7xTnFzphspoyW00DeMkuJbQKDDtUrQkgAm8SS9cjelQfuhG tVsQfYeYs3QGszaHMuRBKkv+YuQbpwinDnKEbh8PJSLpBep6zrLyPUXNAb5W/8Cu7iBFifBQRMKRbwJV9RJSzXMG1gbwHIRfPtU= X-Spam-Status: No, score=-3024.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org mdebugread.c makes a label symbol but puts it into VAR_DOMAIN. I think LABEL_DOMAIN is more appropriate. I don't have a way to test this. --- gdb/mdebugread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/mdebugread.c b/gdb/mdebugread.c index cd6638224e7..02cd0dc43d5 100644 --- a/gdb/mdebugread.c +++ b/gdb/mdebugread.c @@ -711,7 +711,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend, case stLabel: /* label, goes into current block. */ s = new_symbol (name); - s->set_domain (VAR_DOMAIN); /* So that it can be used */ + s->set_domain (LABEL_DOMAIN); /* So that it can be used */ s->set_aclass_index (LOC_LABEL); /* but not misused. */ s->set_section_index (section_index); s->set_value_address (sh->value);