From patchwork Wed Nov 15 19:45:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 79973 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D63F03858C33 for ; Wed, 15 Nov 2023 19:45:25 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id BB4E73858C74 for ; Wed, 15 Nov 2023 19:45:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB4E73858C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB4E73858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700077512; cv=none; b=EinWys2EDyBPMl4vYXsDkzIFnECH7ts6CCY0v4jsI8iXe2hAwv48cYMOEpCPRORvvonF//pXGO5liF7ngyd5QqqIYE3TjIQX+PND5NFzBs+CCxp5yROuvTSCC2tSoqIlj93VR000Xp0VXBlgVkQ/2GjaJKbXbQRcAWMq8kDbYCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700077512; c=relaxed/simple; bh=1dZiNphfFleO5GhY1L82/ilulZXepxtbrrdw1+T/ekg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=diWTuE0rPmLnlCTF3g9OC4B6Ak/rCTG+CbC+++BVrUEcyN53StOKQT30Jw3JbacxdzjfJLoJ88Nnup2jwEhU1vWWyF63ASdGRsYmXJRzl7wGX4YSQHrHRrKM55Wp98KcyAvYXMns8TuvVsPfx2ebV826JrETi2lvpMcDMrdAMC8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6009a.ext.cloudfilter.net ([10.0.30.184]) by cmsmtp with ESMTPS id 3L1Br3ovG8Hte3LowrZ4F8; Wed, 15 Nov 2023 19:45:06 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 3Lovr2ySMBOcc3LovrKkXO; Wed, 15 Nov 2023 19:45:05 +0000 X-Authority-Analysis: v=2.4 cv=J+25USrS c=1 sm=1 tr=0 ts=65551fc1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=sbP3LE6TThjafiqs3oQA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=K86UioreGk/VM4+7paPf1wS7yG7t35ev4XckhN/1+2M=; b=RJ/1pa0jM11/RdSTRr9Ip5lFzi RP47qwbVr5tXv0gQADtn4xmXqbNBvSXmCiaWJST0JqkhIjiS9y45TVV8mH7r1C9tF4r2P80bcSZJ+ yXjG7UK7dEoJo1KeD0Xxrs25o; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:49196 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r3Lov-001u2u-0l; Wed, 15 Nov 2023 12:45:05 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Fix small bug in compile.exp Date: Wed, 15 Nov 2023 12:45:13 -0700 Message-ID: <20231115194513.176487-1-tom@tromey.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r3Lov-001u2u-0l X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (localhost.localdomain) [97.122.77.73]:49196 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOtxjg8o6uyfOdqN6/GElKkHgOl18ASZD5m+nQq5cpsYr96sJST/+Y/H2HKoYTkUmoRnFV2BacNa9lfZtX/QmuywXRF62dy7NEMp+07FPLzcYj+UH2bS fmw1O/lwBuogkUbeELITFtVnpJwtf6jog+Jp79lDun5y8r1T1i/GFH0UlelAevuefpKYQxtndfdD/gL/6utPtM5i6qBHGTrVfk4= X-Spam-Status: No, score=-3024.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org compile.exp generally does not work for me on Fedora 38. However, I sent a GCC patch to fix the plugin crash. With that patch, I get this error from one test in compile.exp: gdb command line:1:22: warning: initialization of 'int (*)(int)' from incompatible pointer type 'int (*)()' [-Wincompatible-pointer-types] This patch adds a cast to compile.exp. This makes the test pass. Reviewed-by: Keith Seitz --- gdb/testsuite/gdb.compile/compile.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.compile/compile.exp b/gdb/testsuite/gdb.compile/compile.exp index f2ab4fafa93..86521e99dac 100644 --- a/gdb/testsuite/gdb.compile/compile.exp +++ b/gdb/testsuite/gdb.compile/compile.exp @@ -307,7 +307,7 @@ gdb_test "compile code globalvar = func_nodebug (75);" \ "call func_nodebug" gdb_test "p globalvar" " = -75" "expect -75" gdb_test \ - "compile code int (*funcp) (int) = func_nodebug; globalvar = funcp (76);" \ + "compile code int (*funcp) (int) = (int (*) (int)) func_nodebug; globalvar = funcp (76);" \ "warning: function has unknown return type; assuming int" \ "call func_nodebug indirectly" gdb_test "p globalvar" " = -76" "expect -76"