From patchwork Wed Nov 1 17:09:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 78883 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5FB62385773F for ; Wed, 1 Nov 2023 17:10:16 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id 367783858CDA for ; Wed, 1 Nov 2023 17:09:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 367783858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 367783858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::136 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698858589; cv=none; b=aTZ72mEruuorWZwfaBbEahvxVUQ0MSKkiZw7Epq262zJAwrONWMNQKo3IK2BlDQzBsPZOCg9beUUTIjpEuYiBu2mij+eoJQt4BMi5i0RPrd0vmfsrs93YzfsEuty/upPfWV76N3sbKTgk6ujq0E1aa4ipzLJdC72SugOaiDO734= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698858589; c=relaxed/simple; bh=ZJpsbR+SqEwJoaeUXcGC0M7lNS9uUBECSUbdtQ1r/gg=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=f1+0LwA6xIy1c5H5Ycd/1e+1V8V8dg2eOO8zoPAa09faq8qhbNn+3gaZUbEpzTw6IdmwEuqVh9Rr0eow4E6pb7N3sAfYuU6ZWDmfhqqO9FXc3wW3zBUUeso56GGMyHHPwYpgBcVyqgG0EuP1rXMddvczAwzHeCy3nZMY51qCV10= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x136.google.com with SMTP id e9e14a558f8ab-3594cb642beso1302675ab.3 for ; Wed, 01 Nov 2023 10:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1698858582; x=1699463382; darn=sourceware.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BolMrql4ZRlnAFZUDStuqSpmWv6r4RyeX4Pc5/7Pzm4=; b=TRI86sF9LmRGIP84zsrtASVMx1SYY7w9BaAUIhBC1xfRKZau2BdKxqwETuNMOe8Mlk nLqig7Z1wu7r1mzC5NswcAT0F6aWAQlBcCEz55hdmBcHjfJjh7cKA7EAXsoKyWTHyVmi pFxrK7EdiHeyM/+z/QaMjlUXWO7BBhx5DlDy/e7l1GBAWtfR7EgvRuV5XPCEGrHcYl3Q cj5op+AvOhD4QFq09WaXhHBZMmvdNCS9zFZTkMTS2IXmBzX0yERBmkvQHQBxzKlCkdiK CZYy0yC7QQs1fr6GYEy23IWNalrteBkaJ4j/IZuniWAW6Mr5NOT3krj+1CkJj21lgbUs xHMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698858582; x=1699463382; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BolMrql4ZRlnAFZUDStuqSpmWv6r4RyeX4Pc5/7Pzm4=; b=taT3QQfyQgVP7KYhHowcZb0Ud1d1ZRLHEs0FoT6Uimh4B9Bo7kL8f7hKyrhI5EIimt qoESwZXDShwF8Bj61T31s/LJeb7d7HunAITWh0TwMLpxvdHVSVxKahFJugUKBm5ZgpIy kg8bh4i5JZHi48dVYY3WD1nAyaHTnSkeclWf+u0NzZ05e6Nx44OgAODeos+7kL5sey1c GDudMcNyxm2e70MI0N8IHafXDO/PLD2xf2yV/fipwWEcnuRIT3Tz4lRg5G3Fhqt5oYXA JznxUYhlxE8taTvze64rSBMNWt7RR/WWedYI0C6liE4OdLbtugJN5SsUnjBTjRddXGup rlYw== X-Gm-Message-State: AOJu0Yw4my4/a1dllDJJxRs56BPmxeJO7922odSw4ht2EpLfl1j9jIOZ E3QKT8MVyHbWkitOSSBVl9Kl8uYIDzhj5uEYDC/NTw== X-Google-Smtp-Source: AGHT+IEZkPZVrYfPbfaUbD0RgJcZihtYnDmgb91HYX9j5egvXrDd1M9G5Rx9FXnTPyepMVmaYLYqVg== X-Received: by 2002:a05:6e02:cd3:b0:359:38ab:5a55 with SMTP id c19-20020a056e020cd300b0035938ab5a55mr4399785ilj.22.1698858582400; Wed, 01 Nov 2023 10:09:42 -0700 (PDT) Received: from localhost.localdomain (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id gm2-20020a0566382b8200b0042b3a328ee0sm1017019jab.166.2023.11.01.10.09.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 10:09:41 -0700 (PDT) From: Tom Tromey Date: Wed, 01 Nov 2023 11:09:39 -0600 Subject: [PATCH 7/7] Update gdb.Symbol.is_variable documentation MIME-Version: 1.0 Message-Id: <20231101-dap-nested-function-v1-7-0b0c3b228ac7@adacore.com> References: <20231101-dap-nested-function-v1-0-0b0c3b228ac7@adacore.com> In-Reply-To: <20231101-dap-nested-function-v1-0-0b0c3b228ac7@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Kévin found a bug in an earlier version of this series that was based on a misconception I had about Symbol.is_variable. This patch fixes the documentation to explain the method a bit better. --- gdb/doc/python.texi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi index afe447644c5..3a7d61af5a5 100644 --- a/gdb/doc/python.texi +++ b/gdb/doc/python.texi @@ -6045,7 +6045,9 @@ local variables will require a frame, but other symbols will not. @end defvar @defvar Symbol.is_variable -@code{True} if the symbol is a variable. +@code{True} if the symbol is a variable, as opposed to something like +a function or type. Note that this also returns @code{False} for +arguments. @end defvar A @code{gdb.Symbol} object has the following methods: