From patchwork Sun Oct 29 23:23:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 78714 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ADB773875DC1 for ; Sun, 29 Oct 2023 23:24:46 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 27FE73861929 for ; Sun, 29 Oct 2023 23:23:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 27FE73861929 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 27FE73861929 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698621795; cv=none; b=vx9zwHy/SHnKnZpt5Bb8E8qEYExid8x8ec6zTOyNJ5m7Jd3uGU5t/YW7YQIqHLMf1DGRRQnrtgRiQJYfYWKm1OEFXnGtDAsGN6T64GhivGOzZ5hMbj63uhviprZorEBAzNsAYo6XbuOtvbhESnMWYEMM/A7UdVp9K3/UZ1goevY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698621795; c=relaxed/simple; bh=SpEzjTDW4hBluDgMDuik13HVxJqF404+6UwE0rKix4I=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=NIqCDe+rBWtkIwASveJVmCeZ6n87grnQj+29VfU+zWAySgRJocpUzmcVhVLNgHnx0gZ0tRbsIIyx/obW1YUAJvp7mNjzUApT9FL+ghiGHmbdczZY6JtpwcY45gi2CFjXl5tit+V+bFDCX/FpwQj2Q1kjwkdiEfPOmWJ3HOl7jIs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5010a.ext.cloudfilter.net ([10.0.29.199]) by cmsmtp with ESMTPS id xBx7qo6Lm8HtexF7dqEXeD; Sun, 29 Oct 2023 23:23:09 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xF7cqqutboIDwxF7cqtrF8; Sun, 29 Oct 2023 23:23:09 +0000 X-Authority-Analysis: v=2.4 cv=TP1W9npa c=1 sm=1 tr=0 ts=653ee95d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=eRxpThcnFnfATnHW0x4A:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yb8Hmy9RHuIssnX4ccShrhrWo3DjkAq5USNucNuGFvk=; b=by/QUEhVi2vmED7kkpohbeeDno D438X8X1c8bCPQ/zRWpN1u+proBRw+W4yg6UnxPho6qBeUe+Hiw6/QquwPThOQfpVH6va26++ffxI PjzTdc+ZCu2LyreuX/4vl3kXs; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:56344 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1qxF7c-0042zY-0k for gdb-patches@sourceware.org; Sun, 29 Oct 2023 17:23:08 -0600 From: Tom Tromey Date: Sun, 29 Oct 2023 17:23:38 -0600 Subject: [PATCH 17/30] Change evaluate_var_value to accept a block_symbol MIME-Version: 1.0 Message-Id: <20231029-split-objfile-2023-bound-sym-october-v1-17-612531df2734@tromey.com> References: <20231029-split-objfile-2023-bound-sym-october-v1-0-612531df2734@tromey.com> In-Reply-To: <20231029-split-objfile-2023-bound-sym-october-v1-0-612531df2734@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1qxF7c-0042zY-0k X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net ([192.168.0.21]) [97.122.77.73]:56344 X-Source-Auth: tom+tromey.com X-Email-Count: 18 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEP2uG8lrlDPG7+WBi0aH+MfMKNqhjv/BplLFbIZQV7bp/rnNPORachqDkghq2EjdFz8KmMUsdEZ+gnvCRxHQ88tH2ynooIpkIDMMTn3T+6HQlPXbnCU bTuxWRH7nSp9WqhegmTHmdODOzZ2OhuxoUzNiB/D3t2BTsjVwOIQh1ISl+ftGqCkjCOa61vH75aZlfk86wr/FbA86zR4Ow6FgWg= X-Spam-Status: No, score=-3024.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This change evaluate_var_value to accept a block_symbol, preparing some code to use the new read_var_value overload. --- gdb/ada-lang.c | 4 +--- gdb/eval.c | 20 ++++++++------------ gdb/value.h | 3 +-- 3 files changed, 10 insertions(+), 17 deletions(-) diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index aeb21e0c15c..8f2fc5410d4 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -10828,9 +10828,7 @@ ada_var_value_operation::evaluate_for_cast (struct type *expect_type, struct expression *exp, enum noside noside) { - value *val = evaluate_var_value (noside, - std::get<0> (m_storage).block, - std::get<0> (m_storage).symbol); + value *val = evaluate_var_value (noside, std::get<0> (m_storage)); val = ada_value_cast (expect_type, val); diff --git a/gdb/eval.c b/gdb/eval.c index ba09599b28a..0f5e3c18a05 100644 --- a/gdb/eval.c +++ b/gdb/eval.c @@ -517,7 +517,7 @@ type_instance_operation::evaluate (struct type *expect_type, /* Helper for evaluating an OP_VAR_VALUE. */ value * -evaluate_var_value (enum noside noside, const block *blk, symbol *var) +evaluate_var_value (enum noside noside, block_symbol var) { /* JYG: We used to just return value::zero of the symbol type if we're asked to avoid side effects. Otherwise we return @@ -532,7 +532,7 @@ evaluate_var_value (enum noside noside, const block *blk, symbol *var) try { - ret = value_of_variable (var, blk); + ret = value_of_variable (var.symbol, var.block); } catch (const gdb_exception_error &except) @@ -540,7 +540,7 @@ evaluate_var_value (enum noside noside, const block *blk, symbol *var) if (noside != EVAL_AVOID_SIDE_EFFECTS) throw; - ret = value::zero (var->type (), not_lval); + ret = value::zero (var.symbol->type (), not_lval); } return ret; @@ -558,7 +558,7 @@ var_value_operation::evaluate (struct type *expect_type, symbol *var = std::get<0> (m_storage).symbol; if (var->type ()->code () == TYPE_CODE_ERROR) error_unknown_type (var->print_name ()); - return evaluate_var_value (noside, std::get<0> (m_storage).block, var); + return evaluate_var_value (noside, std::get<0> (m_storage)); } } /* namespace expr */ @@ -700,8 +700,7 @@ var_value_operation::evaluate_funcall (struct type *expect_type, if (symp.symbol->type ()->code () == TYPE_CODE_ERROR) error_unknown_type (symp.symbol->print_name ()); - value *callee = evaluate_var_value (noside, std::get<0> (m_storage).block, - symp.symbol); + value *callee = evaluate_var_value (noside, symp); return evaluate_subexp_do_call (exp, noside, callee, argvec, nullptr, expect_type); @@ -1108,7 +1107,7 @@ eval_op_func_static_var (struct type *expect_type, struct expression *exp, struct block_symbol sym = lookup_symbol (var, blk, VAR_DOMAIN, NULL); if (sym.symbol == NULL) error (_("No symbol \"%s\" in specified context."), var); - return evaluate_var_value (noside, sym.block, sym.symbol); + return evaluate_var_value (noside, sym); } /* Helper function that implements the body of OP_REGISTER. */ @@ -2326,8 +2325,7 @@ adl_func_operation::evaluate (struct type *expect_type, nullptr, &symp, nullptr, 0, noside); if (symp.symbol->type ()->code () == TYPE_CODE_ERROR) error_unknown_type (symp.symbol->print_name ()); - value *callee = evaluate_var_value (noside, std::get<1> (m_storage), - symp.symbol); + value *callee = evaluate_var_value (noside, symp); return evaluate_subexp_do_call (exp, noside, callee, args, nullptr, expect_type); @@ -2854,9 +2852,7 @@ var_value_operation::evaluate_for_cast (struct type *to_type, struct expression *exp, enum noside noside) { - value *val = evaluate_var_value (noside, - std::get<0> (m_storage).block, - std::get<0> (m_storage).symbol); + value *val = evaluate_var_value (noside, std::get<0> (m_storage)); val = value_cast (to_type, val); diff --git a/gdb/value.h b/gdb/value.h index 6f0b61a853d..37c07a41205 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -1344,8 +1344,7 @@ extern int using_struct_return (struct gdbarch *gdbarch, struct value *function, struct type *value_type); -extern value *evaluate_var_value (enum noside noside, const block *blk, - symbol *var); +extern value *evaluate_var_value (enum noside noside, block_symbol var); extern value *evaluate_var_msym_value (enum noside noside, struct objfile *objfile,