From patchwork Fri Oct 27 17:36:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 78622 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B892A385F02B for ; Fri, 27 Oct 2023 17:37:20 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id D1276385F02B for ; Fri, 27 Oct 2023 17:36:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1276385F02B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D1276385F02B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698428215; cv=none; b=Lgi9LY4ll72vvwnsI7FqyyYtXJZmT0FIWXXygWBCE+S67aynGpGs80yesv6AhM0yqEoqw8CDAnGrmH6OBROxtEzuJRAVHf6uFSrTp1s5gfT+dpeuHmbS+tx0zPNreYf3wlEJ6QQiviPgW99YLGq8459Iw2XBNEIVn7hdp1IpY9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698428215; c=relaxed/simple; bh=T+ovshzyjSzS1Gw7eDupRq0xuFA7K8Npwf22LG8yd7k=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=D3AXI9qRG+x6nOCOS2YyvYy8QaNwWs0g5PY9OPmJm2vQIJLq4amMNWA2qg/IGx2ZhmDZp39CgS+/JpngAkQdsX5MjOo+tvjH0UraJF4F+Z3/P5+Rgddip8Wmhv2Z7M4PS3E5hdBDN7ECe6OU9f1bvOP+kg7//f4wRXuPLk+EIvQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12d.google.com with SMTP id e9e14a558f8ab-357ccaf982eso7130955ab.0 for ; Fri, 27 Oct 2023 10:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1698428213; x=1699033013; darn=sourceware.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=klOSJRsq8XgXkDsR8S/6lvSqoyJ4+7BZHFdzMlXxb0w=; b=Wm1Ue+L8VLhu9rMD+YvyROadAD0W/5+BVyyuMzETzSeS70MIhNSDAFZW6nzYEpjsrL ioTkBTvnE63T8o9va1xJra6RvGpr43CoxU97VEBm25uVY+mEkbrz9B8A5UiSFGohYs7c vndRlfcRNCkkzoIEHs9Wsui0Qk2IjK/MyqvvfTGeDbJ4LfhPUby4huRLb16ZS/fYqVD+ D+oF6lNOe+XMR+jSC+3o7NSPHgBE9JIGysvB9R5o/6mvYjKiAGGns5CdOiQIX1K5Vs8z sc8/Jkf3YNEh63PHPygvNCGbVQ/Zz6evs+00fWVrdiEz7g2OYEbhVLhA9TCFIikW7HVD ocYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698428213; x=1699033013; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=klOSJRsq8XgXkDsR8S/6lvSqoyJ4+7BZHFdzMlXxb0w=; b=Qq7E8iFjSUOm/w3bO0sbUv6WHVdxtVRDIIlc0ZG8B3ArAoRR70vUEgLdSzWhVa1J0D AC8UWCpCfASoAv1V4MjxpbeCw4Zlh7ixyODokf3aqFtnOQuXO6gu2XCGaxnKmnfrJemq dg+N3l17xbXlkcNHSTJt6FCvDZ95YysmkY1sNlymLtxEHc+i3HfxwfDUYPwRhj/wOaQj UrbmgEF+1GSDr/IXRbZCe2Bi/u/yJVtdL+yoVuWtlbW41tU//m9cwJmL1dnCPzeJaKv9 rAtYVJHBYLxQeltaK3ppoIkgUnZFLRKYgV6PeTkP8pqAZOdeKtlfyuWKT/ZInXPvkv5P o2nA== X-Gm-Message-State: AOJu0Yz8i7+g8/d25dkXbAIc/h9zH0P9DzfkBduUxHiCc+6dHS/xxKCl GqRQpfeOQ7ZoFqpmSLIQM0Hr+NOqTkQCZSTcKIl94A== X-Google-Smtp-Source: AGHT+IGe43XnQt0PU/uLzzDzW2AvavTMbBPQ4t1dxai3n0vrq2z1wZEu2QupF9QrJNatZIKDJbsBuQ== X-Received: by 2002:a05:6e02:1c0c:b0:34f:739d:9bec with SMTP id l12-20020a056e021c0c00b0034f739d9becmr4124097ilh.31.1698428213121; Fri, 27 Oct 2023 10:36:53 -0700 (PDT) Received: from localhost.localdomain (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id r4-20020a92ce84000000b00357ce043118sm591754ilo.79.2023.10.27.10.36.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 10:36:52 -0700 (PDT) From: Tom Tromey Date: Fri, 27 Oct 2023 11:36:45 -0600 Subject: [PATCH v2 5/9] Remove some QUIT calls from need_access_label_p MIME-Version: 1.0 Message-Id: <20231027-field-bits-v2-5-cbec64f2136a@adacore.com> References: <20231027-field-bits-v2-0-cbec64f2136a@adacore.com> In-Reply-To: <20231027-field-bits-v2-0-cbec64f2136a@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I think these invocations of QUIT in need_access_label_p are overkill. QUIT is already called from its caller. This just removes them. --- gdb/c-typeprint.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c index e45098268c0..241fbca49b7 100644 --- a/gdb/c-typeprint.c +++ b/gdb/c-typeprint.c @@ -911,31 +911,25 @@ need_access_label_p (struct type *type) { if (type->is_declared_class ()) { - QUIT; for (int i = TYPE_N_BASECLASSES (type); i < type->num_fields (); i++) if (!TYPE_FIELD_PRIVATE (type, i)) return true; - QUIT; for (int j = 0; j < TYPE_NFN_FIELDS (type); j++) for (int i = 0; i < TYPE_FN_FIELDLIST_LENGTH (type, j); i++) if (!TYPE_FN_FIELD_PRIVATE (TYPE_FN_FIELDLIST1 (type, j), i)) return true; - QUIT; for (int i = 0; i < TYPE_TYPEDEF_FIELD_COUNT (type); ++i) if (!TYPE_TYPEDEF_FIELD_PRIVATE (type, i)) return true; } else { - QUIT; for (int i = TYPE_N_BASECLASSES (type); i < type->num_fields (); i++) if (TYPE_FIELD_PRIVATE (type, i) || TYPE_FIELD_PROTECTED (type, i)) return true; - QUIT; for (int j = 0; j < TYPE_NFN_FIELDS (type); j++) { - QUIT; for (int i = 0; i < TYPE_FN_FIELDLIST_LENGTH (type, j); i++) if (TYPE_FN_FIELD_PROTECTED (TYPE_FN_FIELDLIST1 (type, j), i) @@ -944,7 +938,6 @@ need_access_label_p (struct type *type) i)) return true; } - QUIT; for (int i = 0; i < TYPE_TYPEDEF_FIELD_COUNT (type); ++i) if (TYPE_TYPEDEF_FIELD_PROTECTED (type, i) || TYPE_TYPEDEF_FIELD_PRIVATE (type, i))