From patchwork Fri Oct 27 17:36:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 78626 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 041AF3871033 for ; Fri, 27 Oct 2023 17:37:41 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 2BE8C3853515 for ; Fri, 27 Oct 2023 17:36:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2BE8C3853515 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2BE8C3853515 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698428214; cv=none; b=fItjl0lQ5fwPxE5L7Dso9NhNwDZ9KpXxO/gFDGWrDt/3dq1UQGjbvCyMuEW2GB1HNPvS19kYnORRksMR2GbXJQ+0WpbHLUABlXuHcYYUGO9Bw2GROZBgph/+lkXnUDu0cwuJuyk8IqczW5/sQApq4/itfIlqNIkFAsf5qUV4S18= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698428214; c=relaxed/simple; bh=+a+RFQPpkcTcbixgsnhMd6Vn9yWeqpafp2nhf9nE+g4=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=FFuOZcy428Fb9UlU8n2yACof5Brucf8izxy2s6itWoETf47rJzEdI6pmDPDT8+8CU79t8sXZp5zMICJf8QcK9EJ4q1z6n2gwtW/V8Sjvvv0/oY+g52gWi9ydiCJlXlEPXWOxRlAL/p/lYy1fZK7IKHEsx/eIswPSXv5KV7N/DI8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-357e783edbdso7049165ab.3 for ; Fri, 27 Oct 2023 10:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1698428212; x=1699033012; darn=sourceware.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dcZRncqBOdmC56mA7NvB/FEdIFRU9NaCAI7uX7Fscbo=; b=OB2GsXPI6XeS82WvA7i1FyEJ661fz+V8WUfx7hRJhBMP+SNYJIqwif4M1tleBFARx+ U4aHEznnrU3bvRRvng781uPQG1hLNtGCtMrs2JA6WAI6zCoZv2QBzD5b9DNFL+BTa1c5 Q/aB0E7KlEaB5Y9uoTwHib6EqATmv+AI+4mtBBJOCRkFYO//prpNbvBss4xdzRCp+iwn PCsLppZ3COSkzRdvJ1MHydpMz3XbXmka5abxXuIfNCsqBNerlLKkwsBAHYIcOqR+fuXF xgy7yBCTVQmJoU2MahkLfVizLItGFpag/E+SOO+m0jO4HXAJSgAmr172J4QxV9QOljuJ wxMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698428212; x=1699033012; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dcZRncqBOdmC56mA7NvB/FEdIFRU9NaCAI7uX7Fscbo=; b=poZx7HWaBFgGXxFHA+1j0PqmD6X/cpppLpvgFXq+JX4ky9wBFJsXt9/UKTYwl4SWxa gMPSFc5IYYnuhPx0vQYuFY8BjSEWsLow/2MQTFyMhkFHG0f5/cbEy3kQEUeeg/aMbdgC Jnin8tzuQ8N7yC1xYdkDlsmXpK5R0rGlkruJFx9DCzv74eiiKsXcuZFk4Zg1c0Gfw7F3 B9624W6ahsfODJrrCwUXw3rlZvhmlWobzt0vSEhDtvLzxeW8awXwLpVFYoP1piBK/PtM 8mF/YOoSxlhYJ9CNUmpldA+GnBSX1OoeW/2y7oCwKYtN7FO6dMFzkBVBpkpK9c+I+ykb jD4w== X-Gm-Message-State: AOJu0Yyr8xMDMXazEYKEvDnGCLbpgCaHg09xSFYnXKcM4lPI7h+kUvgc c7J2aw2zKsgw0ambgoDw4hLKMkuO5ur8kWPgy26dRg== X-Google-Smtp-Source: AGHT+IFGYhGyqoTQju8ahh1WRNXHRa1YfWBuw372vFWvzVmegrMvNDvGfaZVSpEtR1raci6m9LWZpA== X-Received: by 2002:a05:6e02:214a:b0:351:c52:5092 with SMTP id d10-20020a056e02214a00b003510c525092mr3864512ilv.3.1698428212505; Fri, 27 Oct 2023 10:36:52 -0700 (PDT) Received: from localhost.localdomain (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id r4-20020a92ce84000000b00357ce043118sm591754ilo.79.2023.10.27.10.36.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 10:36:52 -0700 (PDT) From: Tom Tromey Date: Fri, 27 Oct 2023 11:36:44 -0600 Subject: [PATCH v2 4/9] Add field::is_public MIME-Version: 1.0 Message-Id: <20231027-field-bits-v2-4-cbec64f2136a@adacore.com> References: <20231027-field-bits-v2-0-cbec64f2136a@adacore.com> In-Reply-To: <20231027-field-bits-v2-0-cbec64f2136a@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This adds a field::is_public convenience method, and updates one spot to use it. --- gdb/gdbtypes.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index 0a6bd425a5f..a4d2f3fa3e6 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -686,6 +686,10 @@ struct field accessibility get_accessibility () const { return m_accessibility; } + /* True if this field is 'public'. */ + bool is_public () const + { return m_accessibility == accessibility::PUBLIC; } + /* True if this field is 'private'. */ bool is_private () const { return m_accessibility == accessibility::PRIVATE; } @@ -1964,7 +1968,7 @@ extern void set_type_vptr_basetype (struct type *, struct type *); #define TYPE_BASECLASS_NAME(thistype,index) (thistype->field (index).name ()) #define TYPE_BASECLASS_BITPOS(thistype,index) (thistype->field (index).loc_bitpos ()) #define BASETYPE_VIA_PUBLIC(thistype, index) \ - ((!TYPE_FIELD_PRIVATE(thistype, index)) && (!TYPE_FIELD_PROTECTED(thistype, index))) + ((thistype)->field (index).is_public ()) #define TYPE_CPLUS_DYNAMIC(thistype) TYPE_CPLUS_SPECIFIC (thistype)->is_dynamic #define BASETYPE_VIA_VIRTUAL(thistype, index) \