From patchwork Thu Sep 21 18:01:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 76543 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B3793385CC80 for ; Thu, 21 Sep 2023 18:02:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B3793385CC80 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695319349; bh=klOSJRsq8XgXkDsR8S/6lvSqoyJ4+7BZHFdzMlXxb0w=; h=Date:Subject:References:In-Reply-To:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=i/a/agRKgDz+rkqiwduIMGrA7Q37Pp03CA0Q8daB7QKRfdJODBA1IjHfKNPBhm1ek m4Yys/nR/08r5PXe5DgqYR4883XzjltalM9tsxJlH6+TgCpeDISQz8plGwqKtbyXv6 EyD1N6kcKX/aKe/V1P2OhZUPQr85rY6HlyFF2Ex4= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by sourceware.org (Postfix) with ESMTPS id EF5213858281 for ; Thu, 21 Sep 2023 18:01:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF5213858281 Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-794c7d95ba5so51111539f.0 for ; Thu, 21 Sep 2023 11:01:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695319292; x=1695924092; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=klOSJRsq8XgXkDsR8S/6lvSqoyJ4+7BZHFdzMlXxb0w=; b=MjBXHtLGXmhqKQkpIR7inCtR4lCqDhLVpdMy8o2Hx9EowBQKZ1H0ftDeujsQHNL7ws GS0RAlaRXAqjBYuk7pLhXUGUHJGQsaNmogZRMcrycpwMbOegUHHwq4VGWrpVks5FLI7s igstZ9DKBo9JBCMC3Ov5aDMAgPW3gXwou1Wst6g+ZxUbvJ9Ocr5hnxdMyekQrCcn0CX/ ylVjS/L+1i5Qpwvh92AJ26LAEplQfU7T9U62cXSM65awGZvIM4cLT1C7s3E+mIyrw7E3 DV/yCbUNVjNzZKi3D82PY/JQbnFnXZMKC2ha2O7zeKce0qIQnaXMQAHi2XEsEtUWRm+3 n0Zw== X-Gm-Message-State: AOJu0YyeOU42OhJ4keGJ9TnGzLVJQDP5hCOtTyQI9Jwg9oyRXbRd/pev l7jifpBq4SHDMfPYSG9URaSSeHDCdlqDYCNdVgSYWA== X-Google-Smtp-Source: AGHT+IFSuZbl2Qoizf7JYsRgvn/WrZEj+2daYOmD7n1s/gGZmcWunsHDv3YXe60CHY3qIsVXr79vFA== X-Received: by 2002:a6b:ec09:0:b0:783:4bc6:636e with SMTP id c9-20020a6bec09000000b007834bc6636emr6227686ioh.21.1695319292333; Thu, 21 Sep 2023 11:01:32 -0700 (PDT) Received: from localhost.localdomain (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id q6-20020a02a306000000b0042b52dc77e3sm483736jai.158.2023.09.21.11.01.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 11:01:31 -0700 (PDT) Date: Thu, 21 Sep 2023 12:01:32 -0600 Subject: [PATCH 5/7] Remove some QUIT calls from need_access_label_p MIME-Version: 1.0 Message-Id: <20230921-field-bits-v1-5-201285360900@adacore.com> References: <20230921-field-bits-v1-0-201285360900@adacore.com> In-Reply-To: <20230921-field-bits-v1-0-201285360900@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" I think these invocations of QUIT in need_access_label_p are overkill. QUIT is already called from its caller. This just removes them. --- gdb/c-typeprint.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c index e45098268c0..241fbca49b7 100644 --- a/gdb/c-typeprint.c +++ b/gdb/c-typeprint.c @@ -911,31 +911,25 @@ need_access_label_p (struct type *type) { if (type->is_declared_class ()) { - QUIT; for (int i = TYPE_N_BASECLASSES (type); i < type->num_fields (); i++) if (!TYPE_FIELD_PRIVATE (type, i)) return true; - QUIT; for (int j = 0; j < TYPE_NFN_FIELDS (type); j++) for (int i = 0; i < TYPE_FN_FIELDLIST_LENGTH (type, j); i++) if (!TYPE_FN_FIELD_PRIVATE (TYPE_FN_FIELDLIST1 (type, j), i)) return true; - QUIT; for (int i = 0; i < TYPE_TYPEDEF_FIELD_COUNT (type); ++i) if (!TYPE_TYPEDEF_FIELD_PRIVATE (type, i)) return true; } else { - QUIT; for (int i = TYPE_N_BASECLASSES (type); i < type->num_fields (); i++) if (TYPE_FIELD_PRIVATE (type, i) || TYPE_FIELD_PROTECTED (type, i)) return true; - QUIT; for (int j = 0; j < TYPE_NFN_FIELDS (type); j++) { - QUIT; for (int i = 0; i < TYPE_FN_FIELDLIST_LENGTH (type, j); i++) if (TYPE_FN_FIELD_PROTECTED (TYPE_FN_FIELDLIST1 (type, j), i) @@ -944,7 +938,6 @@ need_access_label_p (struct type *type) i)) return true; } - QUIT; for (int i = 0; i < TYPE_TYPEDEF_FIELD_COUNT (type); ++i) if (TYPE_TYPEDEF_FIELD_PROTECTED (type, i) || TYPE_TYPEDEF_FIELD_PRIVATE (type, i))