From patchwork Wed Sep 20 23:09:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 76477 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7F8C5385C6FC for ; Wed, 20 Sep 2023 23:10:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F8C5385C6FC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695251413; bh=2VAUvlqybkA4EQWtE9BkuSn1Uwancdtpu6/dDvwkIX0=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=YYEfufDbAcAnTU1IF2T/GzLWp+LjUw0XqkIYT2raqz9MHJvcixl/YcVfQM879x7z3 ekOhimHV+pC6Oq+csU0nU6GM2iR1x9HXZS+69AbUf5akqAwVV1JYuge0Ly2wm8zWrX sN5ho+qIC198OgKuL4qxWuov4pwX6nJyH3+5XCBM= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id E83543858C54 for ; Wed, 20 Sep 2023 23:09:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E83543858C54 Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-792707f78b5so16657339f.1 for ; Wed, 20 Sep 2023 16:09:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695251389; x=1695856189; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2VAUvlqybkA4EQWtE9BkuSn1Uwancdtpu6/dDvwkIX0=; b=b92m3EwtHttulpwSTnbkirUCr8j4dvWGhpCr2IhQZvAP0BwkaJTH/bBGKNgJ//NMKu ZXr9wGv3bhFkigYvGoWd/9i+B/wh5c7ZKuZtaqXrDXkDCzKvAVCHmaxvS7M8SYao1SAt JOocbmbG2kZYGwX4kZdbzA9VRjTHpcqkrSeda6gHz/q/A1/PzPEyUHhpPNaDrmHg2s4s P2BiZJccFQZ62lBypcO9oZcfxFiWEkrJ9uHFENQb52MIclWCnAIaeqErT49+fWMxbjid VVQ1vDwxvVwEVBTU8amkO6KtLC2HgnjL3GwrjND2hpkp3WQvCOlwBePUnCkKP53Qj25h aY4Q== X-Gm-Message-State: AOJu0YwPL19YuB4/P/ETXqPHpHrORTSAhk+9SS2aqX6w7t9gtqYrd4FY ZJYZhb7A70LrcA8vrFsQ3I/ytjWkNxu5gqNReAGTIw== X-Google-Smtp-Source: AGHT+IGfMxpCrDSFD/SXL4DPu9OXVBdLvbeioD4sTJY7ek8LZOgAepW9velip+RKaedcWjW2BfwW1g== X-Received: by 2002:a5e:dc48:0:b0:787:4f3c:730d with SMTP id s8-20020a5edc48000000b007874f3c730dmr4449923iop.18.1695251389205; Wed, 20 Sep 2023 16:09:49 -0700 (PDT) Received: from localhost.localdomain (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id y12-20020a6bd80c000000b0078680780694sm61141iob.34.2023.09.20.16.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 16:09:48 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Remove stray trailing "," from DAP breakpoint.py Date: Wed, 20 Sep 2023 17:09:38 -0600 Message-Id: <20230920230938.425621-1-tromey@adacore.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The buildbot pointed out that the last DAP series I checked in had an issue. Looking into it, it seems there is a stray trailing "," in breakpoint.py. This patch removes it. This seems to point out a test suite deficiency. I will look into fixing that. --- gdb/python/lib/gdb/dap/breakpoint.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/python/lib/gdb/dap/breakpoint.py b/gdb/python/lib/gdb/dap/breakpoint.py index 8518814a8d2..ae3a5027f35 100644 --- a/gdb/python/lib/gdb/dap/breakpoint.py +++ b/gdb/python/lib/gdb/dap/breakpoint.py @@ -119,7 +119,7 @@ def _breakpoint_descriptor(bp): ) if loc.address: - result["instructionReference"] = hex(loc.address), + result["instructionReference"] = hex(loc.address) return result