From patchwork Tue Jul 18 11:21:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guinevere Larsen X-Patchwork-Id: 72850 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B00F93857023 for ; Tue, 18 Jul 2023 11:26:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B00F93857023 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1689679609; bh=GtwCfYzkgkW4I36as6lIxiuoL6J8d2FAXq/NbX6MFIA=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=gd/hLTnGH06zxCKIYGGyIjBsFxN4XVStH1Wllo2e9oIHq48uaACa9kHFdW/6aQOnL +zeDugrH0ZYBKt4lTdIKDKKam+gWr/bplYN0fZi7ssnIuhXy4dvnN5136ZOehpYUSs 2H1Fl7lp1jMTSLVs6Ipg5YT9SY1MprDcdCoaprv0= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 268FA385700C for ; Tue, 18 Jul 2023 11:26:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 268FA385700C Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-613-ntHcQl_1OiOEH6iH_PXtpA-1; Tue, 18 Jul 2023 07:26:22 -0400 X-MC-Unique: ntHcQl_1OiOEH6iH_PXtpA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0D54C3C11C62 for ; Tue, 18 Jul 2023 11:26:22 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.225.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 871424CD0F8; Tue, 18 Jul 2023 11:26:21 +0000 (UTC) To: gdb-patches@sourceware.org Cc: Bruno Larsen Subject: [PATCH] gdb/cli: fixes to newly added "list ." command Date: Tue, 18 Jul 2023 13:21:41 +0200 Message-ID: <20230718112140.1911522-2-blarsen@redhat.com> In-Reply-To: <835af40f-edae-ba48-f121-a1cdd1f1147e@palves.net> References: <835af40f-edae-ba48-f121-a1cdd1f1147e@palves.net> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Bruno Larsen via Gdb-patches From: Guinevere Larsen Reply-To: Bruno Larsen Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" After the series that added this command was pushed, Pedro mentioned that the news description could easily be misinterpreted, as well as some code and test improvements that should be made. While fixing the test, I realized that code repetition wasn't happening as it should, so I took care of that too. Reviewed-By: Eli Zaretskii --- gdb/NEWS | 5 +++-- gdb/cli/cli-cmds.c | 18 +++++++++--------- gdb/doc/gdb.texinfo | 6 +++--- gdb/testsuite/gdb.base/list.exp | 19 +++++++++---------- 4 files changed, 24 insertions(+), 24 deletions(-) diff --git a/gdb/NEWS b/gdb/NEWS index ac5dc424d3f..dd2fc0103bc 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -87,8 +87,9 @@ * The Ada 2022 Enum_Rep and Enum_Val attributes are now supported. * The 'list' command now accepts '.' as an argument, which tells GDB to - print the location where the inferior is stopped. If the inferior hasn't - started yet, the command will print around the main function. + print the location around the last solitary line printed as part of + displaying a stack frame. If the inferior hasn't started yet, the + command will print around the main function. * Using the 'list' command with no arguments in a situation where the command would attempt to list past the end of the file now warns the diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 0fa24fd3df9..13d1ce71a9f 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -1272,10 +1272,10 @@ list_command (const char *arg, int from_tty) print_source_lines (cursal.symtab, range, 0); } - /* "l ." lists the default location again. */ + /* "list ." lists the default location again. */ else if (arg[0] == '.') { - try + if (target_has_stack ()) { /* Find the current line by getting the PC of the currently selected frame, and finding the line associated to it. */ @@ -1283,19 +1283,19 @@ list_command (const char *arg, int from_tty) CORE_ADDR curr_pc = get_frame_pc (frame); cursal = find_pc_line (curr_pc, 0); } - catch (const gdb_exception &e) + else { - /* If there was an exception above, it means the inferior - is not running, so reset the current source location to - the default. */ + /* The inferior is not running, so reset the current source + location to the default. */ clear_current_source_symtab_and_line (); set_default_source_symtab_and_line (); cursal = get_current_source_symtab_and_line (); } list_around_line (arg, cursal); - /* Advance argument so just pressing "enter" after using "list ." + /* Set the repeat args so just pressing "enter" after using "list ." will print the following lines instead of the same lines again. */ - arg++; + if (from_tty) + set_repeat_arguments (""); } return; @@ -2805,7 +2805,7 @@ and send its output to SHELL_COMMAND.")); = add_com ("list", class_files, list_command, _("\ List specified function or line.\n\ With no argument, lists ten more lines after or around previous listing.\n\ -\"list .\" lists ten lines arond where the inferior is stopped.\n\ +\"list .\" lists ten lines around where the inferior is stopped.\n\ \"list +\" lists the ten lines following a previous ten-line listing.\n\ \"list -\" lists the ten lines before a previous ten-line listing.\n\ One argument specifies a line, and ten lines are listed around that line.\n\ diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index cd86da50f46..c9377846bdc 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -9155,9 +9155,9 @@ Same as using with no arguments. Print lines just before the lines last printed. @item list . -Print the lines surrounding the location that is where the inferior -is stopped. If the inferior is not running, print around the main -function instead. +Print the lines surrounding the last solitary line printed as part +of displaying a fram. If the inferior is not running, print around +the main function instead. @end table @cindex @code{list}, how many lines to display diff --git a/gdb/testsuite/gdb.base/list.exp b/gdb/testsuite/gdb.base/list.exp index 582355996b0..520424c37c6 100644 --- a/gdb/testsuite/gdb.base/list.exp +++ b/gdb/testsuite/gdb.base/list.exp @@ -402,18 +402,16 @@ proc test_list_invalid_args {} { proc test_list_current_location {} { global binfile - # If the first "list" command that GDB runs is "list ." GDB may be - # unable to recognize that the inferior isn't running, so we should - # reload the inferior to test that condition. + # Restart the inferior to test "list ." before the inferior is started. clean_restart gdb_file_cmd ${binfile} - # Ensure that we are printing 10 lines + # Ensure that we are printing 10 lines. if {![set_listsize 10]} { return } - # First guarantee that GDB prints around the main function correctly + # First guarantee that GDB prints around the main function correctly. gdb_test "list ." \ "1.*\r\n2\[ \t\]+\r\n3\[ \t\]+int main \[)(\]+.*5\[ \t\]+int x;.*" \ "list . with inferior not running" @@ -423,17 +421,18 @@ proc test_list_current_location {} { return } - # Walk forward some lines + # Walk forward some lines. gdb_test "until 15" ".*15.*foo.*" # Test that the correct location is printed and that # using just "list" will print the following lines. - gdb_test "list ." ".*" "list current line after starting" - gdb_test "list" ".*" "confirm we are printing the following lines" + gdb_test "list ." "10\[ \t\]+foo \(.*\);.*19\[ \t\]+foo \(.*\);" "list current line after starting" + gdb_test "list" "20\[ \t\]+foo \(.*\);.*29\[ \t\]+foo \(.*\);" "confirm we are printing the following lines" # Test that list . will reset to current location - gdb_test "list ." ".*" "list around current line again" - gdb_test " " ".*" "testing repeated invocations with GDB's auto-repeat" + # and that an empty line lists the following lines. + gdb_test "list ." "10\[ \t\]+foo \(.*\);.*19\[ \t\]+foo \(.*\);" "list around current line again" + gdb_test " " "20\[ \t\]+foo \(.*\);.*29\[ \t\]+foo \(.*\);" "testing repeated invocations with GDB's auto-repeat" } clean_restart