From patchwork Tue Mar 3 09:51:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 38379 Received: (qmail 113699 invoked by alias); 3 Mar 2020 09:51:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 113686 invoked by uid 89); 3 Mar 2020 09:51:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2056 X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Mar 2020 09:51:23 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 91115ACCA for ; Tue, 3 Mar 2020 09:51:21 +0000 (UTC) Date: Tue, 3 Mar 2020 10:51:19 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix tcl error in gdb.mi/list-thread-groups-available.exp Message-ID: <20200303095118.GA11123@delia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes Hi, When running gdb.mi/list-thread-groups-available.exp, we get: ... Running gdb.mi/list-thread-groups-available.exp ... ERROR: tcl error sourcing gdb.mi/list-thread-groups-available.exp. ERROR: Too many arguments to gdb_test_multiple ... The problem is that the gdb_test_multiple call has as last argument a $mi_gdb_prompt, which is no longer supported syntax since 590003dc0e "[gdb/testsuite] Add -lbl option in gdb_test_multiple". Fix this by using the new -prompt syntax. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix tcl error in gdb.mi/list-thread-groups-available.exp gdb/testsuite/ChangeLog: 2020-03-03 Tom de Vries * gdb.mi/list-thread-groups-available.exp: Use -prompt syntax for gdb_test_multiple call. --- gdb/testsuite/gdb.mi/list-thread-groups-available.exp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp index 4cc7ce7b51..697ee343d8 100644 --- a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp +++ b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp @@ -56,7 +56,9 @@ set process_entry_re "{${id_re},${type_re}(,$description_re)?(,$user_re)?(,$core # The list can be long, so read entries one by one to avoid hitting the # timeout (especially when running with check-read1). -gdb_test_multiple "-list-thread-groups --available" "list available thread groups" { +set cmd "-list-thread-groups --available" +set test "list available thread groups" +gdb_test_multiple $cmd $test -prompt "$mi_gdb_prompt" { -re "\\^done,groups=\\\[" { # The beginning of the response. exp_continue @@ -71,7 +73,7 @@ gdb_test_multiple "-list-thread-groups --available" "list available thread group # The last entry. pass $gdb_test_name } -} $mi_gdb_prompt +} # List specific processes, make sure there are two entries. set spawn_id_1 [remote_spawn target $binfile]