From patchwork Tue Mar 3 09:35:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 38378 Received: (qmail 55037 invoked by alias); 3 Mar 2020 09:35:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 55029 invoked by uid 89); 3 Mar 2020 09:35:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Mar 2020 09:35:50 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id F378AACCA for ; Tue, 3 Mar 2020 09:35:47 +0000 (UTC) Date: Tue, 3 Mar 2020 10:35:46 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix mi-sym-info.exp with check-read1 Message-ID: <20200303093545.GA8219@delia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes Hi, When running gdb.mi/mi-sym-info.exp with check-read1, we run into: ... FAIL: gdb.mi/mi-sym-info.exp: List all functions FAIL: gdb.mi/mi-sym-info.exp: List all variables ... The problem is that while the $mi_gdb_prompt is active, gdb_test_multiple is used without -prompt "$mi_gdb_prompt$", so it defaults to matching $gdb_prompt. Fix this by adding the missing gdb_test_multiple arguments. Reg-tested on x86_64-linux with make targets check and check-read1. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix mi-sym-info.exp with check-read1 gdb/testsuite/ChangeLog: 2020-03-03 Tom de Vries * gdb.mi/mi-sym-info.exp: Add missing -prompt "$mi_gdb_prompt$" to gdb_test_multiple calls. --- gdb/testsuite/gdb.mi/mi-sym-info.exp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.mi/mi-sym-info.exp b/gdb/testsuite/gdb.mi/mi-sym-info.exp index 9df683ad9d..c07f3e8097 100644 --- a/gdb/testsuite/gdb.mi/mi-sym-info.exp +++ b/gdb/testsuite/gdb.mi/mi-sym-info.exp @@ -68,7 +68,8 @@ mi_gdb_test "113-symbol-info-types" \ # this command that we overflow expect's buffers, avoid this by # fetching the output piece by piece. set testname "List all functions" -gdb_test_multiple "114-symbol-info-functions --include-nondebug" ${testname} { +set cmd "114-symbol-info-functions --include-nondebug" +gdb_test_multiple $cmd ${testname} -prompt "${mi_gdb_prompt}$" { -re "114\\^done,symbols=\{debug=\\\[${symtab_re}(?:,${symtab_re})*\\\],nondebug=\\\[" { exp_continue } @@ -83,7 +84,8 @@ gdb_test_multiple "114-symbol-info-functions --include-nondebug" ${testname} { } set testname "List all variables" -gdb_test_multiple "115-symbol-info-variables --include-nondebug" ${testname} { +set cmd "115-symbol-info-variables --include-nondebug" +gdb_test_multiple $cmd ${testname} -prompt "${mi_gdb_prompt}$" { -re "115\\^done,symbols=\{debug=\\\[${symtab_re}(?:,${symtab_re})*\\\],nondebug=\\\[" { verbose -log "Got the first part of the input" exp_continue