From patchwork Wed Feb 19 12:45:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 38224 Received: (qmail 69398 invoked by alias); 19 Feb 2020 12:46:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 69387 invoked by uid 89); 19 Feb 2020 12:46:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=sept X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Feb 2020 12:46:03 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 79A03B220; Wed, 19 Feb 2020 12:46:01 +0000 (UTC) Date: Wed, 19 Feb 2020 13:45:59 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Cc: Tom Tromey , Pedro Alves Subject: [committed][gdb/testsuite] Fix c++/14186 kpass in cpexprs.exp Message-ID: <20200219124557.GA23645@delia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes Hi, With gdb.cp/cpexprs.exp, we see: ... KPASS: gdb.cp/cpexprs.exp: p CV::m(int) const (PRMS c++/14186) KPASS: gdb.cp/cpexprs.exp: p CV::m(int) volatile (PRMS c++/14186) KPASS: gdb.cp/cpexprs.exp: p CV::m(int) const volatile (PRMS c++/14186) ... The tests have been KPASSing since Sept 4 2017, due to commit 3693fdb3c8 'Make "p S::method() const::static_var" work too'. Fix this by removing the corresponding kfail. Committed to trunk. [ Removing the kfail was proposed and approved by Tom and Pedro in PR14186 comment 4 and 5. ] Thanks, - Tom [gdb/testsuite] Fix c++/14186 kpass in cpexprs.exp gdb/testsuite/ChangeLog: 2020-02-19 Tom de Vries * gdb.cp/cpexprs.exp: Remove c++/14186 kfail. --- gdb/testsuite/gdb.cp/cpexprs.exp | 3 --- 1 file changed, 3 deletions(-) diff --git a/gdb/testsuite/gdb.cp/cpexprs.exp b/gdb/testsuite/gdb.cp/cpexprs.exp index 9ccb94cf40..e8b898fa11 100644 --- a/gdb/testsuite/gdb.cp/cpexprs.exp +++ b/gdb/testsuite/gdb.cp/cpexprs.exp @@ -731,9 +731,6 @@ foreach cv {{} { const} { volatile} { const volatile}} { pass $test } } - if {"$cv" != ""} { - setup_kfail c++/14186 *-*-* - } gdb_test "p CV::m(int)$cv" [string_to_regexp $correct] }